From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7F68C4360C for ; Thu, 10 Oct 2019 08:45:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F8E621929 for ; Thu, 10 Oct 2019 08:45:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="W+rdSHYi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F8E621929 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z69b3r88VbENkfxgAx9Hn25P4FHwDK74bpdIHfVBbDg=; b=W+rdSHYitLwUho /KcKRKo3T0BY3tG0DeotD8L4K/XnlN/XnKunvm/dx3b5ypHXpi0MLbiSsiehAauJ1AHwc+z1OckHn I2modeFF7clPjV075CQqDQtvp10I3zUdLnMJ0Vy3hivl+Rxr+lJRfwPXIc+rN3i5P83K9rPQB9u8r Uxhp5/i1e15HN1YRW40XImB8GkoYFfrE5IfMwVV9F1/3s9RyJg22RQyEcD7lCRw62aQ04GC4BgAqB oMAWWUNV9HwOA56CZp6bL1gRchiBSzEua/d+B+mfDpRMuaXImQBMCEknjWVYrF5G1KWNln7DNYv1i QL7ijp8EnodLQHG2Ybwg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIU4j-0003EZ-59; Thu, 10 Oct 2019 08:45:33 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iIU4f-0003CU-PX; Thu, 10 Oct 2019 08:45:31 +0000 X-UUID: 1e3b05aedf33483ead6466a22ac9fe55-20191010 X-UUID: 1e3b05aedf33483ead6466a22ac9fe55-20191010 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1224794438; Thu, 10 Oct 2019 00:45:28 -0800 Received: from MTKMBS31DR.mediatek.inc (172.27.6.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Oct 2019 01:45:20 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31DR.mediatek.inc (172.27.6.102) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 10 Oct 2019 16:45:16 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 10 Oct 2019 16:45:16 +0800 Message-ID: <1570697118.32135.20.camel@mhfsdcap03> Subject: Re: [PATCH] usb: mtk-xhci: Set the XHCI_NO_64BIT_SUPPORT quirk From: Chunfeng Yun To: Tomasz Figa Date: Thu, 10 Oct 2019 16:45:18 +0800 In-Reply-To: <20191010075004.192818-1-tfiga@chromium.org> References: <20191010075004.192818-1-tfiga@chromium.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: B90345DAD5A894277746B2A803C573FB68AC83DB838DD9C7583D5D1E62D8AAD32000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_014529_867372_693E407E X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Changqi Hu , Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, open list , Shik Chen , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Tomasz, On Thu, 2019-10-10 at 16:50 +0900, Tomasz Figa wrote: > MediaTek XHCI host controller does not support 64-bit addressing despite > the AC64 bit of HCCPARAMS1 register being set. The platform-specific > glue sets the DMA mask to 32 bits on its own, but it has no effect, > because xhci_gen_setup() overrides it according to hardware > capabilities. > > Use the XHCI_NO_64BIT_SUPPORT quirk to tell the XHCI core to force > 32-bit DMA mask instead. > > Signed-off-by: Tomasz Figa > --- > drivers/usb/host/xhci-mtk.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c > index b18a6baef204a..4d101d52cc11b 100644 > --- a/drivers/usb/host/xhci-mtk.c > +++ b/drivers/usb/host/xhci-mtk.c > @@ -395,6 +395,11 @@ static void xhci_mtk_quirks(struct device *dev, struct xhci_hcd *xhci) > xhci->quirks |= XHCI_SPURIOUS_SUCCESS; > if (mtk->lpm_support) > xhci->quirks |= XHCI_LPM_SUPPORT; > + /* > + * MTK host controller does not support 64-bit addressing, despite > + * having the AC64 bit of the HCCPARAMS1 register set. > + */ > + xhci->quirks |= XHCI_NO_64BIT_SUPPORT; Somes SoCs support 64bits in fact, so can't support this quirk, do you encounter any issues without this quirk? > } > > /* called during probe() after chip reset completes */ > @@ -488,11 +493,6 @@ static int xhci_mtk_probe(struct platform_device *pdev) > goto disable_clk; > } > > - /* Initialize dma_mask and coherent_dma_mask to 32-bits */ > - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); > - if (ret) > - goto disable_clk; > - > hcd = usb_create_hcd(driver, dev, dev_name(dev)); > if (!hcd) { > ret = -ENOMEM; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel