From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C6C0C432C0 for ; Fri, 29 Nov 2019 08:46:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BDA021721 for ; Fri, 29 Nov 2019 08:46:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tBVLNPUW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="IdBDLiqK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BDA021721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UsURzao5L4NvpKqPNrlMqQvEQfTz4VZ8PCVVYGCrPY4=; b=tBVLNPUWaaoWfO Xei9bB7Trr7angSO9tUwBEyxLsRcTjOT2SXgPB3CoMv/o/g31+i2PHuA8A/1YjNtIuLItVyTZ6LrZ Wk65neDRVdvcDdbwNoB1AIkmn3h07s5xX3Vv8QulTucaVddhgJwuyer8BrPy6jBvsDV/TptiMypiJ 8hYjDpZhSNkJNeeEXylZIKBzC4vQUHX30nn/0Kh8j+K5FNuKuRy6Qvm0i2UjRKi1w61IzidyhGfR8 dV6ZqeckQPkb3NOHbFgD/K3guqaFI1nfcvI96vkRWignH6ulnky+rDD48/ki9xDw2ffNEhKgqUsAk 9vvgHPZaNfcq5hK1Zn/g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iabvN-0001mW-EJ; Fri, 29 Nov 2019 08:46:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iabvJ-0001ly-Hh; Fri, 29 Nov 2019 08:46:47 +0000 X-UUID: 9929aec8d9514781883644b9cd79ea4e-20191129 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=l+vMQsn6f/SuEx56zpBOxYhNu7Sl465Vyth21G0zRHE=; b=IdBDLiqKa6cG/hfynpfVctH0CMWMqn4zoAu9kxkrfJO500SitEgptrrXZP4ogbJForOxFcRpc4ZoLAXURsay7G1vnrPkgCP13X0+nszgfVLFsne5Wz3iBsmQOsnQWPksLMHn+wbKgDtIIuPt5sano5Zo5lsjWwUWbp1jWiLEZ68=; X-UUID: 9929aec8d9514781883644b9cd79ea4e-20191129 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 721978830; Fri, 29 Nov 2019 00:46:31 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 29 Nov 2019 00:37:08 -0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 29 Nov 2019 16:36:27 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 29 Nov 2019 16:36:39 +0800 Message-ID: <1575016588.7013.8.camel@mhfsdcap03> Subject: Re: [PATCH v5 2/2] watchdog: mtk_wdt: mt8183: Add reset controller From: Yong Liang To: Philipp Zabel Date: Fri, 29 Nov 2019 16:36:28 +0800 In-Reply-To: References: <20191125061627.GA7313@roeck-us.net> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 6FAFCEEDDD7A780F59BA06ED3A9B65A0F90AD52681FD3F25AC497AAE868679072000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191129_004645_598361_D276AE87 X-CRM114-Status: GOOD ( 25.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "alsa-devel@alsa-project.org" , "broonie@kernel.org" , "lgirdwood@gmail.com" , Jiaxin Yu =?UTF-8?Q?=28=E4=BF=9E=E5=AE=B6=E9=91=AB=29?= , "perex@perex.cz" , "tzungbi@google.com" , "robh+dt@kernel.org" , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , Eason Yen =?UTF-8?Q?=28=E9=A1=8F=E5=BB=B7=E4=BB=BB=29?= , Yingjoe Chen =?UTF-8?Q?=28=E9=99=B3=E8=8B=B1=E6=B4=B2=29?= , "wim@linux-watchdog.org" , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-11-25 at 17:51 +0800, Philipp Zabel wrote: > Hi, > > On Sun, 2019-11-24 at 22:16 -0800, Guenter Roeck wrote: > > On Mon, Nov 25, 2019 at 11:03:50AM +0800, Jiaxin Yu wrote: > > > From: "yong.liang" > > > > > > Add reset controller API in watchdog driver. > > > Besides watchdog, MTK toprgu module also provide sub-system (eg, audio, > > > camera, codec and connectivity) software reset functionality. > > > > > > Signed-off-by: yong.liang > > > Signed-off-by: jiaxin.yu > > > Reviewed-by: Yingjoe Chen > > > --- > > > drivers/watchdog/Kconfig | 1 + > > > drivers/watchdog/mtk_wdt.c | 111 ++++++++++++++++++++++++++++++++++++- > > > 2 files changed, 111 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > > > index 2e07caab9db2..629249fe5305 100644 > > > --- a/drivers/watchdog/Kconfig > > > +++ b/drivers/watchdog/Kconfig > > > @@ -717,6 +717,7 @@ config MEDIATEK_WATCHDOG > > > tristate "Mediatek SoCs watchdog support" > > > depends on ARCH_MEDIATEK || COMPILE_TEST > > > select WATCHDOG_CORE > > > + select RESET_CONTROLLER > > > help > > > Say Y here to include support for the watchdog timer > > > in Mediatek SoCs. > > > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c > > > index 9c3d0033260d..d29484c7940a 100644 > > > --- a/drivers/watchdog/mtk_wdt.c > > > +++ b/drivers/watchdog/mtk_wdt.c > > > @@ -9,6 +9,9 @@ > > > * Based on sunxi_wdt.c > > > */ > > > > > > +#include > > > +#include > > > +#include > > > #include > > > #include > > > #include > > > @@ -16,10 +19,12 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > +#include > > > +#include > > > #include > > > #include > > > -#include > > > > > > #define WDT_MAX_TIMEOUT 31 > > > #define WDT_MIN_TIMEOUT 1 > > > @@ -44,6 +49,9 @@ > > > #define WDT_SWRST 0x14 > > > #define WDT_SWRST_KEY 0x1209 > > > > > > +#define WDT_SWSYSRST 0x18U > > > +#define WDT_SWSYS_RST_KEY 0x88000000 > > > + > > > #define DRV_NAME "mtk-wdt" > > > #define DRV_VERSION "1.0" > > > > > > @@ -53,8 +61,99 @@ static unsigned int timeout; > > > struct mtk_wdt_dev { > > > struct watchdog_device wdt_dev; > > > void __iomem *wdt_base; > > > + spinlock_t lock; /* protects WDT_SWSYSRST reg */ > > > + struct reset_controller_dev rcdev; > > > +}; > > > + > > > +struct mtk_wdt_data { > > > + int sw_rst_num; > > > }; > > > > > > +static const struct mtk_wdt_data mt2712_data = { > > > + .sw_rst_num = MT2712_TOPRGU_SW_RST_NUM, > > > +}; > > > + > > > +static const struct mtk_wdt_data mt8183_data = { > > > + .sw_rst_num = MT8183_TOPRGU_SW_RST_NUM, > > > +}; > > > > The number of resets can be set in .data directly; there is no need > > for the structures. We want to put all properities in mtxxxx-resets.h and it easy to manager. If there are new properity in the feture, we can put it in mtk_wdt_data mtxxxx_data > > > > > + > > > +static int toprgu_reset_assert(struct reset_controller_dev *rcdev, > > > + unsigned long id) > > > +{ > > > + unsigned int tmp; > > > + unsigned long flags; > > > + struct mtk_wdt_dev *data = > > > + container_of(rcdev, struct mtk_wdt_dev, rcdev); > > > + > > > + spin_lock_irqsave(&data->lock, flags); > > > + > > > + tmp = __raw_readl(data->wdt_base + WDT_SWSYSRST); > > I think this should be readl_relaxed() instead. I don't expect this > driver will ever be used on a big-endian architecture, but mixing > __raw_readl() and writel() does look dangerous. OK, I will change __raw_readl() to readl() > > > > + tmp |= BIT(id); > > > + tmp |= WDT_SWSYS_RST_KEY; > > > + writel(tmp, data->wdt_base + WDT_SWSYSRST); > > > + > > > + spin_unlock_irqrestore(&data->lock, flags); > > > + > > > + return 0; > > > +} > > > + > > > +static int toprgu_reset_deassert(struct reset_controller_dev *rcdev, > > > + unsigned long id) > > > +{ > > > + unsigned int tmp; > > > + unsigned long flags; > > > + struct mtk_wdt_dev *data = > > > + container_of(rcdev, struct mtk_wdt_dev, rcdev); > > > + > > > + spin_lock_irqsave(&data->lock, flags); > > > + > > > + tmp = __raw_readl(data->wdt_base + WDT_SWSYSRST); > > > + tmp &= ~BIT(id); > > > + tmp |= WDT_SWSYS_RST_KEY; > > > + writel(tmp, data->wdt_base + WDT_SWSYSRST); > > > + > > > + spin_unlock_irqrestore(&data->lock, flags); > > > + > > > + return 0; > > > +} > > > > There is a lot of duplication in those functions. Only one line > > is different. I think this is a good example where a helper function > > with an additional argument indicating set or reset would be helpful. > > .assert and .dessert are two numbers of struct reset_control_ops. I think it's better to define both of them. > > > + > > > +static int toprgu_reset(struct reset_controller_dev *rcdev, > > > + unsigned long id) > > > +{ > > > + int ret; > > > + > > > + ret = toprgu_reset_assert(rcdev, id); > > > + if (ret) > > > + return ret; > > > + > > > + return toprgu_reset_deassert(rcdev, id); > > > +} > > > + > > > +static const struct reset_control_ops toprgu_reset_ops = { > > > + .assert = toprgu_reset_assert, > > > + .deassert = toprgu_reset_deassert, > > > + .reset = toprgu_reset, > > > +}; > > > + > > > +static int toprgu_register_reset_controller(struct platform_device *pdev, > > > + int rst_num) > > > +{ > > > + int ret; > > > + struct mtk_wdt_dev *mtk_wdt = platform_get_drvdata(pdev); > > > + > > > + spin_lock_init(&mtk_wdt->lock); > > > + > > > + mtk_wdt->rcdev.owner = THIS_MODULE; > > > + mtk_wdt->rcdev.nr_resets = rst_num; > > > + mtk_wdt->rcdev.ops = &toprgu_reset_ops; > > > + mtk_wdt->rcdev.of_node = pdev->dev.of_node; > > > + ret = reset_controller_register(&mtk_wdt->rcdev); > > I see this driver uses devm_kzalloc() below. Should this be > devm_reset_controller_register()? > > > > + if (ret != 0) > > > + dev_err(&pdev->dev, > > > + "couldn't register wdt reset controller: %d\n", ret); > > > + return ret; > > > +} > > > + > > > static int mtk_wdt_restart(struct watchdog_device *wdt_dev, > > > unsigned long action, void *data) > > > { > > > @@ -155,6 +254,7 @@ static int mtk_wdt_probe(struct platform_device *pdev) > > > { > > > struct device *dev = &pdev->dev; > > > struct mtk_wdt_dev *mtk_wdt; > > > + struct mtk_wdt_data *wdt_data; > > > int err; > > > > > > mtk_wdt = devm_kzalloc(dev, sizeof(*mtk_wdt), GFP_KERNEL); > > regards > Philipp > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel