From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F8AC432C0 for ; Tue, 3 Dec 2019 12:31:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B21D2073B for ; Tue, 3 Dec 2019 12:31:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jAWYofVB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="j/GH6XF2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B21D2073B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:From:To: Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=AJVtVp+J+dEO0NpqUqqXQNNLuGa6dLOKJ+fR3jtZ7hM=; b=jAWYofVBvJ5pXe I9H6CLXIYQM7nkD3F5JX3Hofyo/tXXPeDAWjeSpql+/5kVUR+5CUG6J6hkhW2M1HkA4PSgFmfwpX4 Ajmzx2bbC9Su8VXOQQj0kdqIQ7OzGU7v7hWN8U6y/egMxOQ0mWKT63iVHfiEaF6wtM5YUobMEaxOy lCYjahUqf8xCHQbPVns6W/kU2VWJu52J7xlV7XD7omXm+iQzbQ0CDSinQhfDys252QAGSjsJ3TkMM GEw/n35gJtFzGbQGtxYp7qNXoLh3ijzM8GP1V1NXtbY/fjKshrBXeToKTrG6hs1HNyMB6e3gGUEro 2Yekcdob2FHX9TI0kEZA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic7Ka-0001Sw-QF; Tue, 03 Dec 2019 12:31:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic7KW-0001SK-L1; Tue, 03 Dec 2019 12:31:02 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 127E52073C; Tue, 3 Dec 2019 12:30:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575376259; bh=4bPoHww62PiAifL9wchSjqkMtb4cUfKs/nolfKBokxk=; h=Subject:To:Cc:From:Date:From; b=j/GH6XF20vW2yLEZJk09oFfKGzC1K829y6CayX2nmVKV6Jjc2zyhpflx4P7ediHgm Hf3XKlbGQQR/BuTeH5LY0zObVjYa0lVDWnv5uQtJZl4rTutUPnFERIOreiiluBi4Iy 29m5FGPywEZ8UXw/LaMTYlgS+yQd57bw/3s8aR3A= Subject: Patch "mtd: rawnand: atmel: fix possible object reference leak" has been added to the 4.14-stable tree To: alexandre.belloni@bootlin.com, bbrezillon@kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, gregkh@linuxfoundation.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, ludovic.desroches@microchip.com, marek.vasut@gmail.com, miquel.raynal@bootlin.com, nicolas.ferre@microchip.com, richard@nod.at, tudor.ambarus@microchip.com, yellowriver2010@hotmail.com From: Date: Tue, 03 Dec 2019 13:30:43 +0100 Message-ID: <1575376243232191@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_043100_729076_9E58316E X-CRM114-Status: GOOD ( 14.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable-commits@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled mtd: rawnand: atmel: fix possible object reference leak to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: mtd-rawnand-atmel-fix-possible-object-reference-leak.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From a12085d13997ed15f745f33a0e01002541160179 Mon Sep 17 00:00:00 2001 From: Wen Yang Date: Thu, 7 Feb 2019 03:50:55 +0000 Subject: mtd: rawnand: atmel: fix possible object reference leak From: Wen Yang commit a12085d13997ed15f745f33a0e01002541160179 upstream. of_find_device_by_node() takes a reference to the struct device when it finds a match via get_device, there is no need to call get_device() twice. We also should make sure to drop the reference to the device taken by of_find_device_by_node() on driver unbind. Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") Signed-off-by: Wen Yang Suggested-by: Boris Brezillon Reviewed-by: Boris Brezillon Reviewed-by: Miquel Raynal Acked-by: Miquel Raynal Cc: Tudor Ambarus Cc: Boris Brezillon Cc: Miquel Raynal Cc: Richard Weinberger Cc: David Woodhouse Cc: Brian Norris Cc: Marek Vasut Cc: Nicolas Ferre Cc: Alexandre Belloni Cc: Ludovic Desroches Cc: linux-mtd@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Miquel Raynal Signed-off-by: Lee Jones Signed-off-by: Greg Kroah-Hartman --- drivers/mtd/nand/atmel/pmecc.c | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) --- a/drivers/mtd/nand/atmel/pmecc.c +++ b/drivers/mtd/nand/atmel/pmecc.c @@ -875,23 +875,32 @@ static struct atmel_pmecc *atmel_pmecc_g { struct platform_device *pdev; struct atmel_pmecc *pmecc, **ptr; + int ret; pdev = of_find_device_by_node(np); - if (!pdev || !platform_get_drvdata(pdev)) + if (!pdev) return ERR_PTR(-EPROBE_DEFER); + pmecc = platform_get_drvdata(pdev); + if (!pmecc) { + ret = -EPROBE_DEFER; + goto err_put_device; + } ptr = devres_alloc(devm_atmel_pmecc_put, sizeof(*ptr), GFP_KERNEL); - if (!ptr) - return ERR_PTR(-ENOMEM); - - get_device(&pdev->dev); - pmecc = platform_get_drvdata(pdev); + if (!ptr) { + ret = -ENOMEM; + goto err_put_device; + } *ptr = pmecc; devres_add(userdev, ptr); return pmecc; + +err_put_device: + put_device(&pdev->dev); + return ERR_PTR(ret); } static const int atmel_pmecc_strengths[] = { 2, 4, 8, 12, 24, 32 }; Patches currently in stable-queue which might be from yellowriver2010@hotmail.com are queue-4.14/mtd-rawnand-atmel-fix-possible-object-reference-leak.patch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel