Linux-ARM-Kernel Archive on
 help / color / Atom feed
* Patch "mtd: rawnand: atmel: fix possible object reference leak" has been added to the 4.14-stable tree
@ 2019-12-03 12:30 gregkh
  0 siblings, 0 replies; only message in thread
From: gregkh @ 2019-12-03 12:30 UTC (permalink / raw)
  To: alexandre.belloni, bbrezillon, computersforpeace, dwmw2, gregkh,
	lee.jones, linux-arm-kernel, linux-mtd, ludovic.desroches,
	marek.vasut, miquel.raynal, nicolas.ferre, richard,
	tudor.ambarus, yellowriver2010
  Cc: stable-commits

This is a note to let you know that I've just added the patch titled

    mtd: rawnand: atmel: fix possible object reference leak

to the 4.14-stable tree which can be found at:;a=summary

The filename of the patch is:
and it can be found in the queue-4.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <> know about it.

From a12085d13997ed15f745f33a0e01002541160179 Mon Sep 17 00:00:00 2001
From: Wen Yang <>
Date: Thu, 7 Feb 2019 03:50:55 +0000
Subject: mtd: rawnand: atmel: fix possible object reference leak

From: Wen Yang <>

commit a12085d13997ed15f745f33a0e01002541160179 upstream.

of_find_device_by_node() takes a reference to the struct device
when it finds a match via get_device, there is no need to call
get_device() twice.
We also should make sure to drop the reference to the device
taken by of_find_device_by_node() on driver unbind.

Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
Signed-off-by: Wen Yang <>
Suggested-by: Boris Brezillon <>
Reviewed-by: Boris Brezillon <>
Reviewed-by: Miquel Raynal <>
Acked-by: Miquel Raynal <>
Cc: Tudor Ambarus <>
Cc: Boris Brezillon <>
Cc: Miquel Raynal <>
Cc: Richard Weinberger <>
Cc: David Woodhouse <>
Cc: Brian Norris <>
Cc: Marek Vasut <>
Cc: Nicolas Ferre <>
Cc: Alexandre Belloni <>
Cc: Ludovic Desroches <>
Signed-off-by: Miquel Raynal <>
Signed-off-by: Lee Jones <>
Signed-off-by: Greg Kroah-Hartman <>

 drivers/mtd/nand/atmel/pmecc.c |   21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

--- a/drivers/mtd/nand/atmel/pmecc.c
+++ b/drivers/mtd/nand/atmel/pmecc.c
@@ -875,23 +875,32 @@ static struct atmel_pmecc *atmel_pmecc_g
 	struct platform_device *pdev;
 	struct atmel_pmecc *pmecc, **ptr;
+	int ret;
 	pdev = of_find_device_by_node(np);
-	if (!pdev || !platform_get_drvdata(pdev))
+	if (!pdev)
+	pmecc = platform_get_drvdata(pdev);
+	if (!pmecc) {
+		ret = -EPROBE_DEFER;
+		goto err_put_device;
+	}
 	ptr = devres_alloc(devm_atmel_pmecc_put, sizeof(*ptr), GFP_KERNEL);
-	if (!ptr)
-		return ERR_PTR(-ENOMEM);
-	get_device(&pdev->dev);
-	pmecc = platform_get_drvdata(pdev);
+	if (!ptr) {
+		ret = -ENOMEM;
+		goto err_put_device;
+	}
 	*ptr = pmecc;
 	devres_add(userdev, ptr);
 	return pmecc;
+	put_device(&pdev->dev);
+	return ERR_PTR(ret);
 static const int atmel_pmecc_strengths[] = { 2, 4, 8, 12, 24, 32 };

Patches currently in stable-queue which might be from are


linux-arm-kernel mailing list

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-03 12:30 Patch "mtd: rawnand: atmel: fix possible object reference leak" has been added to the 4.14-stable tree gregkh

Linux-ARM-Kernel Archive on

Archives are clonable:
	git clone --mirror linux-arm-kernel/git/0.git
	git clone --mirror linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ \
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone