From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5147BC43603 for ; Thu, 12 Dec 2019 02:03:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 241FB2077B for ; Thu, 12 Dec 2019 02:03:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MS7BYGMJ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="FJqm1hGY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 241FB2077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qYCtzgItmvTljcd+yWiEPj2j+AyYOz1N2afyQwR+S9U=; b=MS7BYGMJQoMdJu /ghHCwOL16nMF9nLgqSeTOKogcDHusUXawAdTWdL2EKbqf66WWW/fW7ZGAD0fjETwZaOROHWK/cZA XHXIRFKVHlBHMGfsjqqSIOZnKJujchw4NWRM2bH2JBBtijl5rsmg/joqzBN1iexyrNEpT8VF/Ozno WtiMJ7Wf7JITbPdjPDOO6IQ9nME3bB4Wwqa8CuEZv9SDAxJj56/LNTFwQigjYnqDD7nhCqe4zwyFX q3fRgTV8Ik2J2wQPC2A2JIKleiOk9pPkZtoyV9TMJ1nybCC2reVHFrrIQkdLPwzrMliv8vpDy5egG 67OnlRNleaZ+WjTaXQHw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifDpO-00050X-G4; Thu, 12 Dec 2019 02:03:42 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifDpL-0004zT-BN; Thu, 12 Dec 2019 02:03:40 +0000 X-UUID: 42fb624a37d54a6498161dbadf683991-20191211 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=58Kn1gNg/Vbwnp9rOtOIWJfzSVNVySk5I9bvfgOs8zs=; b=FJqm1hGYBNcAr0iCcqx0uQRFX+TkLaek5WlEXOOW8/psp/5KbWOkLqnX0SRxtPTLncu22Vrr9z84cz4KnxHP4st2AKLCtGmaIYZ0GgwVy1ofrnd2AGMrMPbzMue7ev1eKGIptPFlZeswsQ5PB4o1BzVZLdIyzf0LpH8zw0SgqZE=; X-UUID: 42fb624a37d54a6498161dbadf683991-20191211 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1690761400; Wed, 11 Dec 2019 18:03:33 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 11 Dec 2019 18:04:32 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 12 Dec 2019 10:02:24 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 12 Dec 2019 10:03:20 +0800 Message-ID: <1576116202.16444.4.camel@mtksdaap41> Subject: Re: [PATCH v2 04/14] mailbox: mediatek: cmdq: clear task in channel before shutdown From: CK Hu To: Dennis-YC Hsieh Date: Thu, 12 Dec 2019 10:03:22 +0800 In-Reply-To: <1576115494.17653.21.camel@mtkswgap22> References: <1574819937-6246-1-git-send-email-dennis-yc.hsieh@mediatek.com> <1574819937-6246-6-git-send-email-dennis-yc.hsieh@mediatek.com> <1575946181.16676.4.camel@mtksdaap41> <1576113221.17653.6.camel@mtkswgap22> <1576114297.11762.1.camel@mtksdaap41> <1576115494.17653.21.camel@mtkswgap22> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: A8FE64F7829C208CB8FCB2A8C581833FEC7AEC50ED8D9CA3A499B8304934AA792000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_180339_396445_AB866B92 X-CRM114-Status: GOOD ( 16.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, Houlong Wei , Rob Herring , linux-mediatek@lists.infradead.org, Bibby Hsieh , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Dennis: On Thu, 2019-12-12 at 09:51 +0800, Dennis-YC Hsieh wrote: > Hi CK, > > On Thu, 2019-12-12 at 09:31 +0800, CK Hu wrote: > > Hi, Dennis: > > > > On Thu, 2019-12-12 at 09:13 +0800, Dennis-YC Hsieh wrote: > > > Hi CK, > > > > > > On Tue, 2019-12-10 at 10:49 +0800, CK Hu wrote: > > > > Hi, Dennis: > > > > > > > > On Wed, 2019-11-27 at 09:58 +0800, Dennis YC Hsieh wrote: > > > > > Do success callback in channel when shutdown. For those task not finish, > > > > > callback with error code thus client has chance to cleanup or reset. > > > > > > > > > > Signed-off-by: Dennis YC Hsieh > > > > > --- > > > > > drivers/mailbox/mtk-cmdq-mailbox.c | 26 ++++++++++++++++++++++++++ > > > > > 1 file changed, 26 insertions(+) > > > > > > > > > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > > > > > index fd519b6f518b..c12a768d1175 100644 > > > > > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > > > > > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > > > > > @@ -450,6 +450,32 @@ static int cmdq_mbox_startup(struct mbox_chan *chan) > > > > > > > > > > static void cmdq_mbox_shutdown(struct mbox_chan *chan) > > > > > { > > > > > + struct cmdq_thread *thread = (struct cmdq_thread *)chan->con_priv; > > > > > + struct cmdq *cmdq = dev_get_drvdata(chan->mbox->dev); > > > > > + struct cmdq_task *task, *tmp; > > > > > + unsigned long flags; > > > > > + > > > > > + spin_lock_irqsave(&thread->chan->lock, flags); > > > > > + if (list_empty(&thread->task_busy_list)) > > > > > + goto done; > > > > > + > > > > > + WARN_ON(cmdq_thread_suspend(cmdq, thread) < 0); > > > > > + > > > > > + /* make sure executed tasks have success callback */ > > > > > + cmdq_thread_irq_handler(cmdq, thread); > > > > > + if (list_empty(&thread->task_busy_list)) > > > > > + goto done; > > > > > + > > > > > + list_for_each_entry_safe(task, tmp, &thread->task_busy_list, > > > > > + list_entry) { > > > > > + cmdq_task_exec_done(task, -ECONNABORTED); > > > > > + kfree(task); > > > > > + } > > > > > + > > > > > + cmdq_thread_disable(cmdq, thread); > > > > > + clk_disable(cmdq->clock); > > > > > +done: > > > > > > > > cmdq_thread_resume(thread); > > > > > > > > Regards, > > > > CK > > > > > > > > > > Call resume here will cause violation. The thread->task_busy_list empty > > > means no task work in gce and thread state should already disable > > > without clock, which is what we want since client try to shut down this > > > mbox channel. So I think we don't need resume here. > > > > > > > OK. When client free channel, thread is suspended. Then client request > > channel, where do you resume thread? > > > > when client send new pkt to new channel, cmdq_mbox_send_data() will > enable thread. in cmdq_mbox_send_data(), it would run below command: WARN_ON(clk_enable(cmdq->clock) < 0); WARN_ON(cmdq_thread_reset(cmdq, thread) < 0); writel(task->pa_base, thread->base + CMDQ_THR_CURR_ADDR); writel(task->pa_base + pkt->cmd_buf_size, thread->base + CMDQ_THR_END_ADDR); writel(thread->priority, thread->base + CMDQ_THR_PRIORITY); writel(CMDQ_THR_IRQ_EN, thread->base + CMDQ_THR_IRQ_ENABLE); writel(CMDQ_THR_ENABLED, thread->base + CMDQ_THR_ENABLE_TASK); Do you mean CMDQ_THR_ENABLE_TASK is set to CMDQ_THR_ENABLED, then CMDQ_THR_SUSPEND_TASK would be automatically set to CMDQ_THR_RESUME? If this hardware work in so special behavior, please add comment for this. Regards, CK > > > Regards, > Dennis > > > Regards, > > CK > > > > > > > > Regards, > > > Dennis > > > > > > > > + spin_unlock_irqrestore(&thread->chan->lock, flags); > > > > > } > > > > > > > > > > static const struct mbox_chan_ops cmdq_mbox_chan_ops = { > > > > > > > > > > > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel