* [PATCH] iio: adc: stm32-adc: don't print an error on probe deferral
@ 2020-01-13 13:18 Fabrice Gasnier
2020-01-18 14:22 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Gasnier @ 2020-01-13 13:18 UTC (permalink / raw)
To: jic23
Cc: etienne.carriere, lars, olivier.moysan, alexandre.torgue,
linux-iio, pmeerw, linux-kernel, mcoquelin.stm32, knaack.h,
fabrice.gasnier, linux-stm32, linux-arm-kernel
From: Etienne Carriere <etienne.carriere@st.com>
Do not print an error trace when deferring probe for some resource.
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/iio/adc/stm32-adc-core.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
index 97655d7..2df88d2 100644
--- a/drivers/iio/adc/stm32-adc-core.c
+++ b/drivers/iio/adc/stm32-adc-core.c
@@ -688,7 +688,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
priv->vref = devm_regulator_get(&pdev->dev, "vref");
if (IS_ERR(priv->vref)) {
ret = PTR_ERR(priv->vref);
- dev_err(&pdev->dev, "vref get failed, %d\n", ret);
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "vref get failed, %d\n", ret);
return ret;
}
@@ -696,7 +697,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
if (IS_ERR(priv->aclk)) {
ret = PTR_ERR(priv->aclk);
if (ret != -ENOENT) {
- dev_err(&pdev->dev, "Can't get 'adc' clock\n");
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Can't get 'adc' clock\n");
return ret;
}
priv->aclk = NULL;
@@ -706,7 +708,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
if (IS_ERR(priv->bclk)) {
ret = PTR_ERR(priv->bclk);
if (ret != -ENOENT) {
- dev_err(&pdev->dev, "Can't get 'bus' clock\n");
+ if (ret != -EPROBE_DEFER)
+ dev_err(&pdev->dev, "Can't get 'bus' clock\n");
return ret;
}
priv->bclk = NULL;
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: stm32-adc: don't print an error on probe deferral
2020-01-13 13:18 [PATCH] iio: adc: stm32-adc: don't print an error on probe deferral Fabrice Gasnier
@ 2020-01-18 14:22 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2020-01-18 14:22 UTC (permalink / raw)
To: Fabrice Gasnier
Cc: etienne.carriere, lars, olivier.moysan, alexandre.torgue,
linux-iio, pmeerw, linux-kernel, mcoquelin.stm32, knaack.h,
linux-stm32, linux-arm-kernel
On Mon, 13 Jan 2020 14:18:59 +0100
Fabrice Gasnier <fabrice.gasnier@st.com> wrote:
> From: Etienne Carriere <etienne.carriere@st.com>
>
> Do not print an error trace when deferring probe for some resource.
>
> Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/adc/stm32-adc-core.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> index 97655d7..2df88d2 100644
> --- a/drivers/iio/adc/stm32-adc-core.c
> +++ b/drivers/iio/adc/stm32-adc-core.c
> @@ -688,7 +688,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
> priv->vref = devm_regulator_get(&pdev->dev, "vref");
> if (IS_ERR(priv->vref)) {
> ret = PTR_ERR(priv->vref);
> - dev_err(&pdev->dev, "vref get failed, %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "vref get failed, %d\n", ret);
> return ret;
> }
>
> @@ -696,7 +697,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
> if (IS_ERR(priv->aclk)) {
> ret = PTR_ERR(priv->aclk);
> if (ret != -ENOENT) {
> - dev_err(&pdev->dev, "Can't get 'adc' clock\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Can't get 'adc' clock\n");
> return ret;
> }
> priv->aclk = NULL;
> @@ -706,7 +708,8 @@ static int stm32_adc_probe(struct platform_device *pdev)
> if (IS_ERR(priv->bclk)) {
> ret = PTR_ERR(priv->bclk);
> if (ret != -ENOENT) {
> - dev_err(&pdev->dev, "Can't get 'bus' clock\n");
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "Can't get 'bus' clock\n");
> return ret;
> }
> priv->bclk = NULL;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-18 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 13:18 [PATCH] iio: adc: stm32-adc: don't print an error on probe deferral Fabrice Gasnier
2020-01-18 14:22 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).