[PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc driver

[PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc driver

[Peng Fan]

From: Peng Fan <peng.fan@nxp.com>


V2:
 Include Leonard's patch to fix build break after enable compile test
 Add Leonard's R-b tag

Rename soc-imx8.c to soc-imx8m.c which is for i.MX8M family
Add SOC_IMX8M for build gate soc-imx8m.c
Increase build coverage for i.MX SoC driver

Leonard Crestez (1):
  soc: imx: gpcv2: include linux/sizes.h

Peng Fan (4):
  soc: imx: Kconfig: add SOC_IMX8M entry
  arm64: defconfig: Enable CONFIG_SOC_IMX8M by default
  soc: Makefile: increase build coverage for i.MX
  soc: imx: Use CONFIG_SOC_IMX8M as build gate

 arch/arm64/configs/defconfig                | 1 +
 drivers/soc/Makefile                        | 2 +-
 drivers/soc/imx/Kconfig                     | 8 ++++++++
 drivers/soc/imx/Makefile                    | 2 +-
 drivers/soc/imx/gpcv2.c                     | 1 +
 drivers/soc/imx/{soc-imx8.c => soc-imx8m.c} | 0
 6 files changed, 12 insertions(+), 2 deletions(-)
 rename drivers/soc/imx/{soc-imx8.c => soc-imx8m.c} (100%)

-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V2 1/5] soc: imx: gpcv2: include linux/sizes.h

[Peng Fan]

From: Leonard Crestez <leonard.crestez@nxp.com>

This header is included indirectly on arm/arm64 but not on x86 so
CONFIG_COMPILE_TEST breaks. Fix by including <linux/sizes.h> directly.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
 drivers/soc/imx/gpcv2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
index b0dffb06c05d..6cf8a7a412bd 100644
--- a/drivers/soc/imx/gpcv2.c
+++ b/drivers/soc/imx/gpcv2.c
@@ -14,6 +14,7 @@
 #include <linux/pm_domain.h>
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
+#include <linux/sizes.h>
 #include <dt-bindings/power/imx7-power.h>
 #include <dt-bindings/power/imx8mq-power.h>
 
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V2 2/5] soc: imx: Kconfig: add SOC_IMX8M entry

[Peng Fan]

From: Peng Fan <peng.fan@nxp.com>

Add SOC_IMX8M Kconfig entry that could let people to select
and deselect.

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/soc/imx/Kconfig | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/soc/imx/Kconfig b/drivers/soc/imx/Kconfig
index 0281ef9a1800..790b46d90f0f 100644
--- a/drivers/soc/imx/Kconfig
+++ b/drivers/soc/imx/Kconfig
@@ -17,4 +17,12 @@ config IMX_SCU_SOC
 	  Controller Unit SoC info module, it will provide the SoC info
 	  like SoC family, ID and revision etc.
 
+config SOC_IMX8M
+	bool "i.MX8M SoC family support"
+	depends on ARCH_MXC || COMPILE_TEST
+	help
+	  If you say yes here you get support for the NXP i.MX8M family
+	  support, it will provide the SoC info like SoC family,
+	  ID and revision etc.
+
 endmenu
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V2 3/5] arm64: defconfig: Enable CONFIG_SOC_IMX8M by default

[Peng Fan]

From: Peng Fan <peng.fan@nxp.com>

Enable CONFIG_SOC_IMX8M by default to build i.MX8M SoC drivers

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d0ea0d0d3b16..20087f1aba56 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -729,6 +729,7 @@ CONFIG_RPMSG_QCOM_GLINK_SMEM=m
 CONFIG_RPMSG_QCOM_SMD=y
 CONFIG_RASPBERRYPI_POWER=y
 CONFIG_IMX_SCU_SOC=y
+CONFIG_SOC_IMX8M=y
 CONFIG_QCOM_GENI_SE=y
 CONFIG_QCOM_GLINK_SSR=m
 CONFIG_QCOM_RPMH=y
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V2 4/5] soc: Makefile: increase build coverage for i.MX

[Peng Fan]

From: Peng Fan <peng.fan@nxp.com>

Increase build coverage for i.MX SoC drivers.

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/soc/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile
index 2ec355003524..614986cd1713 100644
--- a/drivers/soc/Makefile
+++ b/drivers/soc/Makefile
@@ -11,7 +11,7 @@ obj-$(CONFIG_ARCH_DOVE)		+= dove/
 obj-$(CONFIG_MACH_DOVE)		+= dove/
 obj-y				+= fsl/
 obj-$(CONFIG_ARCH_GEMINI)	+= gemini/
-obj-$(CONFIG_ARCH_MXC)		+= imx/
+obj-y				+= imx/
 obj-$(CONFIG_ARCH_IXP4XX)	+= ixp4xx/
 obj-$(CONFIG_SOC_XWAY)		+= lantiq/
 obj-y				+= mediatek/
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH V2 5/5] soc: imx: Use CONFIG_SOC_IMX8M as build gate

[Peng Fan]

From: Peng Fan <peng.fan@nxp.com>

The soc-imx8.c driver is actually for i.MX8M family, so rename it
to soc-imx8m.c.
Use CONFIG_SOC_IMX8M as build gate, not CONFIG_ARCH_MXC, to control
whether build this driver, also make it possible for compile test.

Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/soc/imx/Makefile                    | 2 +-
 drivers/soc/imx/{soc-imx8.c => soc-imx8m.c} | 0
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename drivers/soc/imx/{soc-imx8.c => soc-imx8m.c} (100%)

diff --git a/drivers/soc/imx/Makefile b/drivers/soc/imx/Makefile
index cf9ca42ff739..103e2c93c342 100644
--- a/drivers/soc/imx/Makefile
+++ b/drivers/soc/imx/Makefile
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 obj-$(CONFIG_HAVE_IMX_GPC) += gpc.o
 obj-$(CONFIG_IMX_GPCV2_PM_DOMAINS) += gpcv2.o
-obj-$(CONFIG_ARCH_MXC) += soc-imx8.o
+obj-$(CONFIG_SOC_IMX8M) += soc-imx8m.o
 obj-$(CONFIG_IMX_SCU_SOC) += soc-imx-scu.o
diff --git a/drivers/soc/imx/soc-imx8.c b/drivers/soc/imx/soc-imx8m.c
similarity index 100%
rename from drivers/soc/imx/soc-imx8.c
rename to drivers/soc/imx/soc-imx8m.c
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc driver

[Arnd Bergmann]

On Mon, Jan 27, 2020 at 10:44 AM Peng Fan <peng.fan@nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
>
> V2:
>  Include Leonard's patch to fix build break after enable compile test
>  Add Leonard's R-b tag
>
> Rename soc-imx8.c to soc-imx8m.c which is for i.MX8M family
> Add SOC_IMX8M for build gate soc-imx8m.c
> Increase build coverage for i.MX SoC driver

The changes all look good to me, but I'd just do it all in one combined
patch, as the changes are all logically part of the same thing. You
can leave Leonard's fix as a [PATCH 1/2]  if you want, but the rest
should clearly be a single change.

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc driver

[Peng Fan]

Hi Arnd,

> Subject: Re: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc
> driver
> 
> On Mon, Jan 27, 2020 at 10:44 AM Peng Fan <peng.fan@nxp.com> wrote:
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> >
> > V2:
> >  Include Leonard's patch to fix build break after enable compile test
> > Add Leonard's R-b tag
> >
> > Rename soc-imx8.c to soc-imx8m.c which is for i.MX8M family Add
> > SOC_IMX8M for build gate soc-imx8m.c Increase build coverage for i.MX
> > SoC driver
> 
> The changes all look good to me, but I'd just do it all in one combined patch, as
> the changes are all logically part of the same thing. You can leave Leonard's fix
> as a [PATCH 1/2]  if you want, but the rest should clearly be a single change.

There is a arm64 defconfig change, should it be also included in the single change?

Thanks,
Peng.

> 
>       Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc driver

[Arnd Bergmann]

On Mon, Jan 27, 2020 at 1:33 PM Peng Fan <peng.fan@nxp.com> wrote:
>
> Hi Arnd,
>
> > Subject: Re: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc
> > driver
> >
> > On Mon, Jan 27, 2020 at 10:44 AM Peng Fan <peng.fan@nxp.com> wrote:
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > >
> > > V2:
> > >  Include Leonard's patch to fix build break after enable compile test
> > > Add Leonard's R-b tag
> > >
> > > Rename soc-imx8.c to soc-imx8m.c which is for i.MX8M family Add
> > > SOC_IMX8M for build gate soc-imx8m.c Increase build coverage for i.MX
> > > SoC driver
> >
> > The changes all look good to me, but I'd just do it all in one combined patch, as
> > the changes are all logically part of the same thing. You can leave Leonard's fix
> > as a [PATCH 1/2]  if you want, but the rest should clearly be a single change.
>
> There is a arm64 defconfig change, should it be also included in the single change?

Good point, that one is probably better left separate indeed.

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

RE: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc driver

[Peng Fan]

> Subject: Re: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc
> driver
> 
> On Mon, Jan 27, 2020 at 1:33 PM Peng Fan <peng.fan@nxp.com> wrote:
> >
> > Hi Arnd,
> >
> > > Subject: Re: [PATCH V2 0/5] soc: imx: increase build coverage for
> > > imx8 soc driver
> > >
> > > On Mon, Jan 27, 2020 at 10:44 AM Peng Fan <peng.fan@nxp.com> wrote:
> > > >
> > > > From: Peng Fan <peng.fan@nxp.com>
> > > >
> > > >
> > > > V2:
> > > >  Include Leonard's patch to fix build break after enable compile
> > > > test Add Leonard's R-b tag
> > > >
> > > > Rename soc-imx8.c to soc-imx8m.c which is for i.MX8M family Add
> > > > SOC_IMX8M for build gate soc-imx8m.c Increase build coverage for
> > > > i.MX SoC driver
> > >
> > > The changes all look good to me, but I'd just do it all in one
> > > combined patch, as the changes are all logically part of the same
> > > thing. You can leave Leonard's fix as a [PATCH 1/2]  if you want, but the
> rest should clearly be a single change.
> >
> > There is a arm64 defconfig change, should it be also included in the single
> change?
> 
> Good point, that one is probably better left separate indeed.

Since the defconfig change needs stay alone in a patch,
merge other patches into one might not be good. The patchset
I did is to make sure the soc-imx8m.c could always be built. If
I merge the others into one, without the defconfig patch set CONFIG
option to y, soc-imx8m.c will not be built. This might break git bisect
to check the soc-imx8m.c

So I prefer not to merge the others into one patch. Do you agree?

Thanks,
Peng.

> 
>       Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc driver

[Arnd Bergmann]

On Mon, Jan 27, 2020 at 2:22 PM Peng Fan <peng.fan@nxp.com> wrote:
>
> > Subject: Re: [PATCH V2 0/5] soc: imx: increase build coverage for imx8 soc
> > driver
> >
> > On Mon, Jan 27, 2020 at 1:33 PM Peng Fan <peng.fan@nxp.com> wrote:
> > >
> > > > Subject: Re: [PATCH V2 0/5] soc: imx: increase build coverage for
> > > > imx8 soc driver
> > > >
> > > > On Mon, Jan 27, 2020 at 10:44 AM Peng Fan <peng.fan@nxp.com> wrote:
> > > > >
> > > > > From: Peng Fan <peng.fan@nxp.com>
> > > > >
> > > > >
> > > > > V2:
> > > > >  Include Leonard's patch to fix build break after enable compile
> > > > > test Add Leonard's R-b tag
> > > > >
> > > > > Rename soc-imx8.c to soc-imx8m.c which is for i.MX8M family Add
> > > > > SOC_IMX8M for build gate soc-imx8m.c Increase build coverage for
> > > > > i.MX SoC driver
> > > >
> > > > The changes all look good to me, but I'd just do it all in one
> > > > combined patch, as the changes are all logically part of the same
> > > > thing. You can leave Leonard's fix as a [PATCH 1/2]  if you want, but the
> > rest should clearly be a single change.
> > >
> > > There is a arm64 defconfig change, should it be also included in the single
> > change?
> >
> > Good point, that one is probably better left separate indeed.
>
> Since the defconfig change needs stay alone in a patch,
> merge other patches into one might not be good. The patchset
> I did is to make sure the soc-imx8m.c could always be built. If
> I merge the others into one, without the defconfig patch set CONFIG
> option to y, soc-imx8m.c will not be built. This might break git bisect
> to check the soc-imx8m.c
>
> So I prefer not to merge the others into one patch. Do you agree?

I'm generally not too worried about intermittent defconfig breaks during
bisection, as the defconfig is not use all that much in practice. Splitting
the other changes into separate patches wouldn't help here either
unless you want to spread it out over multiple merge windows.

I'd probably just put it all in one patch (including the defconfig change)
in this case, alternatively you could add a 'default ARCH_MXC && ARM64'
to the Kconfig symbol.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel