linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] ARM: dts: aspeed: Fix SCU IRQ controller node addresses
@ 2020-02-10 19:32 Eddie James
  2020-02-10 19:32 ` [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node Eddie James
  2020-02-10 19:32 ` [PATCH v2 2/2] ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes Eddie James
  0 siblings, 2 replies; 5+ messages in thread
From: Eddie James @ 2020-02-10 19:32 UTC (permalink / raw)
  To: linux-aspeed; +Cc: andrew, Eddie James, joel, linux-arm-kernel

Warnings were introduced due to unit address on nodes that had no reg property.
Add the reg properties for the nodes to fix the warnings.

Eddie James (2):
  ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node
  ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes

 arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
 arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++++--
 2 files changed, 5 insertions(+), 2 deletions(-)

-- 
1.8.3.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node
  2020-02-10 19:32 [PATCH v2 0/2] ARM: dts: aspeed: Fix SCU IRQ controller node addresses Eddie James
@ 2020-02-10 19:32 ` Eddie James
  2020-02-16 23:52   ` Andrew Jeffery
  2020-02-10 19:32 ` [PATCH v2 2/2] ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes Eddie James
  1 sibling, 1 reply; 5+ messages in thread
From: Eddie James @ 2020-02-10 19:32 UTC (permalink / raw)
  To: linux-aspeed; +Cc: andrew, Eddie James, joel, linux-arm-kernel

The node was defined with a unit address but had no reg property,
resulting in a warning. Add a reg property for consistency to fix the
warning.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
 arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
index 569f9d7..9db7bde 100644
--- a/arch/arm/boot/dts/aspeed-g5.dtsi
+++ b/arch/arm/boot/dts/aspeed-g5.dtsi
@@ -225,6 +225,7 @@
 				scu_ic: interrupt-controller@18 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2500-scu-ic";
+					reg = <0x18 0x4>;
 					interrupts = <21>;
 					interrupt-controller;
 				};
-- 
1.8.3.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/2] ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes
  2020-02-10 19:32 [PATCH v2 0/2] ARM: dts: aspeed: Fix SCU IRQ controller node addresses Eddie James
  2020-02-10 19:32 ` [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node Eddie James
@ 2020-02-10 19:32 ` Eddie James
  2020-02-16 23:54   ` Andrew Jeffery
  1 sibling, 1 reply; 5+ messages in thread
From: Eddie James @ 2020-02-10 19:32 UTC (permalink / raw)
  To: linux-aspeed; +Cc: andrew, Eddie James, joel, linux-arm-kernel

The nodes were defined with a unit address but had no reg property,
resulting in a warning. Add the reg properties for consistency to fix
the warning.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
---
 arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
index 82a3cd1..301fdb4 100644
--- a/arch/arm/boot/dts/aspeed-g6.dtsi
+++ b/arch/arm/boot/dts/aspeed-g6.dtsi
@@ -269,16 +269,18 @@
 					reg = <0x180 0x40>;
 				};
 
-				scu_ic0: interrupt-controller@0 {
+				scu_ic0: interrupt-controller@560 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2600-scu-ic0";
+					reg = <0x560 0x4>;
 					interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
 					interrupt-controller;
 				};
 
-				scu_ic1: interrupt-controller@1 {
+				scu_ic1: interrupt-controller@570 {
 					#interrupt-cells = <1>;
 					compatible = "aspeed,ast2600-scu-ic1";
+					reg = <0x570 0x4>;
 					interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
 					interrupt-controller;
 				};
-- 
1.8.3.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node
  2020-02-10 19:32 ` [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node Eddie James
@ 2020-02-16 23:52   ` Andrew Jeffery
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2020-02-16 23:52 UTC (permalink / raw)
  To: Eddie James, linux-aspeed; +Cc: Joel Stanley, linux-arm-kernel



On Tue, 11 Feb 2020, at 06:02, Eddie James wrote:
> The node was defined with a unit address but had no reg property,
> resulting in a warning. Add a reg property for consistency to fix the
> warning.
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

> ---
>  arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 569f9d7..9db7bde 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -225,6 +225,7 @@
>  				scu_ic: interrupt-controller@18 {
>  					#interrupt-cells = <1>;
>  					compatible = "aspeed,ast2500-scu-ic";
> +					reg = <0x18 0x4>;
>  					interrupts = <21>;
>  					interrupt-controller;
>  				};
> -- 
> 1.8.3.1
> 
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 2/2] ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes
  2020-02-10 19:32 ` [PATCH v2 2/2] ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes Eddie James
@ 2020-02-16 23:54   ` Andrew Jeffery
  0 siblings, 0 replies; 5+ messages in thread
From: Andrew Jeffery @ 2020-02-16 23:54 UTC (permalink / raw)
  To: Eddie James, linux-aspeed; +Cc: Joel Stanley, linux-arm-kernel



On Tue, 11 Feb 2020, at 06:02, Eddie James wrote:
> The nodes were defined with a unit address but had no reg property,
> resulting in a warning. Add the reg properties for consistency to fix
> the warning.
> 
> Signed-off-by: Eddie James <eajames@linux.ibm.com>

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

> ---
>  arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed-g6.dtsi
> index 82a3cd1..301fdb4 100644
> --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> @@ -269,16 +269,18 @@
>  					reg = <0x180 0x40>;
>  				};
>  
> -				scu_ic0: interrupt-controller@0 {
> +				scu_ic0: interrupt-controller@560 {
>  					#interrupt-cells = <1>;
>  					compatible = "aspeed,ast2600-scu-ic0";
> +					reg = <0x560 0x4>;
>  					interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>;
>  					interrupt-controller;
>  				};
>  
> -				scu_ic1: interrupt-controller@1 {
> +				scu_ic1: interrupt-controller@570 {
>  					#interrupt-cells = <1>;
>  					compatible = "aspeed,ast2600-scu-ic1";
> +					reg = <0x570 0x4>;
>  					interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
>  					interrupt-controller;
>  				};
> -- 
> 1.8.3.1
> 
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-02-16 23:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 19:32 [PATCH v2 0/2] ARM: dts: aspeed: Fix SCU IRQ controller node addresses Eddie James
2020-02-10 19:32 ` [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node Eddie James
2020-02-16 23:52   ` Andrew Jeffery
2020-02-10 19:32 ` [PATCH v2 2/2] ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes Eddie James
2020-02-16 23:54   ` Andrew Jeffery

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).