linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Macpaul Lin <macpaul.lin@mediatek.com>
To: "Matthias Brugger" <matthias.bgg@gmail.com>,
	"Wendell Lin (林琦耀)" <Wendell.Lin@mediatek.com>,
	"Weiyi Lu" <Weiyi.Lu@mediatek.com>,
	"Mars Cheng" <mars.cheng@mediatek.com>,
	"Sean Wang" <Sean.Wang@mediatek.com>,
	"Owen Chen" <owen.chen@mediatek.com>,
	";Ryder Lee" <Ryder.Lee@mediatek.com>,
	"Morven-CF Yeh" <Morven-CF.Yeh@mediatek.com>,
	"Kevin-CW Chen" <Kevin-CW.Chen@mediatek.com>,
	"Albert-ZL Huang" <Albert-ZL.Huang@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Loda Chou <loda.chou@mediatek.com>,
	Fabien Parent <fparent@baylibre.com>,
	Mars Cheng <mars.cheng@mediatek.com>,
	Will Deacon <will@kernel.org>,
	linux-clk@vger.kernel.org, Ryder Lee <Ryder.Lee@mediatek.com>,
	Weiyi Lu <weiyi.lu@mediatek.com>,
	Evan Green <evgreen@chromium.org>, Yong Wu <yong.wu@mediatek.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	mtk01761 <wendell.lin@mediatek.com>,
	Owen Chen <owen.chen@mediatek.com>,
	devicetree@vger.kernel.org, Joerg Roedel <jroedel@suse.de>,
	Marc Zyngier <marc.zyngier@arm.com>,
	Sean Wang <Sean.Wang@mediatek.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	CC Hwang <cc.hwang@mediatek.com>, Stephen Boyd <sboyd@kernel.org>,
	linux-kernel@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v7 5/7] soc: mediatek: add MT6765 scpsys and subdomain support
Date: Thu, 13 Feb 2020 10:55:27 +0800	[thread overview]
Message-ID: <1581562527.19053.18.camel@mtkswgap22> (raw)
In-Reply-To: <c704bdab-8489-0b54-59de-401bc4ab24e6@gmail.com>

On Sun, 2020-02-09 at 22:26 +0100, Matthias Brugger wrote:
>
> On 07/02/2020 10:20, Macpaul Lin wrote:
> > From: Mars Cheng <mars.cheng@mediatek.com>
> > 
> > This adds scpsys support for MT6765
> > Add subdomain support for MT6765:
> > isp, mm, connsys, mfg, and cam.
> > 
> > Signed-off-by: Mars Cheng <mars.cheng@mediatek.com>
> > Signed-off-by: Owen Chen <owen.chen@mediatek.com>
> > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> > ---
> >  drivers/soc/mediatek/mtk-scpsys.c | 130 ++++++++++++++++++++++++++++++
> >  1 file changed, 130 insertions(+)
> > 
> > diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> > index f669d3754627..9940c6d13222 100644
> > --- a/drivers/soc/mediatek/mtk-scpsys.c
> > +++ b/drivers/soc/mediatek/mtk-scpsys.c
> > @@ -15,6 +15,7 @@
> >  
> >  #include <dt-bindings/power/mt2701-power.h>
> >  #include <dt-bindings/power/mt2712-power.h>
> > +#include <dt-bindings/power/mt6765-power.h>
> >  #include <dt-bindings/power/mt6797-power.h>
> >  #include <dt-bindings/power/mt7622-power.h>
> >  #include <dt-bindings/power/mt7623a-power.h>
> > @@ -749,6 +750,120 @@ static const struct scp_subdomain scp_subdomain_mt2712[] = {
> >  	{MT2712_POWER_DOMAIN_MFG_SC2, MT2712_POWER_DOMAIN_MFG_SC3},
> >  };
> >  
> > +/*
> > + * MT6765 power domain support
> > + */
> > +#define SPM_PWR_STATUS_MT6765			0x0180
> > +#define SPM_PWR_STATUS_2ND_MT6765		0x0184
> > +
> 
> The offsets are the same as for MT6797. Could we rename the define to something
> generic and move it up and put it just under SPM_PWR_STATUS_2ND? Probably as a
> separate patch.
> 
> Regards,
> Matthias
> 
Loop more related owners in this mail loop.

After check it with our clock driver owners, there are different
generations of clock IPs. Because different smart phone chips require
different cost-function oriented design, even they use the same
generation of clock IPs, might not have the same offsets. Take MT6765
and MT6797 for example, the listed offsets are just coincidence.

Our clock driver owners will work on this to summarize the common offset
parts for each generations, but at this moment, we suggest just separate
the files for mt6797 and mt6765. Commonly used header should be come
with the next chip which clock IP just the same generation of mt6797 or
mt6765.

Thanks
Macpaul Lin


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-02-13  3:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-07  9:20 [PATCH v7 0/7] Add basic SoC support for mt6765 Macpaul Lin
2020-02-07  9:20 ` [PATCH v7 1/7] dt-bindings: clock: mediatek: document clk bindings for Mediatek MT6765 SoC Macpaul Lin
2020-02-18 16:47   ` Matthias Brugger
2020-02-18 20:39     ` Rob Herring
2020-02-07  9:20 ` [PATCH v7 2/7] dt-bindings: mediatek: Add smi dts binding " Macpaul Lin
2020-02-07  9:20 ` [PATCH v7 3/7] clk: mediatek: add mt6765 clock IDs Macpaul Lin
2020-02-07  9:20 ` [PATCH v7 4/7] clk: mediatek: Add MT6765 clock support Macpaul Lin
2020-02-07  9:20 ` [PATCH v7 5/7] soc: mediatek: add MT6765 scpsys and subdomain support Macpaul Lin
2020-02-09 21:26   ` Matthias Brugger
2020-02-13  2:55     ` Macpaul Lin [this message]
2020-02-17 10:36       ` Matthias Brugger
2020-02-07  9:20 ` [PATCH v7 6/7] arm64: dts: mediatek: add mt6765 support Macpaul Lin
2020-02-07  9:20 ` [PATCH v7 7/7] arm64: defconfig: add CONFIG_COMMON_CLK_MT6765_XXX clocks Macpaul Lin
2020-02-12 23:44 ` [PATCH v7 0/7] Add basic SoC support for mt6765 Stephen Boyd
2020-02-15  1:47   ` Matthias Brugger
2020-02-18  4:12     ` Macpaul Lin
2020-02-18 16:45       ` Matthias Brugger
2020-02-19 18:41         ` Stephen Boyd
2020-02-21 10:23           ` Macpaul Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1581562527.19053.18.camel@mtkswgap22 \
    --to=macpaul.lin@mediatek.com \
    --cc=Albert-ZL.Huang@mediatek.com \
    --cc=Kevin-CW.Chen@mediatek.com \
    --cc=Morven-CF.Yeh@mediatek.com \
    --cc=Ryder.Lee@mediatek.com \
    --cc=Sean.Wang@mediatek.com \
    --cc=Weiyi.Lu@mediatek.com \
    --cc=Wendell.Lin@mediatek.com \
    --cc=catalin.marinas@arm.com \
    --cc=cc.hwang@mediatek.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=evgreen@chromium.org \
    --cc=fparent@baylibre.com \
    --cc=jroedel@suse.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=loda.chou@mediatek.com \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mars.cheng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=owen.chen@mediatek.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=will@kernel.org \
    --cc=wsd_upstream@mediatek.com \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).