From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A63B1C2BB1D for ; Fri, 13 Mar 2020 07:22:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76857206EB for ; Fri, 13 Mar 2020 07:22:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ulp5XEPd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="EHUwNPs6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76857206EB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zu/jDMC32Tp2FaDAFs3UhUmRpjgNBvFcQKTMZAfK0bs=; b=Ulp5XEPd6XtzRF aDzXEKHhrRgwNJTk1DA2Ays1sv4BDrDSYf2GCv1iVkuZtSJpdmThnym+D4SYnNITlFZlXr75W/vvG gvrx+CezkL+gYzid/Hxv/VdVVZgZt1M3YTsFNQ6ZaiGP5LlgSJOPTSPwf1SoLcYy9F/nHLscU5YGl +qfjsfiGS23m/rp2rTRgW8czmVD4mVdJsW+oK40Z4WC/cVuVG7TuxbGXabRwwhtEP0MVog/3AHSED JkE/JgM/SHJUlUdc889L6FSizM43S73yY/ZlSG4fl/I1L0emJo5fdZTNyx2F7kBpvUNQyWm5iczsM 7k7qqBdUvQm0FUHJ3bBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCeeb-0005fw-O6; Fri, 13 Mar 2020 07:22:45 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jCeeV-0005do-AS; Fri, 13 Mar 2020 07:22:42 +0000 X-UUID: 3b52fd7093274d59a7217650d0395e55-20200312 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=UrFkW0Xk0vieCO6yz8EJUyDn2CBhwRj783viwlPaGso=; b=EHUwNPs67uKuhv9yHNSsFEdiG2RXg4P8rYmQdSF1WotlNVOBsaBvr28QrgKyvywn5Kyy6nDYEVOXeq+huu7Pm6TGNdroiT4gm+XSZKQffj8JlZQ51Iu3N3Rp9JHhWCnLVRdOG2iHjan4YzMJve7/fvziKxH9TN42f58ow/25wSQ=; X-UUID: 3b52fd7093274d59a7217650d0395e55-20200312 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 2125962753; Thu, 12 Mar 2020 23:22:37 -0800 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Mar 2020 00:23:10 -0700 Received: from mtkcas09.mediatek.inc (172.21.101.178) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 13 Mar 2020 15:21:36 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 13 Mar 2020 15:21:46 +0800 Message-ID: <1584084154.7753.3.camel@mtksdaap41> Subject: Re: [v5, PATCH 4/5] cpufreq: mediatek: add opp notification for SVS support From: andrew-sh.cheng To: Viresh Kumar Date: Fri, 13 Mar 2020 15:22:34 +0800 In-Reply-To: <20200311060616.62nh7sfwtjwvrjfr@vireshk-i7> References: <1574769046-28449-1-git-send-email-andrew-sh.cheng@mediatek.com> <1574769046-28449-5-git-send-email-andrew-sh.cheng@mediatek.com> <20191127083619.etocnhpyyut3hzwq@vireshk-i7> <1575874588.13494.4.camel@mtksdaap41> <20191210064319.f4ksrxozp3gv4xry@vireshk-i7> <1583827865.4840.1.camel@mtksdaap41> <20200311060616.62nh7sfwtjwvrjfr@vireshk-i7> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200313_002241_491830_0866A32C X-CRM114-Status: GOOD ( 21.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nishanth Menon , "devicetree@vger.kernel.org" , srv_heupstream , "linux-pm@vger.kernel.org" , Stephen Boyd , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Chanwoo Choi , Kyungmin Park , Rob Herring , "linux-mediatek@lists.infradead.org" , MyungJoo Ham , Matthias Brugger , Fan Chen =?UTF-8?Q?=28=E9=99=B3=E5=87=A1=29?= , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2020-03-11 at 11:36 +0530, Viresh Kumar wrote: > On 10-03-20, 16:11, andrew-sh.cheng wrote: > > On Tue, 2019-12-10 at 14:43 +0800, Viresh Kumar wrote: > > > On 09-12-19, 14:56, andrew-sh.cheng wrote: > > > > On Wed, 2019-11-27 at 14:06 +0530, Viresh Kumar wrote: > > > > > On 26-11-19, 19:50, Andrew-sh.Cheng wrote: > > > > > > + if (!IS_ERR(opp_item)) > > > > > > + dev_pm_opp_put(opp_item); > > > > > > + else > > > > > > + freq = 0; > > > > > > + > > > > > > > > > > What is the purpose of the above code ? > > > > When dev_pm_opp_find_freq_ceil() doesn't find matching opp item, freq > > > > value won't be set. > > > > Set it as 0 for below checking > > > > > > > > > > > + /* case of current opp is disabled */ > > > > > > + if (freq == 0 || freq != info->opp_freq) { > > > > > > + // find an enable opp item > > > > > > + freq = 1; > > > > > > + opp_item = dev_pm_opp_find_freq_ceil(info->cpu_dev, > > > > > > + &freq); > > > > > > + if (!IS_ERR(opp_item)) { > > > > > > + dev_pm_opp_put(opp_item); > > > > > > + policy = cpufreq_cpu_get(info->opp_cpu); > > > > > > + if (policy) { > > > > > > + cpufreq_driver_target(policy, > > > > > > + freq / 1000, > > > > > > + CPUFREQ_RELATION_L); > > > > > > > > > > Why don't you simply call this instead of all the code in the else > > > > > block ? > > > > These else code is used to check "current opp item is disabled or not". > > > > If not, do nothing. > > > > If current opp item is disabled, need to find an not-disabled opp item, > > > > and set frequency to it. > > > > > > Right. So this notifier helper of yours receive the opp which is getting > > > disabled, why don't you compare its frequency directly to see if the current OPP > > > is getting disabled ? > > Sorry to overlook your question. > > This is because when the opp is disabled, > > we cannot use dev_pm_opp_get_freq() to get frequency of that opp. > > There is a check: > > if (IS_ERR_OR_NULL(opp) || !opp->available) { > > I think we can remove the available check here, as we are jut trying > to find frequency of an OPP we already have. Send a patch for that > please. > Hi Viresh, I have something want to consult you. For your previous comment, you suggest use read-write lock to replace mutex lock. Will it be more efficiently even when all are write lock? (all lock region are "setting VProc voltage") > > pr_err("%s: Invalid parameters\n", __func__); > > return 0; > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel