From: Stephen Boyd <sboyd@kernel.org>
To: Chunyan Zhang <zhang.lyra@gmail.com>,
Sandeep Patil <sspatil@android.com>
Cc: Android Kernel Team <kernel-team@android.com>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Michael Turquette <mturquette@baylibre.com>,
LKML <linux-kernel@vger.kernel.org>,
Chunyan Zhang <chunyan.zhang@unisoc.com>,
Orson Zhai <orson.zhai@unisoc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will@kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] [RFC] clk: sprd: fix compile-testing
Date: Fri, 10 Apr 2020 19:27:26 -0700 [thread overview]
Message-ID: <158657204622.199533.16589832598336244320@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <CAAfSe-s=dZe=6y7UH8CBcddL1BKoLOAvi24RekgdmVv0StxTTA@mail.gmail.com>
Quoting Chunyan Zhang (2020-04-09 20:45:16)
> We see this broken because I shouldn't leave clk Makefile a tristate
> compile [1] after changing ARCH_SPRD to be tristate.
>
> If we will make ARCH_SPRD tristate-able in the future and you all
> aggree that, I would like to do it now, and pay more attention to
> Makefiles and dependencies.
>
> I can also make a change like below:
>
> diff --git a/drivers/clk/sprd/Kconfig b/drivers/clk/sprd/Kconfig
> index e18c80fbe804..9f7d9d8899a5 100644
> --- a/drivers/clk/sprd/Kconfig
> +++ b/drivers/clk/sprd/Kconfig
> @@ -2,6 +2,7 @@
> config SPRD_COMMON_CLK
> tristate "Clock support for Spreadtrum SoCs"
> depends on ARCH_SPRD || COMPILE_TEST
> + depends on m || ARCH_SPRD != m
> default ARCH_SPRD
> select REGMAP_MMIO
>
> Arnd, Stephen, Sandeep, what do you think? Does that make sense?
Sorry, doesn't make any sense to me. The ARCH_FOO configs for various
platforms are intended to be used to limit the configuration space of
various other Kconfig symbols for the code that only matters to those
platforms. The usage of depends and default is correct here already. The
ARCH_FOO configs should always be bool. Any code bloat problems seen by
config symbols enabling because they're 'default ARCH_FOO' can be
resolved by explicitly disabling those configs.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-11 2:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 16:00 [PATCH] [RFC] clk: sprd: fix compile-testing Arnd Bergmann
2020-04-09 6:09 ` Chunyan Zhang
[not found] ` <CA+nhYX0H-czfJ6Kg+FK7X2=hHQK185UOLGoPdEP3nqWQWcA+bg@mail.gmail.com>
2020-04-10 3:45 ` Chunyan Zhang
2020-04-11 2:27 ` Stephen Boyd [this message]
2020-04-13 3:47 ` Chunyan Zhang
2020-04-09 8:30 ` Stephen Boyd
2020-06-03 9:17 ` Chunyan Zhang
2020-06-03 10:58 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158657204622.199533.16589832598336244320@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=chunyan.zhang@unisoc.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orson.zhai@unisoc.com \
--cc=sspatil@android.com \
--cc=will@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).