From: Dongchun Zhu <dongchun.zhu@mediatek.com>
To: Tomasz Figa <tfiga@chromium.org>
Cc: mark.rutland@arm.com, drinkcat@chromium.org,
andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
shengnan.wang@mediatek.com, louis.kuo@mediatek.com,
bgolaszewski@baylibre.com, sj.huang@mediatek.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
dongchun.zhu@mediatek.com, sakari.ailus@linux.intel.com,
matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH V10 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver
Date: Mon, 29 Jun 2020 14:30:18 +0800 [thread overview]
Message-ID: <1593412218.17166.3.camel@mhfsdcap03> (raw)
In-Reply-To: <20200622152350.GB260716@chromium.org>
Hi Tomasz,
Thanks for the review.
On Mon, 2020-06-22 at 15:23 +0000, Tomasz Figa wrote:
> On Sat, Jun 20, 2020 at 03:48:04PM +0800, Dongchun Zhu wrote:
> > Hi Tomasz,
> >
> > Thanks for the review.
> >
> > On Thu, 2020-06-18 at 19:10 +0000, Tomasz Figa wrote:
> > > Hi Dongchun,
> > >
> > > On Mon, Jun 15, 2020 at 08:29:37PM +0800, Dongchun Zhu wrote:
> > > > Add a V4L2 sub-device driver for OV02A10 image sensor.
> > > >
> > > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> > > > ---
> > > > MAINTAINERS | 1 +
> > > > drivers/media/i2c/Kconfig | 13 +
> > > > drivers/media/i2c/Makefile | 1 +
> > > > drivers/media/i2c/ov02a10.c | 1042 +++++++++++++++++++++++++++++++++++++++++++
> > > > 4 files changed, 1057 insertions(+)
> > > > create mode 100644 drivers/media/i2c/ov02a10.c
> > > >
> > >
> > > Thank you for the patch. Please see my comments inline.
> > >
> > > [snip]
> > > > +static int ov02a10_set_fmt(struct v4l2_subdev *sd,
> > > > + struct v4l2_subdev_pad_config *cfg,
> > > > + struct v4l2_subdev_format *fmt)
> > > > +{
> > > > + struct ov02a10 *ov02a10 = to_ov02a10(sd);
> > > > + struct v4l2_mbus_framefmt *mbus_fmt = &fmt->format;
> > > > +
> > > > + mutex_lock(&ov02a10->mutex);
> > > > +
> > > > + if (ov02a10->streaming) {
> > > > + mutex_unlock(&ov02a10->mutex);
> > > > + return -EBUSY;
> > > > + }
> > > > +
> > > > + /* Only one sensor mode supported */
> > > > + mbus_fmt->code = ov02a10->fmt.code;
> > > > + ov02a10_fill_fmt(ov02a10->cur_mode, mbus_fmt);
> > > > + ov02a10->fmt = fmt->format;
> > > > +
> > > > + if (fmt->which == V4L2_SUBDEV_FORMAT_TRY)
> > > > + *v4l2_subdev_get_try_format(sd, cfg, fmt->pad) = fmt->format;
> > >
> > > If fmt->which is V4L2_SUBDEV_FORMAT_TRY, the internal driver state must not
> > > be affected. It also should not depend on whether the sensor is streaming
> > > or not. Basically it should be considered a special "candidate" format,
> > > which isn't programmed to the hardware, but just stored aside.
> > >
> >
> > Hmm. Maybe we shall use FORMAT_TRY like this:
> > struct v4l2_mbus_framefmt *frame_fmt;
> > ...
> > if (fmt->which == V4L2_SUBDEV_FORMAT_TRY)
> > frame_fmt = v4l2_subdev_get_try_format(sd, cfg, 0);
> > else
> > frame_fmt = &ov02a10->fmt;
> >
> > *frame_fmt = *mbus_fmt;
> >
> > (Remove 'ov02a10->fmt = fmt->format;' above)
> >
>
> Yes, I guess that should work. Also the ov02a10->streaming condition
> shouldn't be checked if fmt->which is V4L2_SUBDEV_FORMAT_TRY).
>
Maybe we shall use more strict condition to check streaming state:
'if (ov02a10->streaming)' --> 'if (ov02a10->streaming && fmt->which ==
V4L2_SUBDEV_FORMAT_ACTIVE)'
> Best regards,
> Tomasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-29 6:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 12:29 [PATCH V10 0/2] media: i2c: Add support for OV02A10 sensor Dongchun Zhu
2020-06-15 12:29 ` [PATCH V10 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Dongchun Zhu
2020-06-18 19:13 ` Tomasz Figa
2020-06-20 7:57 ` Dongchun Zhu
2020-06-15 12:29 ` [PATCH V10 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver Dongchun Zhu
2020-06-18 19:10 ` Tomasz Figa
2020-06-20 7:48 ` Dongchun Zhu
[not found] ` <20200622152350.GB260716@chromium.org>
2020-06-29 6:30 ` Dongchun Zhu [this message]
2020-06-29 10:22 ` Tomasz Figa
2020-06-29 7:53 ` Dongchun Zhu
2020-06-29 10:27 ` Tomasz Figa
2020-06-30 1:13 ` Dongchun Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593412218.17166.3.camel@mhfsdcap03 \
--to=dongchun.zhu@mediatek.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).