From: Neal Liu <neal.liu@mediatek.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
lkml <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Neal Liu <neal.liu@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6779 driver
Date: Tue, 7 Jul 2020 11:38:14 +0800 [thread overview]
Message-ID: <1594093094.20820.8.camel@mtkswgap22> (raw)
In-Reply-To: <eb2eaab3-1ecc-d2c8-fc40-5bbe51ee31c4@infradead.org>
On Mon, 2020-07-06 at 20:32 -0700, Randy Dunlap wrote:
> On 7/6/20 8:30 PM, Neal Liu wrote:
> > Hi Randy,
> >
> > Thanks for your review.
> >
> > On Mon, 2020-07-06 at 09:13 -0700, Randy Dunlap wrote:
> >> On 7/6/20 2:28 AM, Neal Liu wrote:
> >>> diff --git a/drivers/soc/mediatek/devapc/Kconfig b/drivers/soc/mediatek/devapc/Kconfig
> >>> new file mode 100644
> >>> index 0000000..b0f7d0e
> >>> --- /dev/null
> >>> +++ b/drivers/soc/mediatek/devapc/Kconfig
> >>> @@ -0,0 +1,17 @@
> >>> +config MTK_DEVAPC
> >>> + tristate "Mediatek Device APC Support"
> >>> + help
> >>> + Device APC is a HW IP controlling internal device security.
> >>
> >> preferably: s/HW/hardware/
> >>
> >>> + MediaTek bus frabric provides TrustZone security support and data
> >>
> >> fabric
> >>
> >>> + protection to prevent slaves from being accessed by unexpected
> >>> + bus masters.
> >>> + Device APC prevents malicious access to internal devices.
> >>> +
> >>> +config DEVAPC_MT6779
> >>> + tristate "Mediatek MT6779 Device APC driver"
> >>> + select MTK_DEVAPC
> >>> + help
> >>> + Say yes here to enable support Mediatek MT6779 Device APC driver.
> >>
> >> support for Mediatek
> >>
> >>> + This driver mainly used to handle the violation with 1 DEVAPC AO/PDs.
> >>
> >> This driver is mainly used ^^^^^^^^^^^^^^^^
> >>
> >> What is that meaningless string of chars? ^^^^^^^
> >
> > I did not see any meaningless string of chars from my original patch.
> > Is there something wrong?
>
> To someone who is reading the Kconfig help text but is unfamiliar with this device,
> I would say that "1 DEVAPC AO/PDs" is not helpful at all.
Got it, I'll try to make it more readable.
>
> > [1] https://urldefense.com/v3/__https://lkml.org/lkml/2020/7/6/168__;!!CTRNKA9wMg0ARbw!0pAmVqUrtDEDPT-QkQENXso-_umOz2nbe-DDIlMb1sEsD57BaKtDZF47QFTfMSP-$
> >
> >>
> >>> + The violation information are logged for further analysis or
> >>
> >> is
> >>
> >>> + countermeasures.
> >>
> >> thanks.
> >
>
>
> thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-07-07 3:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 9:28 Add MediaTek MT6779 devapc driver Neal Liu
2020-07-06 9:28 ` [PATCH 1/2] dt-bindings: devapc: add bindings for devapc-mt6779 Neal Liu
2020-07-06 9:28 ` [PATCH 2/2] soc: mediatek: devapc: add devapc-mt6779 driver Neal Liu
2020-07-06 11:27 ` Matthias Brugger
2020-07-07 7:32 ` Neal Liu
2020-07-10 12:13 ` Matthias Brugger
2020-07-13 6:11 ` Neal Liu
2020-07-06 16:13 ` Randy Dunlap
2020-07-07 3:30 ` Neal Liu
2020-07-07 3:32 ` Randy Dunlap
2020-07-07 3:38 ` Neal Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594093094.20820.8.camel@mtkswgap22 \
--to=neal.liu@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).