From: Bibby Hsieh <bibby.hsieh@mediatek.com>
To: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
wsd_upstream@mediatek.com, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org,
Houlong Wei <houlong.wei@mediatek.com>,
HS Liao <hs.liao@mediatek.com>, CK Hu <ck.hu@mediatek.com>,
linux-mediatek@lists.infradead.org,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 9/9] drm/mediatek: reduce clear event
Date: Thu, 9 Jul 2020 10:39:38 +0800 [thread overview]
Message-ID: <1594262378.21095.3.camel@mtksdaap41> (raw)
In-Reply-To: <1594136714-11650-10-git-send-email-dennis-yc.hsieh@mediatek.com>
Hi, Dennis,
Thanks for this patch.
It's better to send another tree for this patch.
Because this tree is only for soc/mediatek.
Please do not forget to add the dependency information.
Bibby
On Tue, 2020-07-07 at 23:45 +0800, Dennis YC Hsieh wrote:
> No need to clear event again since event always clear before wait.
> This fix depend on patch:
> "soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api"
>
> Fixes: 2f965be7f9008 ("drm/mediatek: apply CMDQ control flow")
> Signed-off-by: Dennis YC Hsieh <dennis-yc.hsieh@mediatek.com>
Reviewed-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index c84e7a14d4a8..ba6cf956b239 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -490,7 +490,7 @@ static void mtk_drm_crtc_hw_config(struct mtk_drm_crtc *mtk_crtc)
> mbox_flush(mtk_crtc->cmdq_client->chan, 2000);
> cmdq_handle = cmdq_pkt_create(mtk_crtc->cmdq_client, PAGE_SIZE);
> cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event);
> - cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, true);
> + cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, false);
> mtk_crtc_ddp_config(crtc, cmdq_handle);
> cmdq_pkt_finalize(cmdq_handle);
> cmdq_pkt_flush_async(cmdq_handle, ddp_cmdq_cb, cmdq_handle);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-09 2:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 15:45 [PATCH v3 0/9] support cmdq helper function on mt6779 platform Dennis YC Hsieh
2020-07-07 15:45 ` [PATCH v3 1/9] soc: mediatek: cmdq: add address shift in jump Dennis YC Hsieh
2020-07-08 7:27 ` Bibby Hsieh
2020-09-21 16:15 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 2/9] soc: mediatek: cmdq: add write_s function Dennis YC Hsieh
2020-09-21 16:15 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 3/9] soc: mediatek: cmdq: add write_s_mask function Dennis YC Hsieh
2020-09-21 16:15 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 4/9] soc: mediatek: cmdq: add read_s function Dennis YC Hsieh
2020-09-21 16:16 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 5/9] soc: mediatek: cmdq: add write_s value function Dennis YC Hsieh
2020-09-21 16:16 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 6/9] soc: mediatek: cmdq: add write_s_mask " Dennis YC Hsieh
2020-09-21 16:16 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 7/9] soc: mediatek: cmdq: add jump function Dennis YC Hsieh
2020-09-21 16:18 ` Matthias Brugger
2020-07-07 15:45 ` [PATCH v3 8/9] soc: mediatek: cmdq: add clear option in cmdq_pkt_wfe api Dennis YC Hsieh
2020-07-07 23:04 ` Chun-Kuang Hu
2020-09-21 16:19 ` Matthias Brugger
2020-09-21 16:25 ` Dennis-YC Hsieh
2020-07-07 15:45 ` [PATCH v3 9/9] drm/mediatek: reduce clear event Dennis YC Hsieh
2020-07-07 23:01 ` Chun-Kuang Hu
2020-09-21 16:37 ` Matthias Brugger
2020-07-09 2:39 ` Bibby Hsieh [this message]
2020-09-21 16:36 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594262378.21095.3.camel@mtksdaap41 \
--to=bibby.hsieh@mediatek.com \
--cc=airlied@linux.ie \
--cc=ck.hu@mediatek.com \
--cc=daniel@ffwll.ch \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=houlong.wei@mediatek.com \
--cc=hs.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).