From: CK Hu <ck.hu@mediatek.com>
To: Seiya Wang <seiya.wang@mediatek.com>
Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/3] arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile
Date: Wed, 29 Jul 2020 16:02:55 +0800 [thread overview]
Message-ID: <1596009775.12468.6.camel@mtksdaap41> (raw)
In-Reply-To: <20200729013100.19539-2-seiya.wang@mediatek.com>
Hi, Seiya:
On Wed, 2020-07-29 at 09:30 +0800, Seiya Wang wrote:
> Add basic chip support for Mediatek MT8192
>
> Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> ---
> arch/arm64/boot/dts/mediatek/Makefile | 1 +
> arch/arm64/boot/dts/mediatek/mt8192-evb.dts | 29 ++
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 671 ++++++++++++++++++++++++++++
> 3 files changed, 701 insertions(+)
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-evb.dts
> create mode 100644 arch/arm64/boot/dts/mediatek/mt8192.dtsi
>
[snip]
> +
> + watchdog: watchdog@10007000 {
> + compatible = "mediatek,mt6589-wdt";
According to [1] and [2], compatible string for mt8192 watch dog should
be "mediatek,mt6873-wdt","mediatek,mt8192-wdt".
[1]
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2287090/12
[2]
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2131598/18
> + reg = <0 0x10007000 0 0x100>;
> + #reset-cells = <1>;
> + };
> +
[snip]
> +
> + mmsys: mmsys@14000000 {
> + compatible = "mediatek,mt8192-mmsys", "syscon";
You should define "mediatek,mt8192-mmsys" first, then you could use it
in this patch.
Regards,
CK
> + reg = <0 0x14000000 0 0x1000>;
> + #clock-cells = <1>;
> + };
> +
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-29 8:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 1:30 [PATCH v3 0/3] Add basic node support for Mediatek MT8192 SoC Seiya Wang
2020-07-29 1:30 ` [PATCH v3 1/3] arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile Seiya Wang
2020-07-29 8:02 ` CK Hu [this message]
2020-07-29 8:10 ` CK Hu
2020-07-29 1:30 ` [PATCH v3 2/3] dt-bindings: serial: Add compatible for Mediatek MT8192 Seiya Wang
2020-07-29 1:31 ` [PATCH v3 3/3] dt-bindings: timer: " Seiya Wang
2020-07-31 21:13 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596009775.12468.6.camel@mtksdaap41 \
--to=ck.hu@mediatek.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).