From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DAC9C433E1 for ; Wed, 12 Aug 2020 07:55:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AEF5206B2 for ; Wed, 12 Aug 2020 07:55:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DH+gdgZS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1p4LHA72" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AEF5206B2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3IIZ7Th+gGHZwayKwAJnq+h5Milmyb2mgrinSSXyc9w=; b=DH+gdgZSbpb6Pp4Mo6+s7hyj0 28JGhpcU5cl5DPvjM6/erWigAhK+WGguddSwtWH8uk4tzkyxprfIqlhFKhCJAsIDF8H1wgzqnrTFC fPAsHUrZDMJgFpZSe2w4MhBBI7Gtr/A499yE615uAhJdiGZKPUyM57XJ8g+o0T1tKlp+qLWfe1ArI ISk6sHRrb5fv+BkCTeEb+onx9oF+bgeQSJvEajryXRVVGyneohrSBAn7dNWIcJ/rlSRaePxoW8npy Iy2uWgdzMDLMxStIygJkWOPnWprj6oYE5RlQFzS9kTFYMw/igQ2fiuZNy1ibKo1ftLjn5qJzfwd4+ RbZT1Cfjw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5lYs-0002T5-NU; Wed, 12 Aug 2020 07:52:38 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5lYp-0002QL-81; Wed, 12 Aug 2020 07:52:36 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65F02206B5; Wed, 12 Aug 2020 07:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597218753; bh=lYGnGkLHu1hG+xc/o4ReH2xXsUyzFmXjEImOntyD4ws=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=1p4LHA72BP10qSH06MuALxEGL+GU2nbkV9CWNkn7+vzYlWNNa2iKUE7l2t2sNjo87 097ws6IFpDJ2P3anL6PUXIcGnhWnHUm+WEEkiKkVvGdz9NhD2BwpbfB2/UyB/xievf kX/NCz4f7O+i1NWsIh4cgBHOC7WzfgCLvMNrQO6c= MIME-Version: 1.0 In-Reply-To: <20200810044020.2063350-1-natechancellor@gmail.com> References: <20200810044020.2063350-1-natechancellor@gmail.com> Subject: Re: [PATCH] clk: rockchip: Fix initialization of mux_pll_src_4plls_p From: Stephen Boyd To: Michael Turquette , Nathan Chancellor Date: Wed, 12 Aug 2020 00:52:32 -0700 Message-ID: <159721875227.33733.9237826555988566719@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_035235_383417_AD4DA07B X-CRM114-Status: GOOD ( 12.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , clang-built-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Nathan Chancellor , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Nathan Chancellor (2020-08-09 21:40:20) > A new warning in Clang points out that the initialization of > mux_pll_src_4plls_p appears incorrect: > > ../drivers/clk/rockchip/clk-rk3228.c:140:58: warning: suspicious > concatenation of string literals in an array initialization; did you > mean to separate the elements with a comma? [-Wstring-concatenation] > PNAME(mux_pll_src_4plls_p) = { "cpll", "gpll", "hdmiphy" "usb480m" }; > ^ > , > ../drivers/clk/rockchip/clk-rk3228.c:140:48: note: place parentheses > around the string literal to silence warning > PNAME(mux_pll_src_4plls_p) = { "cpll", "gpll", "hdmiphy" "usb480m" }; > ^ > 1 warning generated. > > Given the name of the variable and the same variable name in rv1108, it > seems that this should have been four distinct elements. Fix it up by > adding the comma as suggested. > > Fixes: 307a2e9ac524 ("clk: rockchip: add clock controller for rk3228") > Link: https://github.com/ClangBuiltLinux/linux/issues/1123 > Signed-off-by: Nathan Chancellor > --- Looks good to me. I can pick it up for clk-fixes if Heiko agrees. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel