From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9237C433E2 for ; Tue, 1 Sep 2020 14:39:10 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B39D8206FA for ; Tue, 1 Sep 2020 14:39:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iLUYv921"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="EJBRW0sy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B39D8206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=okaIsowea37f1x7I8KYn+cGTz/xadTXevsZOxhd8dkw=; b=iLUYv921QFWikKCcdhEvhiDu+ ewqmcx7hPjzut3ChbSRFZ5Hqm4p0lkUnQPKXUX95bhMZlv2zyOeZ8TlmUGafuB/N4xdFnB8XaPiUW 3djI6waY0/CXURwOrYsBNfSPZJyhdEprtMg8fd/DSeTuOV/r8+urmQHuJWrEa2jF3p18BUQRoUoih E2f9T1oCDOmo6PiIeSfD1oxNDQ/xy9XcvxYyi2ZayUQxjrhNHwnTrDBfqnyraEyWRPl2i/0wdDmTX G7XTjMEw1BEvoRs2XWA0cO7RR3o5CfZZsOZ6ZkAifru3YZcsvndnhP6hhLp9J8fUp1Mtsi9Fblgry 00ijMHZXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD7Pj-00054B-9g; Tue, 01 Sep 2020 14:37:35 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD7Pf-00052x-MU; Tue, 01 Sep 2020 14:37:33 +0000 X-UUID: c66e7895058f4ab8ac1e6f39176790a8-20200901 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=i/M1pWATEggY6t0efcPJUKkWQXwt7jVFmbATAeUxAOU=; b=EJBRW0syQgoRchR5DfJWuP0QP7ePjlYlefYApyEO13j8PAvDViol5N7jl1rEr2myN2pvHGI+Yq79fpYMBZfvEYvUU36NFHvhInbDAEkvZ55RkxkwyK0Ca8X3A+8xIem4Gm5ZMheXR9+GTSqeMqqzBQt9DFzs/ETp9HOJr3/4EJQ=; X-UUID: c66e7895058f4ab8ac1e6f39176790a8-20200901 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 367147839; Tue, 01 Sep 2020 06:37:18 -0800 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Sep 2020 07:37:16 -0700 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Sep 2020 22:37:12 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 1 Sep 2020 22:37:11 +0800 Message-ID: <1598970937.4733.21.camel@mhfsdcap03> Subject: Re: [PATCH v13 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings From: Dongchun Zhu To: Sakari Ailus , Tomasz Figa Date: Tue, 1 Sep 2020 22:35:37 +0800 In-Reply-To: <20200831160644.GL31019@paasikivi.fi.intel.com> References: <20200710101850.4604-1-dongchun.zhu@mediatek.com> <20200710101850.4604-2-dongchun.zhu@mediatek.com> <20200831160644.GL31019@paasikivi.fi.intel.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 445E85A69E8366B468046E9E6B70917AF91F340655DCFA76B1105FB898ACB8272000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_103731_978914_2EA5BA19 X-CRM114-Status: GOOD ( 41.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nicolas Boichat , Andy Shevchenko , srv_heupstream , linux-devicetree , Shengnan Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=A3=E7=94=B7=29?= , Louis Kuo , Sj Huang , Rob Herring , "moderated list:ARM/Mediatek SoC support" , dongchun.zhu@mediatek.com, Matthias Brugger , Cao Bing Bu , matrix.zhu@aliyun.com, Mauro Carvalho Chehab , "list@263.net:IOMMU DRIVERS , Joerg Roedel , " , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tomasz, Sakari, Thanks for digging into the imperfections. On Mon, 2020-08-31 at 19:06 +0300, Sakari Ailus wrote: > Hi Tomasz, > > Thanks for dressing this into words. > > On Mon, Aug 31, 2020 at 01:44:27PM +0200, Tomasz Figa wrote: > > Hi Dongchun, > > > > On Fri, Jul 10, 2020 at 12:19 PM Dongchun Zhu wrote: > > > > > > Add YAML device tree binding for OV02A10 CMOS image sensor, > > > and the relevant MAINTAINERS entries. > > > > > > Reviewed-by: Tomasz Figa > > > Reviewed-by: Rob Herring > > > Signed-off-by: Dongchun Zhu > > > --- > > > .../bindings/media/i2c/ovti,ov02a10.yaml | 172 +++++++++++++++++++++ > > > MAINTAINERS | 7 + > > > 2 files changed, 179 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > new file mode 100644 > > > index 0000000..3a916cc > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02a10.yaml > > > @@ -0,0 +1,172 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +# Copyright (c) 2020 MediaTek Inc. > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov02a10.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Omnivision OV02A10 CMOS Sensor Device Tree Bindings > > > + > > > +maintainers: > > > + - Dongchun Zhu > > > + > > > +description: |- > > > + The Omnivision OV02A10 is a low-cost, high performance, 1/5-inch, 2 megapixel > > > + image sensor, which is the latest production derived from Omnivision's CMOS > > > + image sensor technology. Ihis chip supports high frame rate speeds up to 30fps > > > + @ 1600x1200 (UXGA) resolution transferred over a 1-lane MIPI interface. The > > > + sensor output is available via CSI-2 serial data output. > > > + > > > +properties: > > > + compatible: > > > + const: ovti,ov02a10 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: top mux camtg clock > > > + - description: divider clock > > > + > > > + clock-names: > > > + items: > > > + - const: eclk > > > + - const: freq_mux > > > > Why do we have two clocks here? Looking at the example suggests that > > they may be the clocks of the SoC that the integration was done with. > > However, the binding must only define the aspects of the particular > > device, i.e. this sensor. > > > > I suppose we should only have "eclk" here and it should be described > > as "external clock for the sensor". > > I cannot agree with you more, it would be fixed in next release. > > > + > > > + clock-frequency: > > > + description: > > > + Frequency of the eclk clock in Hertz. > > > > nit: maybe Hz? > > Both shall be okay, let's use Hz instead, which seems to be more simple. > > > + > > > + dovdd-supply: > > > + description: > > > + Definition of the regulator used as Digital I/O voltage supply. > > > + > > > + avdd-supply: > > > + description: > > > + Definition of the regulator used as Analog voltage supply. > > > + > > > + dvdd-supply: > > > + description: > > > + Definition of the regulator used as Digital core voltage supply. > > > + > > > + powerdown-gpios: > > > + description: > > > + Must be the device tree identifier of the GPIO connected to the > > > + PD_PAD pin. This pin is used to place the OV02A10 into standby mode > > > + or shutdown mode. As the line needs to be high for the powerdown mode > > > + to be active, it should be marked GPIO_ACTIVE_HIGH. > > > + maxItems: 1 > > > + > > > + reset-gpios: > > > + description: > > > + Must be the device tree identifier of the GPIO connected to the > > > + RST_PD pin. If specified, it will be asserted during driver probe. > > > + As the line needs to be low for the reset to be active, it should be > > > + marked GPIO_ACTIVE_LOW. > > > + maxItems: 1 > > > + > > > + rotation: > > > + description: > > > + Definition of the sensor's placement. > > > + allOf: > > > + - $ref: "/schemas/types.yaml#/definitions/uint32" > > > + - enum: > > > + - 0 # Sensor Mounted Upright > > > + - 180 # Sensor Mounted Upside Down > > > + default: 0 > > > + > > > + ovti,mipi-tx-speed: > > > + description: > > > + Indication of MIPI transmission speed select, which is to control D-PHY > > > + timing setting by adjusting MIPI clock voltage to improve the clock > > > + driver capability. > > > > The description says that the value adjusts "MIPI clock voltage". > > Should the property be renamed to "ovti,mipi-clock-voltage"? > > Sure, mipi-clock-voltage seems more clear, perfect naming :-) > > > + allOf: > > > + - $ref: "/schemas/types.yaml#/definitions/uint32" > > > + - enum: > > > + - 0 # 20MHz - 30MHz > > > + - 1 # 30MHz - 50MHz > > > + - 2 # 50MHz - 75MHz > > > + - 3 # 75MHz - 100MHz > > > + - 4 # 100MHz - 130MHz > > > + default: 3 > > > + > > > > I've discussed this on IRC with Sakari. It sounds like this works as > > is for us because the driver currently only supports 1 mode, always > > running the link at 390 MHz. This won't scale if one intends to add > > more modes, because DT can't be expected to be updated when the driver > > changes. The two are expected to be separate and backwards compatible. > > > > I think we could model this in DT as an array of > voltage> pairs. Similarly to the OPP bindings [1]. An example to have > > all link speeds up to 390 MHz use the value 4: > > > > ovti,mipi-clock-voltages = < > > /* KHz clock voltage unit */ > > 390000 4 > > >; > > > > if one wants to select different voltage for different link, they > > could do so as well. With the example below, the driver should > > configure "3" for link frequencies <= 150 MHz and "4" for > 150 MHz <= > > 390 MHz. Link frequencies > 390 MHz should be disallowed. > > > > ovti,mipi-clock-voltages = < > > /* KHz clock voltage unit */ > > 150000 3 > > 390000 4 > > >; > > > > What do you think? > So now we define the MIPI clock voltage (unit) as one function of link frequency? For current sensor mode (1600x1200, 390MHz link frequency), we then shall always use the value 4 to configure the MIPI transmission speed selection (P1:0xA1). Am I correct in thinking that? > One more note on my proposal: use the index of the link frequency to access > the ovti,mipi-clock-voltages array. That should be more simple for the > driver, as the driver is expected to use only link frequencies listed in DT > bindings anyway. > Good idea! That's exactly what I mean. Just submitted one draft change to handle the new property in DT. @Sakari @Tomasz please help to review it. https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2387980/1/drivers/media/i2c/ov02a10.c#883 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel