From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB86FC43461 for ; Thu, 10 Sep 2020 16:10:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BC5F206A1 for ; Thu, 10 Sep 2020 16:10:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="quxB9tb2"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="SqTOBGdd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=hansenpartnership.com header.i=@hansenpartnership.com header.b="SqTOBGdd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BC5F206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=HansenPartnership.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lN5mTyXpGUOCMRvewKRND0DLvaa6DSAh7zrgJZzkMGA=; b=quxB9tb2V32rgXuE3C2yrR5en TueABwmQM1VGe5QamFuEVkvdRyoJxWxSz8pPJQyoU9Jb/XWGIFQrrWK7xd+Z8QhwUHuBCbF/gt7jv 5mPaGcwGghTERA2POlAwTGmJKAeWGJouq+kKlSzLYnHy2uczJelUAN5kCDG1J8jBjHVIxrSFXb6y8 MFTLb6RvkfxICT0ZJBXdqKrfdR6XJo0Mmg4QT9wQi15p++Xb/50MROMKPEhYJRA9wyFeUiLKrOlEN K8HWIc34bM057yR6qQSbp/kuVvUs5u4wgVXzMrXDwhrxKN1d0lOAWLkL2pBICqQCckZkiiGADS3G4 daOVwTSSQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGP8P-0008WN-HZ; Thu, 10 Sep 2020 16:09:17 +0000 Received: from bedivere.hansenpartnership.com ([66.63.167.143]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kGP8L-0008VG-J8; Thu, 10 Sep 2020 16:09:15 +0000 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id B4B848EE11E; Thu, 10 Sep 2020 09:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1599754150; bh=vjqoZjjs4ZL988BGG7sXtVJHzIb1zQDOeZ88/1JThQw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SqTOBGdd05DEXZCUAUSRCFQLQh+D8HlmsHDZknIpCoLNKWMiASjKLlkwGQpE1qB2y Ra66T5QAZClQDQ1tI6wCPqz6A+A1azS+MUvPfnrYOwq0bWYX6ZlSPFX3WbX9nPfwsv HXiNLeDe7+r88pNXMcY6eguRdu3R4RQu703OyKHk= Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c7vL7lTQ-z-f; Thu, 10 Sep 2020 09:09:10 -0700 (PDT) Received: from [153.66.254.174] (c-73-35-198-56.hsd1.wa.comcast.net [73.35.198.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id 6C6ED8EE0E2; Thu, 10 Sep 2020 09:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=hansenpartnership.com; s=20151216; t=1599754150; bh=vjqoZjjs4ZL988BGG7sXtVJHzIb1zQDOeZ88/1JThQw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=SqTOBGdd05DEXZCUAUSRCFQLQh+D8HlmsHDZknIpCoLNKWMiASjKLlkwGQpE1qB2y Ra66T5QAZClQDQ1tI6wCPqz6A+A1azS+MUvPfnrYOwq0bWYX6ZlSPFX3WbX9nPfwsv HXiNLeDe7+r88pNXMcY6eguRdu3R4RQu703OyKHk= Message-ID: <1599754148.3575.4.camel@HansenPartnership.com> Subject: Re: [PATCH v2 1/2] scsi: ufs: Abort tasks before clear them from doorbell From: James Bottomley To: Stanley Chu Date: Thu, 10 Sep 2020 09:09:08 -0700 In-Reply-To: <1599725880.10649.35.camel@mtkswgap22> References: <1599099873-32579-1-git-send-email-cang@codeaurora.org> <1599099873-32579-2-git-send-email-cang@codeaurora.org> <1599627906.10803.65.camel@linux.ibm.com> <1599706080.10649.30.camel@mtkswgap22> <1599718697.3851.3.camel@HansenPartnership.com> <1599725880.10649.35.camel@mtkswgap22> X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200910_120913_800309_6D3D3C8F X-CRM114-Status: GOOD ( 13.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "moderated list:ARM/Mediatek SoC support" , rnayak@codeaurora.org, linux-scsi@vger.kernel.org, "Martin K. Petersen" , open list , saravanak@google.com, nguyenb@codeaurora.org, ziqichen@codeaurora.org, Avri Altman , Can Guo , "moderated list:ARM/Mediatek SoC support" , salyzyn@google.com, Alim Akhtar , Matthias Brugger , Bean Huo , kernel-team@android.com, Bart Van Assche , hongwus@codeaurora.org, asutoshd@codeaurora.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-09-10 at 16:18 +0800, Stanley Chu wrote: [...] > > + if (!err) { > > +cleanup: > > Yeah, considering Bean Huo's patch "scsi: ufs: No need to send Abort > Task if the task in DB was cleared", "cleanup" label shall be added > back here. > > So your resolution looks good to me. > > Thanks so much : ) You're welcome ... but just remember I have to explain this to Linus when the merge window opens. It would be a lot easier if this hadn't happened so please don't make it any worse ... James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel