From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82500C47087 for ; Fri, 28 May 2021 06:35:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41CEF613D4 for ; Fri, 28 May 2021 06:35:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41CEF613D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fi.rohmeurope.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID: In-Reply-To:References:Message-ID:Date:Subject:CC:To:From:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vTNvHy3ge39FnDIC8B4QKxc2qO8lkQvCHE/xmZMg3sE=; b=uAuV+JV58CnCUt JYKb4/f0nc9+vY+/ecofCfBtNQX2MOx02vuP6M0/njTcK2L78Jde/ixl8Dwp6ecjXpqiyUtMB/Hgw ql81MhOyvBoiNp4Vs3++l4wpTtxyc/3MyGbBMEOMWU/srMCKrLA+biEn1amI2RDW5gXlRrF1vtHi1 BSzRNNc85faFh/uGVhaBjJPDsOMq8Pg4R2nuSzsKMP3RY6DkSQ7mH+TOkOxXhMXXwXwrT+WWPwxuO jBYHPjGuXAuWuTirJ6WwnCRgdcL4fnOwlJoWFps0kt63OQ7bXMiQOWCDbiZOxr1ws9RdG+KVsgmpv KVbovoGr62tjdyT1D+mA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmW3i-00CdrI-U3; Fri, 28 May 2021 06:33:27 +0000 Received: from mail-eopbgr10078.outbound.protection.outlook.com ([40.107.1.78] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmW3f-00CdoA-33 for linux-arm-kernel@lists.infradead.org; Fri, 28 May 2021 06:33:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gfk2sLOLgBj4gv9zjw+PgciNnhEc/13yZWxBw/v4YTbmUQhoxj6Uu7kZjW07ht+62TOfPWXbsx3wSY5JCdpSClJ5KIZGkxll3wm5t6yHXQN2Ed0ntNnQASbaOaxL3JYVqb4MWk6hTkabNLL3cmEz9iyr8cp6egRrJl5yrvmzNtqIZbtCLL1yXKz+3kT0JuF1Qy2v2OLL49CU99cSDNoRTkpVKaJwes0VyGkXY+MbVp2ap5lRZw+Abin4O04Ej1R8SwbwtV070WKfS1bY5q0ufkwEXGBcXoYMv0DW5m+zpsOd/Z6WQAdQv5E0KrDQVyodDFGG9+xwHgnNCnQrPvM5fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G7LQK7m+PDhVV9v2QaNVGxKQuVVnfRdcki/r2rt2XrE=; b=KWtM2p56YlhUQUudMx3/poURDN0n9ryjE0M+auqj3P0+3hIuCYd7cHJU3qRuom9bTGb9QSd4rsIJWCmv5YYcjaDzrMVY2ZIii71E4ppPikvYA16PR6afeABmLNukF18nugwVZLQj/tKihrA/HyVtXPHpmaCsS+7No97LNUZX8zJ/sAIAteBikVBD2B8mFY42Obv6wLC1A9S/E75kTYRwsjK8FWfnfRt/jfCbz1drBqMNG/4fApzQLWnuZ+CWV8sT+zVUUNRZmnRDh1d67+U9QYWrDWFGCpkzYbV6QxL0ORAqS3/pt9/Ct/jHrPZGL+1sg6Q7dQVBSjope+4XXtkklg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=fi.rohmeurope.com; dmarc=pass action=none header.from=fi.rohmeurope.com; dkim=pass header.d=fi.rohmeurope.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rohmsemiconductoreurope.onmicrosoft.com; s=selector1-rohmsemiconductoreurope-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G7LQK7m+PDhVV9v2QaNVGxKQuVVnfRdcki/r2rt2XrE=; b=VueOV9lolJ999KuI3l9HZmtkXKVrY/j54o9FP7nYubyLrG3TE6i3rTm344IOJNP7fsTfIy7fa6Ej9IbvGHXxObjVtWUEZ738/+FHn7z+a9BgM1BG2AwZExpcNGFxSJ6BHEMi5GLXcdv0+48Fo5NXGsdacbIDDGFlWTiyJyRMy84= Received: from HE1PR03MB3162.eurprd03.prod.outlook.com (2603:10a6:7:55::20) by HE1PR0301MB2169.eurprd03.prod.outlook.com (2603:10a6:3:21::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.24; Fri, 28 May 2021 06:33:15 +0000 Received: from HE1PR03MB3162.eurprd03.prod.outlook.com ([fe80::a88a:6fa9:ab7f:4a44]) by HE1PR03MB3162.eurprd03.prod.outlook.com ([fe80::a88a:6fa9:ab7f:4a44%4]) with mapi id 15.20.4173.026; Fri, 28 May 2021 06:33:15 +0000 From: "Vaittinen, Matti" To: "linus.walleij@linaro.org" CC: linux-power , "bcm-kernel-feedback-list@broadcom.com" , "bgolaszewski@baylibre.com" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "michael@walle.cc" , "noltari@gmail.com" , "jonas.gorski@gmail.com" , "f.fainelli@gmail.com" , "andy.shevchenko@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 0/3] gpio: gpio-regmap: Support few custom operations Thread-Topic: [PATCH v4 0/3] gpio: gpio-regmap: Support few custom operations Thread-Index: AQHXUfTMWdGKRh/nT0q8zsRZfWZU3Kr2XhQAgAG1tuWAAF74AA== Date: Fri, 28 May 2021 06:33:15 +0000 Message-ID: <15d9e565021c115eec268c7fca810799eb503a90.camel@fi.rohmeurope.com> References: <0c2a8ffab666ef31f5cee50b8b47767285dfe829.camel@fi.rohmeurope.com> In-Reply-To: Accept-Language: fi-FI, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.34.4 (3.34.4-1.fc31) authentication-results: linaro.org; dkim=none (message not signed) header.d=none;linaro.org; dmarc=none action=none header.from=fi.rohmeurope.com; x-originating-ip: [2001:14ba:16e2:8300::4] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 99787801-a05b-4d09-5d2b-08d921a2794f x-ms-traffictypediagnostic: HE1PR0301MB2169: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +XDlLy4wFfALi2FXevIOZltBPSCbZk2Rk0gGmth8NrvJArLyxK2OV7owRm/XRAKXpY2J9qukJSy5iYoW91zZlVVpMe26j94EMusTP/A3bkhFxtpqM3wICgHETjVcrhBOZrXK+aBwn+V8TVPngjHhM0D+7pl3JYM+t7SZUJ/jZGbCKCv2GjpJyWYL0Y0nZ2K4h/IxjbGOdO8FtduVEuzpyz3y+g59sxqop78RLhrV2SvZKugrNkBGQNwOLrzAGGoPlUygb0vBRfJI8/fObsp9MIbUsjaVrc0Kl5BDYrLYNOWldLs2tB25kYpUCKJ8GfE/0C0MMJGU8KAvAz/gwItPduxNkwA0KHOiqs2RM+Zk9XE+jWgBRpK7yup2lYJMScV+3o1BiQgHyNm1rCY0sKdfPLWXlHQPc+zk3dLO5DOTesU35zZzxYUJFWckr6gSebDz+0JusOAW2puHLtE6llZi5DNGWOEYwMwFGWI2Kc6DdoEkOKeQQaKrkmltRC4Rrr/ZI/wzj1Uy5N3lkukiO/f9vmcVfWJVjfqR/gN+QlE+P7WItui5e/vUpYbmsni6HqvgeYLE49tVoEGketKHFMu4jL6Aw/zRbx1XsNrGTeJTa10= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HE1PR03MB3162.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(396003)(366004)(346002)(39840400004)(7416002)(2616005)(316002)(6916009)(54906003)(66946007)(76116006)(4326008)(66556008)(66476007)(478600001)(64756008)(66446008)(53546011)(6512007)(2906002)(6506007)(5660300002)(86362001)(8936002)(38100700002)(3450700001)(186003)(122000001)(8676002)(71200400001)(6486002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?SVlEU3JCWU1sMUFqNlBoYXZIYXQ1Y1BYWk85Mm1FRHc1YUNuaGhRV1VLNWpW?= =?utf-8?B?QzFpY1pHNHBlNzM1MGl5UUQ3RUhBaEpLdGhZSkNyZDRIeXF5TnJEcyttMTBR?= =?utf-8?B?RFRER0UwYVZCRFgwb2ZJQk1MdjVrVlNTN2owM0EvdTNFV0JVK1ZyZmgrdis3?= =?utf-8?B?NlVqU0dWZ0hNc1pJR0ZsOVZmd0QwUCtIQTJQZGVQclNIN1NNUGcyRG9pdDRP?= =?utf-8?B?ZmYzaUhvdTE4TnMydXRocmErelZKRVdqOCtjWlZDOTd0QzJ4c1RaYVJZL1Qy?= =?utf-8?B?amU2RUJ1RmRGK3F4dG1EKzZPQ1NQdkhaUytsN2ZOWW1XcUplSERFb25DZzJa?= =?utf-8?B?OUFZbThZVHR4RjNXOWpScDJDY1VQM3lDdFI0bUszeVB1SWZYdzlIOGs2MjJX?= =?utf-8?B?MDVzVWhnTjBKa0pXR3Z5TWRLQnNhdUg3U1J6N0h4Zmw4WjhpeTByYnZ0ck5j?= =?utf-8?B?TXQ3dEVGZldKZWRSSGNYbGxJQ25rMk13SjZWUGhJZWRzc1pnWkZGbW8xTnpU?= =?utf-8?B?M1NTRzA5eDVFOTdwRC8vM0NzVTJqUkpyRWMycVhTaWN2ZW15V08yWGxCUzdT?= =?utf-8?B?Ky9YSFliUDh1L2FPQTJqeXNHbUpiU3VTekNPdE9peFlZMFQxTmtaQ3NKMS9j?= =?utf-8?B?QW1mYnhBOWpPNnQrclFlT1hHTUFiYm14eVNVcXB1RkRRUkV3UHVsRm0vS3NG?= =?utf-8?B?Lyswb3hLZzdQMHJrLy9GNU5sSUhtcm9HVlZUeUZrYXNpenZNbTQ3dktobTA1?= =?utf-8?B?MWlEWHlHUU5Hb0Q2enNUMmQzTkpjTU94czB6QnRxVEZYeWNnRDZVTGhISEdB?= =?utf-8?B?RXorRVNrRzcwQXYyMTJ5VDM3K2lqejJwMmZRQWVPMDFvZ2RoNURLaGJvTU1q?= =?utf-8?B?OWUrRkw1QUNvZEpCWG9BREErZCtoYUVyQ2I3Z3hKY28ycExHZUJxR3BFbzBV?= =?utf-8?B?SHIzRVc5eEJTK3orWGIvMEF1cDk3VzVLb2tSOC9OU2VjZmZQRjhybjVIVEVD?= =?utf-8?B?Q2RNN01Ea0QzSjYwVE92RzRXSnVVbmw0eG9DS0xZOHVEZVVIcWcrYUI5NkZC?= =?utf-8?B?WHlJTlkzWlFjTEtuRVlyUWFBZGlnVS9kUjFqRThQdCt1bjNBblZBYld3am5p?= =?utf-8?B?VktKRndoeC90dzh6Qi9VVEV2OE9hTG5mc3JUbjl0SG55UXgrNURDOW5RUmlm?= =?utf-8?B?dDR2SEgzRy9KSCtKNzNFK05WamNCc1BOanNMc0VYYlB2NlFPU0FZcGMycjNp?= =?utf-8?B?S1kydFYvd0tLMWsyQUdPZDYwSW1lUmVLdkZTMnJRNEFrNlBHbUJBSkNFYlpH?= =?utf-8?B?eEVzMmhIcEExMnYrUzNxWWd6Q05tMk1ERGN3TzEzTTZaaFVXMWRYMGFvU1FX?= =?utf-8?B?SVVOS3Bqb0pEa2Y5WTI2Wm1ya0tjaWhEUFI1K002ZllydUYrQ21VYW9ubklK?= =?utf-8?B?Q0NmSWEzMWJZNkNtakdrcHdNUmUwalRjT1RuZ2RMUGN1TGtYNzZsOXZEemlM?= =?utf-8?B?NWRYSXZIalBhVHhnL2RkNTJURElnVDJ0bWg0Rm1uT2RsZisxclpyamZkSlpQ?= =?utf-8?B?ckJzcW1BSkVyRjBtZmcvV1d4TC9UYkN4L1EzTlgrZXkwNVpwS042d0ZTcWRz?= =?utf-8?B?czVHTlc4TFI5c2MvM292eXpyTDlsbU96Q2srcWNiU0JXWXlPdU52RE1mUEdt?= =?utf-8?B?TVE0YUJUbmFZMTJYZWlRWi8rbGFjQzJ5b1hwUS9WaXJKZGMxbmNKbk5nSHU1?= =?utf-8?B?RUJkU0lYRzZHWDVVeGM2NjhFU3ZFZDMza1FDQWh4OGp4K1o3cWJYYkF5Umhi?= =?utf-8?Q?eKGfwwmFkb2NSPXuaDstev/UiWMOJVIJT9e5A=3D?= Content-ID: <303C914B8F72314CB6523F3C7DBBE529@eurprd03.prod.outlook.com> MIME-Version: 1.0 X-OriginatorOrg: fi.rohmeurope.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HE1PR03MB3162.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99787801-a05b-4d09-5d2b-08d921a2794f X-MS-Exchange-CrossTenant-originalarrivaltime: 28 May 2021 06:33:15.2629 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 94f2c475-a538-4112-b5dd-63f17273d67a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ie2gRIOQOM5R13WkbSWG1DPTrfJHQlgtu4xiic5ygRGMBBl5dSqeZMB8OUzlImzXN0mgTO8xQsQ4Bt4kYMsmhUp9ehBxj/jyOjrhSvHNvsCuYSuCr45XxhyVRzr7fe+h X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0301MB2169 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_233323_162691_B837BAE1 X-CRM114-Status: GOOD ( 34.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: "Vaittinen, Matti" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-05-28 at 02:53 +0200, Linus Walleij wrote: > On Thu, May 27, 2021 at 8:32 AM Matti Vaittinen > wrote: > > > I think that the disagreement boils down to few styling issues - > > and > > one more pragmatic one. And only what comes to how we allow > > implementing the IC specific call-backs for these more complex HW > > specific cases. "Styling" boils down to providing getter-functions > > for > > well-defined gpio_regmap properties like regmap, device and fwnode > > pointers Vs. exposing these in a well-defined structure as function > > parameters. > > Just do it the way the maintainer likes it I guess? Michael wrote > the driver so do it in his fashion. This is fair game I'd say. If there is no compromise - then it should really be in a maintainer's fashion or not at all. > > > So > > at the end of the day it's fair to go on in a way Michael and You > > find > > easiest to maintain. > > What makes things easy for me to maintain is active and happy > driver maintainers, so it is paramount that the file looks to Michael > like something he wants to keep maintaining. This removes work > from me and Bartosz. I agree. When someone takes care of a driver, he should be happy with it. Period. And thanks to Michael for writing this driver and reviewing the patches. Reviewing is hard work. On the other hand, I don't enjoy writing code I am unhappy with either. And as this particular piece of code is not a paid task for me, I do this for fun. gpio-regmap is not mandatory for my drivers now. So, I'll just opt-out from this change. I'll happily use the gpio-regmap where it fits, when it fits. So, during the last cycle I promised to look the gpio-regmap usage on ROHM IC drivers: Currently it does not fit for the BD71815 as it lack support for init_valid_mask and set_config. It does not work for the BD71828 either due to lack of set_config and special handling of HALL_GPIO. Regarding the BD70528 - with my heart bleeding I just sent a set of patches to remove this IC's drivers completely. It seems the IC never really took off. The BD9571 was not authored by me and I don't have that IC - but at quick glance it seems that driver might work with gpio-regmap. Conversion would require some testing. > Maintainer style quirks are common, I have some myself (like > never allowing __underscore_functions) I like this. The Linux kernel community is well known for strict and enforced styling guide. I've also worked in an another pretty huge project, where every developer was pretty much allowed to use their own style. I think it resulted happier developers and definitely made code- readers much more careful ;) I'd claim that made people to pay more attention when reading code - you could _never_ safely assume. It was also somehow funny that at times one was able to recognize a file author just by looking the code :) Well, I would not suggest that to the Linux kernel - but I definitely like allowing few maintainer quirks here and there. And I am definitely hoping to see happy maintainers. Even though the __foo() for internal functions is the right thing to do (tm) ;) > we just adapt to their > quirks and be good diplomats. Or keep whingeing and acting up - depending on the person XD Keep up the good work you all :) Best Regards --Matti _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel