From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01777C10F00 for ; Fri, 6 Mar 2020 16:43:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5CD02072A for ; Fri, 6 Mar 2020 16:43:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ixwoE1Mr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C5CD02072A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SWeMKwY+x4p+itTsfxpLoT5PJAZsZf7eVxSpRPLZSNM=; b=ixwoE1MrWpHNPY5RWIrJSm2+T +uWYc1tiCr7tuXLEdJe/e+pRnTd+4aT2DtmgIC0ajoD8TDP4DrCKkYH9VvhpvSffaNC8r52e+wv2U XdAejxQBwvLZIF1AHtbtDBA1pb/p9oyZuas0kk6IBMKXhUAFv2/6jXcawrlFV4d2DMSjMhVzDzQVd kDHM2AuaWb068lSvXb49jgWKYyWnjDUMctqvP2WfJ/Paa9xcLeXurVVVeAuyvSDLJgscXxyMRcBvK PhaR1K0RL1H2aMdaPe1BW8eUdbvs3K4RbID5+K52/SiLKB175JLy0AqCfyuuiBZ/a/lZGXz78oHs+ ONTXwBZdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAG4m-0002Tw-FN; Fri, 06 Mar 2020 16:43:52 +0000 Received: from lhrrgout.huawei.com ([185.176.76.210] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jAG4k-0002TK-0a for linux-arm-kernel@lists.infradead.org; Fri, 06 Mar 2020 16:43:51 +0000 Received: from LHREML711-CAH.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 16B078550CAB53C01BB0; Fri, 6 Mar 2020 16:43:48 +0000 (GMT) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by LHREML711-CAH.china.huawei.com (10.201.108.34) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 6 Mar 2020 16:43:47 +0000 Received: from [127.0.0.1] (10.202.226.45) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 6 Mar 2020 16:43:47 +0000 Subject: Re: About commit "io: change inX() to have their own IO barrier overrides" To: Arnd Bergmann References: <2e80d7bc-32a0-cc40-00a9-8a383a1966c2@huawei.com> <8207cd51-5b94-2f15-de9f-d85c9c385bca@huawei.com> <6115fa56-a471-1e9f-edbb-e643fa4e7e11@kernel.org> <7c955142-1fcb-d99e-69e4-1e0d3d9eb8c3@huawei.com> <90af535f-00ef-c1e3-ec20-aae2bd2a0d88@kernel.org> <182a37c2-7437-b1bd-8b86-5c9ce2e29f00@huawei.com> From: John Garry Message-ID: <15e7158d-184d-9591-89a6-cd6b10ef054d@huawei.com> Date: Fri, 6 Mar 2020 16:43:46 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.202.226.45] X-ClientProxiedBy: lhreml716-chm.china.huawei.com (10.201.108.67) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_084350_205628_6B8C5AE6 X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch , Catalin Marinas , Sinan Kaya , "linux-kernel@vger.kernel.org" , Jiaxun Yang , "xuwei \(O\)" , Bjorn Helgaas , Will Deacon , Linux ARM Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/03/2020 16:29, Arnd Bergmann wrote: >> The idea is good, but it would be nice if we just somehow use a common >> asm-generic io.h definition directly in logic_pio.c, like: >> >> asm-generic io.h: >> >> #ifndef __raw_inw // name? >> #define __raw_inw __raw_inw >> static inline u16 __raw_inw(unsigned long addr) >> { >> u16 val; >> >> __io_pbr(); >> val = __le16_to_cpu(__raw_readw(addr)); >> __io_par(val); >> return val; >> } >> #endif >> >> #include >> >> #ifndef inw >> #define inw __raw_inw >> #endif > Yes, makes sense. Maybe __arch_inw() then? Not great either, but I think > that's better than __raw_inw() because __raw_* would sound like it > mirrors __raw_readl() that lacks the barriers and byteswaps. Right, I had the same concern. And maybe the "arch" prefix is misleading. Just __inw could be ok, and hopefully not conflict with the arch/arm/mach-* definitions. Thanks, John _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel