linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Henry Chen <henryc.chen@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Nicolas Boichat <drinkcat@google.com>,
	Mike Turquette <mturquette@linaro.org>,
	James Liao <jamesjj.liao@mediatek.com>,
	Viresh Kumar <vireshk@kernel.org>,
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stephen Boyd <swboyd@chromium.org>,
	Fan Chen <fan.chen@mediatek.com>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Ryan Case <ryandcase@chromium.org>,
	Arvin Wang <arvin.wang@mediatek.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org,
	Georgi Djakov <georgi.djakov@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V5 15/17] regulator: Regulator driver for the Mediatek DVFSRC
Date: Tue, 15 Sep 2020 11:44:55 +0800	[thread overview]
Message-ID: <1600141495.20512.5.camel@mtksdaap41> (raw)
In-Reply-To: <20200914123444.GE4821@sirena.org.uk>

Hi Mark,

Thank you for reviewing.

On Mon, 2020-09-14 at 13:34 +0100, Mark Brown wrote:
> On Mon, Sep 14, 2020 at 11:04:42AM +0800, Henry Chen wrote:
> 
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2019 MediaTek Inc.
> > + */
> 
> Please make the entire comment a C++ one so things look more
> intentional, and are you sure about that copyright date?
Ok, it will be modified on next version.
> 
> > +static int dvfsrc_set_voltage_sel(struct regulator_dev *rdev,
> > +				  unsigned int selector)
> > +{
> > +	struct device *dvfsrc_dev = to_dvfsrc_dev(rdev);
> > +	int id = rdev_get_id(rdev);
> > +
> > +	switch (id) {
> > +	case DVFSRC_ID_VCORE:
> > +		mtk_dvfsrc_send_request(dvfsrc_dev,
> > +					MTK_DVFSRC_CMD_VCORE_REQUEST,
> > +					selector);
> > +	break;
> > +	case DVFSRC_ID_VSCP:
> > +		mtk_dvfsrc_send_request(dvfsrc_dev,
> > +					MTK_DVFSRC_CMD_VSCP_REQUEST,
> > +					selector);
> > +	break;
> 
> Just have two separate operations rather than the switch statement, and
> where you do have switch statements please follow the kernel coding
> style.

Ok, it will be modified on next version.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-15  3:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14  3:04 [PATCH V5 00/17] Add driver for dvfsrc, support for active state of scpsys Henry Chen
2020-09-14  3:04 ` [PATCH V5 01/17] dt-bindings: soc: Add dvfsrc driver bindings Henry Chen
2020-09-22 23:14   ` Rob Herring
2020-09-14  3:04 ` [PATCH V5 02/17] dt-bindings: soc: Add opp table on scpsys bindings Henry Chen
2020-09-14  3:04 ` [PATCH V5 03/17] soc: mediatek: add support for the performance state Henry Chen
2020-09-14  3:04 ` [PATCH V5 04/17] arm64: dts: mt8183: add performance state support of scpsys Henry Chen
2020-09-14  3:04 ` [PATCH V5 05/17] soc: mediatek: add header for mediatek SIP interface Henry Chen
2020-09-14  3:04 ` [PATCH V5 06/17] soc: mediatek: add driver for dvfsrc support Henry Chen
2020-09-14  3:04 ` [PATCH V5 07/17] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2020-09-14  3:04 ` [PATCH V5 08/17] arm64: dts: mt8192: " Henry Chen
2020-09-14  3:04 ` [PATCH V5 09/17] dt-bindings: interconnect: add MT8183 interconnect dt-bindings Henry Chen
2020-09-14  3:04 ` [PATCH V5 10/17] dt-bindings: interconnect: add MT6873 " Henry Chen
2020-09-14  3:04 ` [PATCH V5 11/17] interconnect: mediatek: Add interconnect provider driver Henry Chen
2020-09-14  3:04 ` [PATCH V5 12/17] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2020-09-14  3:04 ` [PATCH V5 13/17] arm64: dts: mt8192: " Henry Chen
2020-09-14  3:04 ` [PATCH V5 14/17] dt-bindings: regulator: add DVFSRC regulator dt-bindings Henry Chen
2020-09-14 12:32   ` Mark Brown
2020-09-15  3:39     ` Henry Chen
2020-09-14  3:04 ` [PATCH V5 15/17] regulator: Regulator driver for the Mediatek DVFSRC Henry Chen
2020-09-14 12:34   ` Mark Brown
2020-09-15  3:44     ` Henry Chen [this message]
2020-09-14  3:04 ` [PATCH V5 16/17] arm64: dts: mt8183: add dvfsrc regulator nodes Henry Chen
2020-09-14  3:04 ` [PATCH V5 17/17] arm64: dts: mt8192: " Henry Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1600141495.20512.5.camel@mtksdaap41 \
    --to=henryc.chen@mediatek.com \
    --cc=arvin.wang@mediatek.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drinkcat@google.com \
    --cc=fan.chen@mediatek.com \
    --cc=georgi.djakov@linaro.org \
    --cc=jamesjj.liao@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=ryandcase@chromium.org \
    --cc=swboyd@chromium.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).