From: Landen Chao <landen.chao@mediatek.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Sean Wang <Sean.Wang@mediatek.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] net: dsa: mt7530: Add some return-value checks
Date: Thu, 24 Sep 2020 21:25:34 +0800 [thread overview]
Message-ID: <1600953934.19244.2.camel@mtksdccf07> (raw)
In-Reply-To: <9db38be8-9926-b74b-c860-018486b17f3a@gmail.com>
On Thu, 2020-09-24 at 14:11 +0100, Alex Dewar wrote:
> On 2020-09-24 13:13, Landen Chao wrote:
> > Hi Alex,
> >
> > Thanks for your patch. By linux/scripts/checkpatch.pl
> >
> > On Sun, 2020-09-20 at 03:28 +0800, Alex Dewar wrote:
> > [..]
> >> @@ -1631,9 +1635,11 @@ mt7530_setup(struct dsa_switch *ds)
> >> mt7530_rmw(priv, MT7530_PCR_P(i), PCR_MATRIX_MASK,
> >> PCR_MATRIX_CLR);
> >>
> >> - if (dsa_is_cpu_port(ds, i))
> >> - mt753x_cpu_port_enable(ds, i);
> >> - else
> >> + if (dsa_is_cpu_port(ds, i)) {
> >> + ret = mt753x_cpu_port_enable(ds, i);
> >> + if (ret)
> >> + return ret;
> >> + } else
> >> mt7530_port_disable(ds, i);
> > CHECK: braces {} should be used on all arms of this statement
> > CHECK: Unbalanced braces around else statement
> >>
> >> /* Enable consistent egress tag */
> >> @@ -1785,9 +1791,11 @@ mt7531_setup(struct dsa_switch *ds)
> >>
> >> mt7530_set(priv, MT7531_DBG_CNT(i), MT7531_DIS_CLR);
> >>
> >> - if (dsa_is_cpu_port(ds, i))
> >> - mt753x_cpu_port_enable(ds, i);
> >> - else
> >> + if (dsa_is_cpu_port(ds, i)) {
> >> + ret = mt753x_cpu_port_enable(ds, i);
> >> + if (ret)
> >> + return ret;
> >> + } else
> >> mt7530_port_disable(ds, i);
> > CHECK: braces {} should be used on all arms of this statement
> > CHECK: Unbalanced braces around else statement
> >
> > [..]
> > regards landen
> Hi Landen,
>
> Sorry about this... I usually run checkpatch over my patches. Would you
> like me to send a separate fix or a v3?
>
> Best,
> Alex
Hi Alex,
Because v2 has not been merged yet, could you help to fix it in v3?
regards landen
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-24 13:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 19:50 [PATCH] net: dsa: mt7530: Add some return-value checks Alex Dewar
2020-09-16 20:10 ` Gustavo A. R. Silva
2020-09-16 21:22 ` Alex Dewar
2020-09-16 21:23 ` Alex Dewar
2020-09-17 7:32 ` Landen Chao
2020-09-19 19:28 ` [PATCH v2] " Alex Dewar
2020-09-24 12:13 ` Landen Chao
2020-09-24 13:11 ` Alex Dewar
2020-09-24 13:25 ` Landen Chao [this message]
2020-09-24 14:05 ` [PATCH v3] " Alex Dewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600953934.19244.2.camel@mtksdccf07 \
--to=landen.chao@mediatek.com \
--cc=Sean.Wang@mediatek.com \
--cc=alex.dewar90@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).