* [PATCH 0/3] Convert QCOM watchdog timer bindings to YAML
@ 2019-12-13 4:53 Sai Prakash Ranjan
2019-12-13 4:53 ` [PATCH 1/3] dt-bindings: watchdog: " Sai Prakash Ranjan
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Sai Prakash Ranjan @ 2019-12-13 4:53 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Douglas Anderson, Rob Herring,
Guenter Roeck, devicetree
Cc: Sai Prakash Ranjan, linux-arm-msm, linux-kernel, Stephen Boyd,
Matthias Kaehlcke, linux-arm-kernel
This series converts QCOM watchdog timer bindings to YAML. Also
it adds the missing SoC-specific compatible for QCS404, SC7180,
SDM845 and SM8150 SoCs.
Sai Prakash Ranjan (3):
dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845,
SM8150
arm64: dts: qcom: qcs404: Update the compatible for watchdog timer
.../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ---------
.../bindings/watchdog/qcom-wdt.yaml | 59 +++++++++++++++++++
arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
3 files changed, 60 insertions(+), 29 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
2019-12-13 4:53 [PATCH 0/3] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
@ 2019-12-13 4:53 ` Sai Prakash Ranjan
2019-12-19 23:26 ` Rob Herring
2019-12-13 4:53 ` [PATCH 2/3] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
2019-12-13 4:53 ` [PATCH 3/3] arm64: dts: qcom: qcs404: Update the compatible for watchdog timer Sai Prakash Ranjan
2 siblings, 1 reply; 9+ messages in thread
From: Sai Prakash Ranjan @ 2019-12-13 4:53 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Douglas Anderson, Rob Herring,
Guenter Roeck, devicetree
Cc: Sai Prakash Ranjan, linux-arm-msm, linux-kernel, Stephen Boyd,
Matthias Kaehlcke, linux-arm-kernel
Convert QCOM watchdog timer bindings to DT schema format using
json-schema.
Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
---
.../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
.../bindings/watchdog/qcom-wdt.yaml | 47 +++++++++++++++++++
2 files changed, 47 insertions(+), 28 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
deleted file mode 100644
index 41aeaa2ff0f8..000000000000
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Qualcomm Krait Processor Sub-system (KPSS) Watchdog
----------------------------------------------------
-
-Required properties :
-- compatible : shall contain only one of the following:
-
- "qcom,kpss-wdt-msm8960"
- "qcom,kpss-wdt-apq8064"
- "qcom,kpss-wdt-ipq8064"
- "qcom,kpss-wdt-ipq4019"
- "qcom,kpss-timer"
- "qcom,scss-timer"
- "qcom,kpss-wdt"
-
-- reg : shall contain base register location and length
-- clocks : shall contain the input clock
-
-Optional properties :
-- timeout-sec : shall contain the default watchdog timeout in seconds,
- if unset, the default timeout is 30 seconds
-
-Example:
- watchdog@208a038 {
- compatible = "qcom,kpss-wdt-ipq8064";
- reg = <0x0208a038 0x40>;
- clocks = <&sleep_clk>;
- timeout-sec = <10>;
- };
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
new file mode 100644
index 000000000000..4a42f4261322
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
+
+maintainers:
+ - Andy Gross <agross@kernel.org>
+
+properties:
+ compatible:
+ oneOf:
+ - const: qcom,kpss-timer
+ - const: qcom,kpss-wdt
+ - const: qcom,kpss-wdt-apq8064
+ - const: qcom,kpss-wdt-ipq4019
+ - const: qcom,kpss-wdt-ipq8064
+ - const: qcom,kpss-wdt-msm8960
+ - const: qcom,scss-timer
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ timeout-sec:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Contains the watchdog timeout in seconds. If unset, the
+ default timeout is 30 seconds.
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+examples:
+ - |
+ watchdog@208a038 {
+ compatible = "qcom,kpss-wdt-ipq8064";
+ reg = <0x0208a038 0x40>;
+ clocks = <&sleep_clk>;
+ timeout-sec = <10>;
+ };
---
I have added Andy as the maintainer here since the get_maintainer script
showed him. If he is not happy, then I can change it to Bjorn probably and
again if he is not happy ;-) then I will add myself or whoever they suggest.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/3] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150
2019-12-13 4:53 [PATCH 0/3] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
2019-12-13 4:53 ` [PATCH 1/3] dt-bindings: watchdog: " Sai Prakash Ranjan
@ 2019-12-13 4:53 ` Sai Prakash Ranjan
2019-12-19 23:28 ` Rob Herring
2019-12-13 4:53 ` [PATCH 3/3] arm64: dts: qcom: qcs404: Update the compatible for watchdog timer Sai Prakash Ranjan
2 siblings, 1 reply; 9+ messages in thread
From: Sai Prakash Ranjan @ 2019-12-13 4:53 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Douglas Anderson, Rob Herring,
Guenter Roeck, devicetree
Cc: Sai Prakash Ranjan, linux-arm-msm, linux-kernel, Stephen Boyd,
Matthias Kaehlcke, linux-arm-kernel
Add missing compatible for watchdog timer on QCS404,
SC7180, SDM845 and SM8150 SoCs.
Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
---
.../devicetree/bindings/watchdog/qcom-wdt.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
index 4a42f4261322..ec25ce1c9e2e 100644
--- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
@@ -12,6 +12,18 @@ maintainers:
properties:
compatible:
oneOf:
+ - items:
+ - const: qcom,apss-wdt-sc7180
+ - const: qcom,kpss-wdt
+ - items:
+ - const: qcom,apss-wdt-sdm845
+ - const: qcom,kpss-wdt
+ - items:
+ - const: qcom,apss-wdt-sm8150
+ - const: qcom,kpss-wdt
+ - items:
+ - const: qcom,apss-wdt-qcs404
+ - const: qcom,kpss-wdt
- const: qcom,kpss-timer
- const: qcom,kpss-wdt
- const: qcom,kpss-wdt-apq8064
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: qcs404: Update the compatible for watchdog timer
2019-12-13 4:53 [PATCH 0/3] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
2019-12-13 4:53 ` [PATCH 1/3] dt-bindings: watchdog: " Sai Prakash Ranjan
2019-12-13 4:53 ` [PATCH 2/3] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
@ 2019-12-13 4:53 ` Sai Prakash Ranjan
2019-12-20 0:40 ` Bjorn Andersson
2 siblings, 1 reply; 9+ messages in thread
From: Sai Prakash Ranjan @ 2019-12-13 4:53 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Douglas Anderson, Rob Herring,
Guenter Roeck, devicetree
Cc: Sai Prakash Ranjan, linux-arm-msm, linux-kernel, Stephen Boyd,
Matthias Kaehlcke, linux-arm-kernel
Update the compatible for QCS404 watchdog timer with proper
SoC specific compatible.
Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index f5f0c4c9cb16..c9e8e629045b 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -905,7 +905,7 @@
};
watchdog@b017000 {
- compatible = "qcom,kpss-wdt";
+ compatible = "qcom,apss-wdt-qcs404", "qcom,kpss-wdt";
reg = <0x0b017000 0x1000>;
clocks = <&sleep_clk>;
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
2019-12-13 4:53 ` [PATCH 1/3] dt-bindings: watchdog: " Sai Prakash Ranjan
@ 2019-12-19 23:26 ` Rob Herring
2020-01-13 5:49 ` Sai Prakash Ranjan
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2019-12-19 23:26 UTC (permalink / raw)
To: Sai Prakash Ranjan
Cc: devicetree, linux-kernel, Douglas Anderson, Stephen Boyd,
Andy Gross, linux-arm-kernel, linux-arm-msm, Bjorn Andersson,
Matthias Kaehlcke, Guenter Roeck
On Fri, Dec 13, 2019 at 10:23:18AM +0530, Sai Prakash Ranjan wrote:
> Convert QCOM watchdog timer bindings to DT schema format using
> json-schema.
>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
> .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
> .../bindings/watchdog/qcom-wdt.yaml | 47 +++++++++++++++++++
> 2 files changed, 47 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> new file mode 100644
> index 000000000000..4a42f4261322
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
> +
> +maintainers:
> + - Andy Gross <agross@kernel.org>
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: qcom,kpss-timer
> + - const: qcom,kpss-wdt
> + - const: qcom,kpss-wdt-apq8064
> + - const: qcom,kpss-wdt-ipq4019
> + - const: qcom,kpss-wdt-ipq8064
> + - const: qcom,kpss-wdt-msm8960
> + - const: qcom,scss-timer
An 'enum' is better than oneOf+const.
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + timeout-sec:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Contains the watchdog timeout in seconds. If unset, the
> + default timeout is 30 seconds.
Include watchdog.yaml and don't redefine this.
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +examples:
> + - |
> + watchdog@208a038 {
> + compatible = "qcom,kpss-wdt-ipq8064";
> + reg = <0x0208a038 0x40>;
> + clocks = <&sleep_clk>;
> + timeout-sec = <10>;
> + };
> ---
>
> I have added Andy as the maintainer here since the get_maintainer script
> showed him. If he is not happy, then I can change it to Bjorn probably and
> again if he is not happy ;-) then I will add myself or whoever they suggest.
Add yourself.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150
2019-12-13 4:53 ` [PATCH 2/3] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
@ 2019-12-19 23:28 ` Rob Herring
2020-01-13 5:47 ` Sai Prakash Ranjan
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2019-12-19 23:28 UTC (permalink / raw)
To: Sai Prakash Ranjan
Cc: devicetree, linux-kernel, Douglas Anderson, Stephen Boyd,
Andy Gross, linux-arm-kernel, linux-arm-msm, Bjorn Andersson,
Matthias Kaehlcke, Guenter Roeck
On Fri, Dec 13, 2019 at 10:23:19AM +0530, Sai Prakash Ranjan wrote:
> Add missing compatible for watchdog timer on QCS404,
> SC7180, SDM845 and SM8150 SoCs.
>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
> .../devicetree/bindings/watchdog/qcom-wdt.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> index 4a42f4261322..ec25ce1c9e2e 100644
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -12,6 +12,18 @@ maintainers:
> properties:
> compatible:
> oneOf:
> + - items:
> + - const: qcom,apss-wdt-sc7180
> + - const: qcom,kpss-wdt
> + - items:
> + - const: qcom,apss-wdt-sdm845
> + - const: qcom,kpss-wdt
> + - items:
> + - const: qcom,apss-wdt-sm8150
> + - const: qcom,kpss-wdt
> + - items:
> + - const: qcom,apss-wdt-qcs404
> + - const: qcom,kpss-wdt
This can be one entry:
- items:
- enum:
- ...
- const: qcom,kpss-wdt
> - const: qcom,kpss-timer
> - const: qcom,kpss-wdt
> - const: qcom,kpss-wdt-apq8064
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: qcs404: Update the compatible for watchdog timer
2019-12-13 4:53 ` [PATCH 3/3] arm64: dts: qcom: qcs404: Update the compatible for watchdog timer Sai Prakash Ranjan
@ 2019-12-20 0:40 ` Bjorn Andersson
0 siblings, 0 replies; 9+ messages in thread
From: Bjorn Andersson @ 2019-12-20 0:40 UTC (permalink / raw)
To: Sai Prakash Ranjan
Cc: devicetree, linux-kernel, Douglas Anderson, Rob Herring,
Stephen Boyd, Andy Gross, linux-arm-kernel, linux-arm-msm,
Matthias Kaehlcke, Guenter Roeck
On Thu 12 Dec 20:53 PST 2019, Sai Prakash Ranjan wrote:
> Update the compatible for QCS404 watchdog timer with proper
> SoC specific compatible.
>
Applied
Thanks,
Bjorn
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index f5f0c4c9cb16..c9e8e629045b 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -905,7 +905,7 @@
> };
>
> watchdog@b017000 {
> - compatible = "qcom,kpss-wdt";
> + compatible = "qcom,apss-wdt-qcs404", "qcom,kpss-wdt";
> reg = <0x0b017000 0x1000>;
> clocks = <&sleep_clk>;
> };
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150
2019-12-19 23:28 ` Rob Herring
@ 2020-01-13 5:47 ` Sai Prakash Ranjan
0 siblings, 0 replies; 9+ messages in thread
From: Sai Prakash Ranjan @ 2020-01-13 5:47 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-kernel, Douglas Anderson, Stephen Boyd,
Andy Gross, linux-arm-kernel, linux-arm-msm, Bjorn Andersson,
Matthias Kaehlcke, Guenter Roeck
Hi Rob,
On 2019-12-20 04:58, Rob Herring wrote:
> On Fri, Dec 13, 2019 at 10:23:19AM +0530, Sai Prakash Ranjan wrote:
>> Add missing compatible for watchdog timer on QCS404,
>> SC7180, SDM845 and SM8150 SoCs.
>>
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>> .../devicetree/bindings/watchdog/qcom-wdt.yaml | 12
>> ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> index 4a42f4261322..ec25ce1c9e2e 100644
>> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> @@ -12,6 +12,18 @@ maintainers:
>> properties:
>> compatible:
>> oneOf:
>> + - items:
>> + - const: qcom,apss-wdt-sc7180
>> + - const: qcom,kpss-wdt
>> + - items:
>> + - const: qcom,apss-wdt-sdm845
>> + - const: qcom,kpss-wdt
>> + - items:
>> + - const: qcom,apss-wdt-sm8150
>> + - const: qcom,kpss-wdt
>> + - items:
>> + - const: qcom,apss-wdt-qcs404
>> + - const: qcom,kpss-wdt
>
> This can be one entry:
>
> - items:
> - enum:
> - ...
> - const: qcom,kpss-wdt
>
Will change in next version.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/3] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML
2019-12-19 23:26 ` Rob Herring
@ 2020-01-13 5:49 ` Sai Prakash Ranjan
0 siblings, 0 replies; 9+ messages in thread
From: Sai Prakash Ranjan @ 2020-01-13 5:49 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, linux-arm-msm-owner, linux-kernel, Douglas Anderson,
Stephen Boyd, Andy Gross, linux-arm-kernel, linux-arm-msm,
Bjorn Andersson, Matthias Kaehlcke, Guenter Roeck
On 2019-12-20 04:56, Rob Herring wrote:
> On Fri, Dec 13, 2019 at 10:23:18AM +0530, Sai Prakash Ranjan wrote:
>> Convert QCOM watchdog timer bindings to DT schema format using
>> json-schema.
>>
>> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
>> ---
>> .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 -----------
>> .../bindings/watchdog/qcom-wdt.yaml | 47
>> +++++++++++++++++++
>> 2 files changed, 47 insertions(+), 28 deletions(-)
>> delete mode 100644
>> Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
>> create mode 100644
>> Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>
>
>> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> new file mode 100644
>> index 000000000000..4a42f4261322
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>> @@ -0,0 +1,47 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
>> +
>> +maintainers:
>> + - Andy Gross <agross@kernel.org>
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - const: qcom,kpss-timer
>> + - const: qcom,kpss-wdt
>> + - const: qcom,kpss-wdt-apq8064
>> + - const: qcom,kpss-wdt-ipq4019
>> + - const: qcom,kpss-wdt-ipq8064
>> + - const: qcom,kpss-wdt-msm8960
>> + - const: qcom,scss-timer
>
> An 'enum' is better than oneOf+const.
>
Will change.
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + timeout-sec:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description:
>> + Contains the watchdog timeout in seconds. If unset, the
>> + default timeout is 30 seconds.
>
> Include watchdog.yaml and don't redefine this.
>
Ok
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - clocks
>> +
>> +examples:
>> + - |
>> + watchdog@208a038 {
>> + compatible = "qcom,kpss-wdt-ipq8064";
>> + reg = <0x0208a038 0x40>;
>> + clocks = <&sleep_clk>;
>> + timeout-sec = <10>;
>> + };
>> ---
>>
>> I have added Andy as the maintainer here since the get_maintainer
>> script
>> showed him. If he is not happy, then I can change it to Bjorn probably
>> and
>> again if he is not happy ;-) then I will add myself or whoever they
>> suggest.
>
> Add yourself.
>
Sure will add myself.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-01-13 5:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 4:53 [PATCH 0/3] Convert QCOM watchdog timer bindings to YAML Sai Prakash Ranjan
2019-12-13 4:53 ` [PATCH 1/3] dt-bindings: watchdog: " Sai Prakash Ranjan
2019-12-19 23:26 ` Rob Herring
2020-01-13 5:49 ` Sai Prakash Ranjan
2019-12-13 4:53 ` [PATCH 2/3] dt-bindings: watchdog: Add compatible for QCS404, SC7180, SDM845, SM8150 Sai Prakash Ranjan
2019-12-19 23:28 ` Rob Herring
2020-01-13 5:47 ` Sai Prakash Ranjan
2019-12-13 4:53 ` [PATCH 3/3] arm64: dts: qcom: qcs404: Update the compatible for watchdog timer Sai Prakash Ranjan
2019-12-20 0:40 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).