From: Stephen Boyd <sboyd@kernel.org>
To: Jernej Skrabec <jernej.skrabec@siol.net>,
mripard@kernel.org, wens@csie.org
Cc: airlied@linux.ie, mturquette@baylibre.com,
Andre Heider <a.heider@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-sunxi@googlegroups.com, daniel@ffwll.ch,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/5] clk: sunxi-ng: mp: fix parent rate change flag check
Date: Mon, 08 Feb 2021 11:21:21 -0800 [thread overview]
Message-ID: <161281208140.76967.6089044756544560133@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210208121752.2255465-2-jernej.skrabec@siol.net>
Quoting Jernej Skrabec (2021-02-08 04:17:48)
> CLK_SET_RATE_PARENT flag is checked on parent clock instead of current
> one. Fix that.
>
> Fixes: 3f790433c3cb ("clk: sunxi-ng: Adjust MP clock parent rate when allowed")
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Tested-by: Andre Heider <a.heider@gmail.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> ---
> drivers/clk/sunxi-ng/ccu_mp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/sunxi-ng/ccu_mp.c b/drivers/clk/sunxi-ng/ccu_mp.c
> index fa4ecb915590..5f40be6d2dfd 100644
> --- a/drivers/clk/sunxi-ng/ccu_mp.c
> +++ b/drivers/clk/sunxi-ng/ccu_mp.c
> @@ -108,7 +108,7 @@ static unsigned long ccu_mp_round_rate(struct ccu_mux_internal *mux,
> max_m = cmp->m.max ?: 1 << cmp->m.width;
> max_p = cmp->p.max ?: 1 << ((1 << cmp->p.width) - 1);
>
> - if (!(clk_hw_get_flags(hw) & CLK_SET_RATE_PARENT)) {
> + if (!(clk_hw_get_flags(&cmp->common.hw) & CLK_SET_RATE_PARENT)) {
This is also clk_hw_can_set_rate_parent()
> ccu_mp_find_best(*parent_rate, rate, max_m, max_p, &m, &p);
> rate = *parent_rate / p / m;
> } else {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-08 19:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 12:17 [PATCH v2 0/5] sunxi: fix H6 HDMI related issues Jernej Skrabec
2021-02-08 12:17 ` [PATCH v2 1/5] clk: sunxi-ng: mp: fix parent rate change flag check Jernej Skrabec
2021-02-08 19:21 ` Stephen Boyd [this message]
2021-02-08 12:17 ` [PATCH v2 2/5] drm/sun4i: tcon: set sync polarity for tcon1 channel Jernej Skrabec
2021-02-08 12:17 ` [PATCH v2 3/5] drm/sun4i: dw-hdmi: always set clock rate Jernej Skrabec
2021-02-08 12:17 ` [PATCH v2 4/5] drm/sun4i: Fix H6 HDMI PHY configuration Jernej Skrabec
2021-02-08 12:17 ` [PATCH v2 5/5] drm/sun4i: dw-hdmi: Fix max. frequency for H6 Jernej Skrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161281208140.76967.6089044756544560133@swboyd.mtv.corp.google.com \
--to=sboyd@kernel.org \
--cc=a.heider@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=mturquette@baylibre.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).