From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A21BDC433DB for ; Fri, 12 Feb 2021 21:03:32 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5085264E05 for ; Fri, 12 Feb 2021 21:03:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5085264E05 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=SGqhnh7iBvmkaP+z6Q6DkfHQ3SdY4qBENMwMmCbMnl0=; b=OYvYFH4G7QudEnBGel75jBGbo a5vcfV0KdC2WbkjuR0fL570s9YnLqgBkiEqkho6B/aFhoN41KTZ/9w2yuzoCah1R0i05v6jlflkmf LEzUAeFUlZZg28aEwJfqiGU4JeoFgYcudQDRB8JVK9j/4xu53LNr1bw47Hjoma0Oi86LvQ0XGXt+1 W8MJzGWNgdWWw2Sec6WwgI8vQXzpTgraHfx0tkWvS+LXWLhW7SqQNoUAhHnq9Njk1fBw1jCNjaLBj yzUFc6Ms9VVfuoTrxWJ6L4KcrgNhFm+nXPQJ0AemmbrEATSGiCzIMg90btHtK/KNQA47hwQ3mPSWb eHY9498zw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAfa6-0001Zn-Mi; Fri, 12 Feb 2021 21:02:26 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lAfa3-0001Z9-MI for linux-arm-kernel@lists.infradead.org; Fri, 12 Feb 2021 21:02:24 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 77F8864E05; Fri, 12 Feb 2021 21:02:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1613163742; bh=W+5rNCA1AtqnGKfforyDrX1jEmPAq1AoeUYShAARidk=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=L8vv2t4t8eAuoCqn8NxiLKXPHOLn2qbZG/rTldBEck1qE3UJ9ZQgBMmDyAS+LCWPW EzmQrYymjIjWzdM9L/7FXHZGGuj4mL3xtQEcEf8CqaYplO6L5RYs8XX06VCEcsrfdR DnZefkSwJ3C/7GBHqDkPzplqR/1x05jRlJKJ6qT2qfEMeI8gZgeYtGj7iTUFb1gaWJ 0ewKJtGcnZgMY3nAWLZLIyhSM+nXjoN/Oz5tcLNPp2ONVxpr8E+MxgzJz7ExgeG7/5 lQhWIt1CShxke8FA18oo80Hy1k04ysgkM9gd+JOi/WRC9EeZrRZTWgw/1ZKPKae8Jz RI+6N32IPbIKg== MIME-Version: 1.0 In-Reply-To: <20210212092016.GF4572@dell> References: <20210126124540.3320214-1-lee.jones@linaro.org> <161307643148.1254594.6590013599999468609@swboyd.mtv.corp.google.com> <20210211211054.GD4572@dell> <161309925025.1254594.6210738031889810500@swboyd.mtv.corp.google.com> <20210212092016.GF4572@dell> Subject: Re: [PATCH 00/21] [Set 2] Rid W=1 warnings from Clock From: Stephen Boyd To: Lee Jones Date: Fri, 12 Feb 2021 13:02:21 -0800 Message-ID: <161316374113.1254594.14156657225822268891@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210212_160223_853276_4C79C94C X-CRM114-Status: GOOD ( 19.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Prashant Gaikwad , Tomer Maimon , Geert Uytterhoeven , Michael Turquette , Bjorn Andersson , Rajeev Kumar , Jan Kotas , Russell King , Fabio Estevam , linux-clk@vger.kernel.org, Boris BREZILLON , Ahmad Fatoum , Benjamin Fair , Emilio =?utf-8?q?L=C3=B3pez?= , Viresh Kumar , openbmc@lists.ozlabs.org, Michal Simek , Jonathan Hunter , Nancy Yuen , Chen-Yu Tsai , Andy Gross , Loc Ho , NXP Linux Team , Richard Woodruff , Tali Perry , Philipp Zabel , linux-arm-msm@vger.kernel.org, Sascha Hauer , Maxime Ripard , linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, Shiraz Hashim , linux-arm-kernel@lists.infradead.org, =?utf-8?q?S=C3=B6ren?= Brinkmann , Jernej Skrabec , Tero Kristo , Rajan Vaja , Avi Fishman , Patrick Venture , Peter De Schrijver , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Nuvoton Technologies , Thierry Reding , Pengutronix Kernel Team , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Lee Jones (2021-02-12 01:20:16) > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > Quoting Lee Jones (2021-02-11 13:10:54) > > > On Thu, 11 Feb 2021, Stephen Boyd wrote: > > > > > > > Quoting Lee Jones (2021-01-26 04:45:19) > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > niggly little warnings. > > > > > > > > > > This is the last set. Clock is clean after this. > > > > > > > > Is it possible to slam in some patch that makes W=1 the default for the > > > > clk directory? I'm trying to avoid seeing this patch series again. > > > > > > One of my main goals of this project is that everyone (contributors, > > > maintainers auto-builder robots etc) will be enabling W=1 builds > > > *locally*. > > > > > > This isn't something you'll want to do at a global (i.e. in Mainline) > > > level. That's kinda the point of W=1. > > > > > > > Agreed, but is it possible to pass W=1 in the drivers/clk/Makefile? > > That would circumvent the point of W=1. Level-1 warnings are deemed, > and I'm paraphrasing/making this up "not worth rejecting pull-requests > over". In contrast, if Linus catches any W=0 warnings at pull-time, > he will reject the pull-request as 'untested'. > > W=1 is defiantly something you'll want to enable locally though, and > subsequently push back on contributors submitting code adding new > ones. > Why should I install a land mine for others to trip over? Won't that just take them more time because they won't know to compile with W=1 and then will have to go for another round of review while I push back on them submitting new warnings? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel