linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Cc: Daniel Palmer <daniel@0x0f.com>
Subject: Re: [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested
Date: Tue, 16 Feb 2021 12:54:14 -0800	[thread overview]
Message-ID: <161350885409.1254594.4380070292122043991@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <20210215115710.3762276-1-daniel@0x0f.com>

Quoting Daniel Palmer (2021-02-15 03:57:09)
> Allow COMPILE_TEST to also build the MStar clk drivers
> instead of only building them when ARCH_MSTARV7 is selected.
> 
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> Suggested-by: Stephen Boyd <sboyd@kernel.org>
> ---
>  drivers/clk/Makefile      | 2 +-
>  drivers/clk/mstar/Kconfig | 7 ++++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile
> index 7fed7e5944cd..e5e23a44fbe9 100644
> --- a/drivers/clk/Makefile
> +++ b/drivers/clk/Makefile
> @@ -95,7 +95,7 @@ obj-$(CONFIG_MACH_PIC32)              += microchip/
>  ifeq ($(CONFIG_COMMON_CLK), y)
>  obj-$(CONFIG_ARCH_MMP)                 += mmp/
>  endif
> -obj-$(CONFIG_ARCH_MSTARV7)             += mstar/
> +obj-y                                  += mstar/
>  obj-y                                  += mvebu/
>  obj-$(CONFIG_ARCH_MXS)                 += mxs/
>  obj-$(CONFIG_COMMON_CLK_NXP)           += nxp/
> diff --git a/drivers/clk/mstar/Kconfig b/drivers/clk/mstar/Kconfig
> index 23765edde3af..eab8f7dcaa90 100644
> --- a/drivers/clk/mstar/Kconfig
> +++ b/drivers/clk/mstar/Kconfig
> @@ -1,5 +1,10 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config MSTAR_MSC313_MPLL
> -       bool
> +       bool "MStar MPLL driver"
> +       depends on ARCH_MSTARV7 || COMPILE_TEST
> +       default ARCH_MSTARV7
>         select REGMAP

I've also removed this select REGMAP. It isn't necessary as this selects
REGMAP_MMIO.

>         select REGMAP_MMIO
> +       help
> +         Support for the MPLL PLL and dividers block present on
> +         MStar/Sigmastar SoCs.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2021-02-16 20:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15 11:57 [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Daniel Palmer
2021-02-15 11:57 ` [PATCH 2/2] clk: mstar: msc313-mpll: Fix format specifier Daniel Palmer
2021-02-16 20:48   ` Stephen Boyd
2021-02-16 20:48 ` [PATCH 1/2] clk: mstar: Allow MStar clk drivers to be compile tested Stephen Boyd
2021-02-16 20:54 ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=161350885409.1254594.4380070292122043991@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=daniel@0x0f.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).