From: Rob Herring <robh@kernel.org>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Ray Jui <rjui@broadcom.com>, Rob Herring <robh+dt@kernel.org>,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
Neil Armstrong <narmstrong@baylibre.com>,
devicetree@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
linux-rpi-kernel@lists.infradead.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Matt Mackall <mpm@selenic.com>,
Guenter Roeck <linux@roeck-us.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Herbert Xu <herbert@gondor.apana.org.au>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v5 1/2] dt-bindings: rng: bcm2835: document reset support
Date: Thu, 04 Mar 2021 14:47:29 -0600 [thread overview]
Message-ID: <1614890849.112497.2778958.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210304073308.25906-2-noltari@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1254 bytes --]
On Thu, 04 Mar 2021 08:33:07 +0100, Ãlvaro Fernández Rojas wrote:
> Some devices may need to perform a reset before using the RNG, such as the
> BCM6368.
>
> Signed-off-by: Ãlvaro Fernández Rojas <noltari@gmail.com>
> ---
> v5: no changes.
> v4: pass dt_binding_check.
> v3: make resets required if brcm,bcm6368-rng.
> v2: document reset support.
>
> .../devicetree/bindings/rng/brcm,bcm2835.yaml | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.example.dt.yaml: rng@10004180: 'resets' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/rng/brcm,bcm2835.yaml
See https://patchwork.ozlabs.org/patch/1447144
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-04 20:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 7:33 [PATCH v5 0/2] hwrng: bcm2835: add reset support Álvaro Fernández Rojas
2021-03-04 7:33 ` [PATCH v5 1/2] dt-bindings: rng: bcm2835: document " Álvaro Fernández Rojas
2021-03-04 12:08 ` Nicolas Saenz Julienne
2021-03-04 20:47 ` Rob Herring [this message]
2021-03-04 7:33 ` [PATCH v5 2/2] hwrng: bcm2835: add " Álvaro Fernández Rojas
2021-03-04 11:27 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1614890849.112497.2778958.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=alexandru.ardelean@analog.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=mpm@selenic.com \
--cc=narmstrong@baylibre.com \
--cc=noltari@gmail.com \
--cc=nsaenzjulienne@suse.de \
--cc=p.zabel@pengutronix.de \
--cc=rikard.falkeborn@gmail.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).