From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C541C433ED for ; Thu, 8 Apr 2021 01:11:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06B216120E for ; Thu, 8 Apr 2021 01:11:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06B216120E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a1yrLPbRvx8+ayEyzJcLw+LyDDV/zDchHMSrrlUQotQ=; b=BUBB5ruHVdJUsM6sSEmX8Zkt+ REcYtTLWjSm+sgKeLZmE5FurDA7Sjh0VtioX2lsc5/l49VYPYzeSRyP37ET17qKRH9kSS5CfjqE/I trNfPvtzro1p/Fa/HpOQzcWOxKIibOOnsy8+sX98IIPmdL2bDt+37kvPwsB6v66mjkozhSfps+Y0M e48XDMNnae6zqAXw3sQ1BaqeSu6RE3c75/AAgHIHht1Kvq+jDXeKOzzQamVcCnZnIoBW85TKlzUtC FQaCCTqzDES8YQ3HQwWFtwG1qHdpIOoHMbB4lSlJoukzxdVbtRdQZnVNSH19ezlaLkCUS+QgYCidS n96tdsfIw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUJB4-006RVI-LC; Thu, 08 Apr 2021 01:09:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUJAy-006RUo-Es for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 01:09:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 19AE16113A; Thu, 8 Apr 2021 01:09:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617844179; bh=f/xx+JASbd9ZTZFHDhgzyPHyCRkJ2KLQ0QZAD9UJK0I=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=YdL/cbZe3Q+0BzvpVCZX+E2SWw5m+0YzggStnEkEWU+gb/4Md9vaL705I42JJNYVh /M0rK5h8Tw63R/4w3AS1zIvIQjQ7bV8KYBSWJQKHCTOOfN2R1uLwJcqLoU59lMewr2 CSsky2x/UYBtKZXzDECzTJbru9MjXLyfv+QtoKYzJGiTBh+wZoFi7+CLU/SR9pZJ5i lH9OuX9BT0/1TjQBAHzgmlzd8/HcPgVIdPkhkEDh4mdawmuqrRU1seCgYHGiC0iFJw 1m9RotrR+ggjiHwolVVYzEKg9Tgm17er0gxw7cVqRHLxqvvMIprRRPnHnKxGagHPln sbQdizP1tEFCw== MIME-Version: 1.0 In-Reply-To: <20210406153131.601701-1-quanyang.wang@windriver.com> References: <20210406153131.601701-1-quanyang.wang@windriver.com> Subject: Re: [V3][PATCH] clk: zynqmp: pll: add set_pll_mode to check condition in zynqmp_pll_enable From: Stephen Boyd Cc: Rajan Vaja , Jolly Shah , Greg Kroah-Hartman , Quanyang Wang , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org To: Laurent Pinchart , Michael Turquette , Michal Simek , quanyang.wang@windriver.com Date: Wed, 07 Apr 2021 18:09:37 -0700 Message-ID: <161784417793.3790633.1172679818900674783@swboyd.mtv.corp.google.com> User-Agent: alot/0.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_020940_711290_FA7C40BA X-CRM114-Status: GOOD ( 14.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting quanyang.wang@windriver.com (2021-04-06 08:31:31) > From: Quanyang Wang > > If there is a IOCTL_SET_PLL_FRAC_MODE request sent to ATF ever, > we shouldn't skip invoking PM_CLOCK_ENABLE fn even though this > pll has been enabled. In ATF implementation, it will only assign > the mode to the variable (struct pm_pll *)pll->mode when handling > IOCTL_SET_PLL_FRAC_MODE call. Invoking PM_CLOCK_ENABLE can force > ATF send request to PWU to set the pll mode to PLL's register. > > There is a scenario that happens in enabling VPLL_INT(clk_id:96): > 1) VPLL_INT has been enabled during booting. > 2) A driver calls clk_set_rate and according to the rate, the VPLL_INT > should be set to FRAC mode. Then zynqmp_pll_set_mode is called > to pass IOCTL_SET_PLL_FRAC_MODE to ATF. Note that at this point > ATF just stores the mode to a variable. > 3) This driver calls clk_prepare_enable and zynqmp_pll_enable is > called to try to enable VPLL_INT pll. Because of 1), the function > zynqmp_pll_enable just returns without doing anything after checking > that this pll has been enabled. > > In the scenario above, the pll mode of VPLL_INT will never be set > successfully. So adding set_pll_mode to check condition to fix it. > > Fixes: 3fde0e16d016 ("drivers: clk: Add ZynqMP clock driver") > Signed-off-by: Quanyang Wang > Tested-by: Laurent Pinchart > --- Applied to clk-next _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel