From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F938C433B4 for ; Thu, 8 Apr 2021 06:22:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 120276113E for ; Thu, 8 Apr 2021 06:22:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 120276113E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qBoxuVAA911Z3GfJe7iGsSeOEI5jgrjYMqAvGj42KwU=; b=EJVnxQ3Dkv/mjm61rmYC6NJPp RZhjho18tWMTu5l8KJBq2jLP53hJF4dkwMljsD3lr/JS1/qo4dk+JhSV4uuCeP26IqiPfj+3BazF2 piCaZKfvZX4j6uxn0pp6P/4t+u5Zpt4aMg/IUdmcgG86RsyERYBUcmzpctXYDWQn9bQlh9udJjhKI IQFbELJrISFMg4WE1NCJOVm3tHhXEqT0uOv1R3rukuiFJ26LaF4AznuqGHFzeWZktFKeuoDucmjMW /DeA3CYB/KOzrMNKRvj44R6Isb6UEtYHkf7v/QC4R7nW/EBFq4sm4tCNCvvKgA32mDj+Ev7tAKr0Y nUUbCnYKw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUO2I-0074f8-TR; Thu, 08 Apr 2021 06:21:04 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUO23-0074cR-Sv; Thu, 08 Apr 2021 06:20:50 +0000 X-UUID: f14f78ab18b74197809a804b1499fa6a-20210407 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Iqf9QrO8MkLePhv/L1kye+La4KwF/Sa5szZLfVp1vXE=; b=uGrvtnauESL2DpUU+LgMHmqNVvwxI7irXCMz56ZHlZaAQdjmzv6iVWhoKWkHUkrYVakMPQdRLJ97ycgVHthbObDIFZAqodj9QLsEm1GWklSt4vTLsRVvuk/Y1mVmLwJkH4w0k7Mg0t/u+5YbTluR1so90+g2ELBdILbpJKFRGxc=; X-UUID: f14f78ab18b74197809a804b1499fa6a-20210407 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1624183550; Wed, 07 Apr 2021 23:20:44 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Apr 2021 23:14:10 -0700 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Apr 2021 14:14:09 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 8 Apr 2021 14:14:09 +0800 Message-ID: <1617862449.8874.16.camel@mtksdccf07> Subject: Re: [PATCH v2 6/6] soc: mediatek: devapc: support mt8192 From: Nina Wu To: Matthias Brugger CC: Rob Herring , Zhen Lei , Neal Liu , , , , , , Date: Thu, 8 Apr 2021 14:14:09 +0800 In-Reply-To: References: <1617259087-5502-1-git-send-email-nina-cm.wu@mediatek.com> <1617259087-5502-6-git-send-email-nina-cm.wu@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_072048_398982_A252A8FE X-CRM114-Status: GOOD ( 20.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Matthias On Tue, 2021-04-06 at 15:55 +0200, Matthias Brugger wrote: > > On 01/04/2021 08:38, Nina Wu wrote: > > From: Nina Wu > > > > Add compatible to support mt8192. > > > > Signed-off-by: Nina Wu > > --- > > > Looks good, I'd like to see DTS for this as well, although I understand it > depends on the clock patch series. Please note so in either below the '---' or > in a cover letter. > > Regards, > Matthias > I will add devapc nodes in DTS in the next version. Thanks > > > drivers/soc/mediatek/mtk-devapc.c | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/drivers/soc/mediatek/mtk-devapc.c b/drivers/soc/mediatek/mtk-devapc.c > > index af55c01..a5c15b5 100644 > > --- a/drivers/soc/mediatek/mtk-devapc.c > > +++ b/drivers/soc/mediatek/mtk-devapc.c > > @@ -251,11 +251,26 @@ static const struct mtk_devapc_data devapc_mt6779 = { > > .vio_shift_con_offset = 0xF20, > > }; > > > > +static const struct mtk_devapc_data devapc_mt8192 = { > > + .vio_mask_offset = 0x0, > > + .vio_sta_offset = 0x400, > > + .vio_dbg0_offset = 0x900, > > + .vio_dbg1_offset = 0x904, > > + .vio_dbg2_offset = 0x908, > > + .apc_con_offset = 0xF00, > > + .vio_shift_sta_offset = 0xF20, > > + .vio_shift_sel_offset = 0xF30, > > + .vio_shift_con_offset = 0xF10, > > +}; > > + > > static const struct of_device_id mtk_devapc_dt_match[] = { > > { > > .compatible = "mediatek,mt6779-devapc", > > .data = &devapc_mt6779, > > }, { > > + .compatible = "mediatek,mt8192-devapc", > > + .data = &devapc_mt8192, > > + }, { > > }, > > }; > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel