From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE98C43461 for ; Wed, 28 Apr 2021 10:05:17 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFB096143E for ; Wed, 28 Apr 2021 10:05:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFB096143E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=61clH/RPFL3PcOmh6pKd0uPNkbyLYBEBE9L11L+8A90=; b=mqVXX8IefBFpt/aYgYxyOGnT1 ObddQZ9bzD35qxx5XATQhSY4m2U023GhYF00oA+6RLsZGmtnDoRmtzYuJGqDNrJa3xJx3XdcbYGgY RmWg2Cmk9RAkefWIzrOA5fAAC2OmKfEjB7l0q1bo7rIb52w6LgELed4/bR62P8ceQtEFDgYp0Efr6 oaQSpeGEd3HojWhFqTl/RYi0ZI9CaA1lhHXZ+2AhriiNJvz8rOxP8K26wdabqNnOzI79k9MHQClNc gIR3nvBC2xOtBHchqJ694OwILKMzydAehCRMjUldn4PJANSvNpLkGFvMQfoCelXz7NG3pEhPDeSvb S5FXM7c5A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbh2V-003FTD-84; Wed, 28 Apr 2021 10:03:27 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbh2O-003FSc-Kc for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 10:03:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Sender:Reply-To:Content-ID:Content-Description; bh=vjr+MbdkHFNP3omOkvmcrJEB1zT8duK13KJTjarnIjs=; b=Z067c+zC7dPiuTWvdK9XY11yiN 2j/+ASRYBG7FWlljHv+nAa3Mp5lJAnZ83LAQ3+b5Rt5cUQOxIZlZEEZA7TolBdVGACstDlaZD7K5/ /sSj94DP7OpvopSF4ii+Sl1lOR67ky6lhbgD7rjRDpQsPKlFw1ePwZbRmW//5dyrfAcY6wQtj5mfb JYpn5IBNnFHqaQx4oIS+u2io19TpfjZ8JAwd9/UFcXaKgIb+KFf/HgOevqOapuCS9Eysn+pEYAs09 AAV1AJXD+4CKMHZhiDOonYLvLqpSt0x1hHiv8iTn0ErJ+76enSwUy85/uiLBxc57ZstQEKqqYVuk6 fUghmoBg==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbh2L-00HLDk-Ql for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 10:03:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D6061FB; Wed, 28 Apr 2021 03:03:17 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1B9E23F70D; Wed, 28 Apr 2021 03:03:16 -0700 (PDT) From: Sudeep Holla To: Dan Carpenter Cc: Sudeep Holla , kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Cristian Marussi , linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scpi: prevent ternary sign expansion bug Date: Wed, 28 Apr 2021 11:03:06 +0100 Message-Id: <161960405992.396847.5531876675862211477.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_030317_930270_88EAF224 X-CRM114-Status: UNSURE ( 9.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 22 Apr 2021 12:02:29 +0300, Dan Carpenter wrote: > How type promotion works in ternary expressions is a bit tricky. > The problem is that scpi_clk_get_val() returns longs, "ret" is a int > which holds a negative error code, and le32_to_cpu() is an unsigned int. > We want the negative error code to be cast to a negative long. But > because le32_to_cpu() is an u32 then "ret" is type promoted to u32 and > becomes a high positive and then it is promoted to long and it is still > a high positive value. > > [...] Applied to sudeep.holla/linux (for-next/scmi), thanks! [1/1] firmware: arm_scpi: prevent ternary sign expansion bug https://git.kernel.org/sudeep.holla/c/d9cd78edb2 -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel