From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, "Ikjoon Jang" <ikjn@chromium.org>,
Eddie Hung <eddie.hung@mediatek.com>
Subject: Re: [PATCH v2 1/3] usb: xhci-mtk: use bitfield instead of bool
Date: Fri, 7 May 2021 09:28:04 +0800 [thread overview]
Message-ID: <1620350884.10796.4.camel@mhfsdcap03> (raw)
In-Reply-To: <a3d1a695-3138-f322-3b4f-5d00e9c85a50@gmail.com>
On Thu, 2021-05-06 at 11:50 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 06.05.2021 9:31, Chunfeng Yun wrote:
>
> > Use bitfield instead of bool in struct
> >
> > Refer to coding-style.rst 17) Using bool:
> > "If a structure has many true/false values, consider consolidating
> > them into a bitfield with 1 bit members, or using an appropriate
> > fixed width type, such as u8."
> >
> > Due to @has_ippc's default vaule is 0, no need set it again if fail
>
> Value. :-)
Will fix it, thanks
>
> > to get ippc base address
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> [...]
>
> MBR, Sergei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-07 1:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 6:31 [PATCH v2 1/3] usb: xhci-mtk: use bitfield instead of bool Chunfeng Yun
2021-05-06 6:31 ` [PATCH v2 2/3] usb: xhci-mtk: remove unnecessary assignments in periodic TT scheduler Chunfeng Yun
2021-05-06 6:31 ` [PATCH v2 3/3] usb: xhci-mtk: use first-fit for LS/FS Chunfeng Yun
2021-05-06 7:37 ` [PATCH v2 1/3] usb: xhci-mtk: use bitfield instead of bool Greg Kroah-Hartman
2021-05-07 1:27 ` Chunfeng Yun
2021-05-06 8:50 ` Sergei Shtylyov
2021-05-07 1:28 ` Chunfeng Yun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620350884.10796.4.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=eddie.hung@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=ikjn@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=sergei.shtylyov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).