linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Jay Fang <f.fangjian@huawei.com>
To: <will@kernel.org>, <mark.rutland@arm.com>
Cc: <linux-arm-kernel@lists.infradead.org>, <linuxarm@huawei.com>,
	<huangdaode@huawei.com>, <hejunhao2@hisilicon.com>
Subject: [PATCH 1/4] drivers/perf: arm_spe_pmu: Fix some coding style issues
Date: Tue, 11 May 2021 20:27:31 +0800	[thread overview]
Message-ID: <1620736054-58412-2-git-send-email-f.fangjian@huawei.com> (raw)
In-Reply-To: <1620736054-58412-1-git-send-email-f.fangjian@huawei.com>

From: Junhao He <hejunhao2@hisilicon.com>

Fix some coding style issues reported by checkpatch.pl, including
following types:

WARNING: void function return statements are not generally useful
WARNING: Possible unnecessary 'out of memory' message

Signed-off-by: Junhao He <hejunhao2@hisilicon.com>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
 drivers/perf/arm_spe_pmu.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c
index 8a1e86a..e3711cb 100644
--- a/drivers/perf/arm_spe_pmu.c
+++ b/drivers/perf/arm_spe_pmu.c
@@ -1044,7 +1044,6 @@ static void __arm_spe_pmu_dev_probe(void *info)
 		 spe_pmu->max_record_sz, spe_pmu->align, spe_pmu->features);
 
 	spe_pmu->features |= SPE_PMU_FEAT_DEV_PROBED;
-	return;
 }
 
 static void __arm_spe_pmu_reset_local(void)
@@ -1190,10 +1189,8 @@ static int arm_spe_pmu_device_probe(struct platform_device *pdev)
 	}
 
 	spe_pmu = devm_kzalloc(dev, sizeof(*spe_pmu), GFP_KERNEL);
-	if (!spe_pmu) {
-		dev_err(dev, "failed to allocate spe_pmu\n");
+	if (!spe_pmu)
 		return -ENOMEM;
-	}
 
 	spe_pmu->handle = alloc_percpu(typeof(*spe_pmu->handle));
 	if (!spe_pmu->handle)
-- 
2.8.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-11 13:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 12:27 [PATCH 0/4] drivers/perf: Fix ERRORs reported by checkpatch Jay Fang
2021-05-11 12:27 ` Jay Fang [this message]
2021-05-11 12:27 ` [PATCH 2/4] drivers/perf: arm_pmu: Fix some coding style issues Jay Fang
2021-05-11 12:27 ` [PATCH 3/4] drivers/perf: arm-cmn: Add space after ',' Jay Fang
2021-05-11 12:27 ` [PATCH 4/4] drivers/perf: arm-cci: Fix checkpatch spacing error Jay Fang
2021-05-25 18:58 ` [PATCH 0/4] drivers/perf: Fix ERRORs reported by checkpatch Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1620736054-58412-2-git-send-email-f.fangjian@huawei.com \
    --to=f.fangjian@huawei.com \
    --cc=hejunhao2@hisilicon.com \
    --cc=huangdaode@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).