* [PATCH bpf-next] bpf, arm64: Remove redundant switch case about BPF_DIV and BPF_MOD
@ 2021-05-18 8:56 Tiezhu Yang
2021-05-18 14:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Tiezhu Yang @ 2021-05-18 8:56 UTC (permalink / raw)
To: Daniel Borkmann, Alexei Starovoitov, Zi Shen Lim,
Catalin Marinas, Will Deacon, Andrii Nakryiko, Martin KaFai Lau,
Song Liu, Yonghong Song, John Fastabend, KP Singh
Cc: netdev, bpf, linux-arm-kernel, linux-kernel, Xuefeng Li
After commit 96a71005bdcb ("bpf, arm64: remove obsolete exception handling
from div/mod"), there is no need to check twice about BPF_DIV and BPF_MOD,
remove the redundant switch case.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
arch/arm64/net/bpf_jit_comp.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/net/bpf_jit_comp.c b/arch/arm64/net/bpf_jit_comp.c
index 9785026..be873a7 100644
--- a/arch/arm64/net/bpf_jit_comp.c
+++ b/arch/arm64/net/bpf_jit_comp.c
@@ -485,17 +485,12 @@ static int build_insn(const struct bpf_insn *insn, struct jit_ctx *ctx,
break;
case BPF_ALU | BPF_DIV | BPF_X:
case BPF_ALU64 | BPF_DIV | BPF_X:
+ emit(A64_UDIV(is64, dst, dst, src), ctx);
+ break;
case BPF_ALU | BPF_MOD | BPF_X:
case BPF_ALU64 | BPF_MOD | BPF_X:
- switch (BPF_OP(code)) {
- case BPF_DIV:
- emit(A64_UDIV(is64, dst, dst, src), ctx);
- break;
- case BPF_MOD:
- emit(A64_UDIV(is64, tmp, dst, src), ctx);
- emit(A64_MSUB(is64, dst, dst, tmp, src), ctx);
- break;
- }
+ emit(A64_UDIV(is64, tmp, dst, src), ctx);
+ emit(A64_MSUB(is64, dst, dst, tmp, src), ctx);
break;
case BPF_ALU | BPF_LSH | BPF_X:
case BPF_ALU64 | BPF_LSH | BPF_X:
--
2.1.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] bpf, arm64: Remove redundant switch case about BPF_DIV and BPF_MOD
2021-05-18 8:56 [PATCH bpf-next] bpf, arm64: Remove redundant switch case about BPF_DIV and BPF_MOD Tiezhu Yang
@ 2021-05-18 14:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-18 14:50 UTC (permalink / raw)
To: Tiezhu Yang
Cc: daniel, ast, zlim.lnx, catalin.marinas, will, andrii, kafai,
songliubraving, yhs, john.fastabend, kpsingh, netdev, bpf,
linux-arm-kernel, linux-kernel, lixuefeng
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
On Tue, 18 May 2021 16:56:10 +0800 you wrote:
> After commit 96a71005bdcb ("bpf, arm64: remove obsolete exception handling
> from div/mod"), there is no need to check twice about BPF_DIV and BPF_MOD,
> remove the redundant switch case.
>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> arch/arm64/net/bpf_jit_comp.c | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
Here is the summary with links:
- [bpf-next] bpf, arm64: Remove redundant switch case about BPF_DIV and BPF_MOD
https://git.kernel.org/bpf/bpf-next/c/119220d81258
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-18 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-18 8:56 [PATCH bpf-next] bpf, arm64: Remove redundant switch case about BPF_DIV and BPF_MOD Tiezhu Yang
2021-05-18 14:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).