From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46C03C433ED for ; Thu, 20 May 2021 13:38:39 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01C3C610A2 for ; Thu, 20 May 2021 13:38:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01C3C610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=hisilicon.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=cumziiFUPrITmgrre2+w2PMyj8zsvB+jNjF+++uxah0=; b=PGXaVrG/WluTEvC+IVKeSsEdXb Mdu6d1ACn0eGSsKZpLOpXOZxXi5gaOEBVK2We8esP3t6T80WSvWQPKS6qBddqXlZi4UBdepdfdZbA 3azlz5Du87r5Er44hGJFPM1AkPHf5IXt8dWe6P4iEzCGmXTqYXjlpQZUyJUGUJkzCGVJReHH4kTcZ i4mNj7m145UlBfyEhK+1SbE05n5ah5OpRV8UQdsqbqvloa+/tLvX6Av7+df2IhUxsC+hfKbydf9M/ BSugE0GTaWJVV2qcdM7gmgm55VEjx+nx4gtEUhzmCOsvTTzYrA7kJ4IB6bCldfTlXGFpAgVYPTB28 MgjFVv2g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljirK-001EJR-60; Thu, 20 May 2021 13:37:06 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljirH-001EIl-Ru for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 13:37:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:MIME-Version:Message-ID: Date:Subject:CC:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=IsOmqtlsXBD2MSe75Ju0f6PSasuIYZfweqSjbYJEFQ4=; b=SgUesvHEfOg7QZr4aDrdJPQfTj ZKKsTFWVE/bbXYPHjb+D3FRPbL+4H6fIZq2KvCZtvlkOXjuPEi3I9lvUAPM0vCY1aZEtSl8RrNQ82 rJmmzYMrF5+RYqXkR7Cryb90r906hFg/M3vTvfVqAi1bW/uYOiNQyoXc9Qtpk1Q44GhQ7x5O0Oc1q 6yPoZGROl45pLT3VbTCXaHqnJxbd2+pT0yI779bvz2YFZSlcG+qNnNkyuspzrD6okTL8JW/6gUf6C PddaacPxGCNacuHvl4A96ZGtjMlaT6F2P6PhmxM9gXKqLasu8kCmLUQBzYf6fwx0Q1ypRnf6pNtqT CLsR6MJA==; Received: from szxga04-in.huawei.com ([45.249.212.190]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljirE-00GNPj-48 for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 13:37:01 +0000 Received: from dggems705-chm.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Fm9gg5VHVz16Pqs; Thu, 20 May 2021 21:34:07 +0800 (CST) Received: from dggeme759-chm.china.huawei.com (10.3.19.105) by dggems705-chm.china.huawei.com (10.3.19.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Thu, 20 May 2021 21:36:54 +0800 Received: from localhost.localdomain (10.69.192.56) by dggeme759-chm.china.huawei.com (10.3.19.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 20 May 2021 21:36:54 +0800 From: Tian Tao To: , , CC: , , Tian Tao Subject: [PATCH] drm/exynos: Use pm_runtime_resume_and_get() to replace open coding Date: Thu, 20 May 2021 21:36:51 +0800 Message-ID: <1621517811-64765-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme759-chm.china.huawei.com (10.3.19.105) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_063700_349729_E66493F4 X-CRM114-Status: GOOD ( 10.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org use pm_runtime_resume_and_get() to replace pm_runtime_get_sync and pm_runtime_put_noidle. it also avoids the problem of positive return values so we can change if (ret < 0) to if (ret). Signed-off-by: Tian Tao --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index 3821ea7..6d94eae 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c @@ -268,11 +268,9 @@ static void mic_pre_enable(struct drm_bridge *bridge) if (mic->enabled) goto unlock; - ret = pm_runtime_get_sync(mic->dev); - if (ret < 0) { - pm_runtime_put_noidle(mic->dev); + ret = pm_runtime_resume_and_get(mic->dev); + if (ret) goto unlock; - } mic_set_path(mic, 1); -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel