linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Yong Wu <yong.wu@mediatek.com>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Irui Wang <irui.wang@mediatek.com>,
	Alexandre Courbot <acourbot@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	"Tiffany Lin" <tiffany.lin@mediatek.com>,
	Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Tomasz Figa <tfiga@google.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	"Maoguang Meng" <maoguang.meng@mediatek.com>,
	Longfei Wang <longfei.wang@mediatek.com>,
	 Yunfei Dong <yunfei.dong@mediatek.com>,
	"Fritz Koenig" <frkoenig@chromium.org>,
	Tzung-Bi Shih <tzungbi@chromium.org>,
	<linux-media@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	<srv_heupstream@mediatek.com>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v4,3/6] media: mtk-vcodec: Support 4GB~8GB range iova space for venc
Date: Sat, 22 May 2021 17:50:59 +0800	[thread overview]
Message-ID: <1621677059.2894.14.camel@mhfsdcap03> (raw)
In-Reply-To: <CA+Px+wXkn2ih0JdgKBOoHZU1=QqO=vE1MAP5tauHvRe=rtjg7g@mail.gmail.com>

On Fri, 2021-05-21 at 16:06 +0800, Tzung-Bi Shih wrote:
> On Fri, May 21, 2021 at 3:02 PM Irui Wang <irui.wang@mediatek.com> wrote:
> > +       if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL))
> > +               dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34));
> > +
> 
> From your previous dt-bindings patch[1], it has 4 banks.
> > 0~4G; 4G~8G; 8G~12G; 12G~16G.
> 
> But, the code treats it as a boolean.  I.e. 0~4GB if non-existent;
> otherwise, 4GB~8GB.

Here DMA_BIT_MASK(34) means dma address support 34bits(16GB).

The code is ok for me. Only the commit message should not say 4G-8G. it
could be something like:

Use the dma_set_mask_and_coherent helper to set venc DMA bit mask to
support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole
the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, Regarding which
iova range VENC actually locate, it depend on the dma-ranges property of
the venc dtsi node.

> 
> [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20210521070139.20644-3-irui.wang@mediatek.com/
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-22  9:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21  7:01 [PATCH v4,0/6] Support H264 4K on MT8192 Irui Wang
2021-05-21  7:01 ` [PATCH v4,1/6] media: mtk-vcodec: venc: remove redundant code Irui Wang
2021-05-21  8:05   ` Tzung-Bi Shih
2021-05-21  7:01 ` [PATCH v4, 2/6] dt-bindings: media: mtk-vcodec: Add dma-ranges property Irui Wang
2021-06-02 18:50   ` [PATCH v4,2/6] " Rob Herring
2021-05-21  7:01 ` [PATCH v4, 3/6] media: mtk-vcodec: Support 4GB~8GB range iova space for venc Irui Wang
2021-05-21  8:06   ` [PATCH v4,3/6] " Tzung-Bi Shih
2021-05-22  9:50     ` Yong Wu [this message]
2021-05-21  7:01 ` [PATCH v4, 4/6] dt-bindings: media: mtk-vcodec: Add binding for MT8192 VENC Irui Wang
2021-05-21  7:01 ` [PATCH v4,5/6] media: mtk-vcodec: Add MT8192 H264 venc driver Irui Wang
2021-05-21  8:06   ` Tzung-Bi Shih
2021-05-28  5:27   ` Dafna Hirschfeld
2021-06-03  3:55     ` Irui Wang
2021-05-21  7:01 ` [PATCH v4,6/6] media: mtk-vcodec: Support MT8192 H264 4K encoding Irui Wang
2021-05-21  8:06   ` [PATCH v4, 6/6] " Tzung-Bi Shih
2021-05-24  2:39     ` [PATCH v4,6/6] " Irui Wang
2021-05-28  5:57   ` [PATCH v4, 6/6] " Dafna Hirschfeld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1621677059.2894.14.camel@mhfsdcap03 \
    --to=yong.wu@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=acourbot@chromium.org \
    --cc=andrew-ct.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frkoenig@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=irui.wang@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=longfei.wang@mediatek.com \
    --cc=maoguang.meng@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    --cc=tfiga@google.com \
    --cc=tiffany.lin@mediatek.com \
    --cc=tzungbi@chromium.org \
    --cc=tzungbi@google.com \
    --cc=yunfei.dong@mediatek.com \
    --subject='Re: [PATCH v4,3/6] media: mtk-vcodec: Support 4GB~8GB range iova space for venc' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).