From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22FBEC4707F for ; Sat, 22 May 2021 09:54:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 94372611AD for ; Sat, 22 May 2021 09:54:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 94372611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xCpIpjAQYa4Bhd11y9lqvN7S+wy9spuVF45MNnaAmgw=; b=SElZei+vvotb7pCyRxp/AkhYSj X6JQwav46E2iTOxhV3g6fI6l8w0lsYC+I0w0YYZ/NyYmT1U5kCTk/hWwUZ5Z3NCGPSH4EVaGT5aX7 dV48z2NxYXKsuUTKVZTKfcwGNdWY8GteYNuLUqhXzU6ORuQNZIOkDCJ6sj/HyQZ9jLbfkOVhryT24 5HveRgp+2mrhKSaiaEyTpVZFbz661quXII2BKM7RFthvUcJvj1ZeV5IbRYBaM34DzRHd+RzOLhK/I 2DWm0F9zC9HaSN3W4m+/g0NqHJs5eQtPwBUSChyIrG69HMAXAgzKYEDlbxYOVCGdlQVlDpZjfeS5l AuHjCaLg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkOIH-002F2A-OD; Sat, 22 May 2021 09:51:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lkOI5-002F0W-4L; Sat, 22 May 2021 09:51:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=aaYsqkqjYTO4Peo/NYX1DMDat+z2Uuc/qMNttr4MZeA=; b=ITOqAw8nn/VYxbrgtTH6XxsQV8 zuBl5HrMG4gIvRIUcmHj5foLCl49Qdt8fABiEGgaUvoB9SOEpRO6PsgNLzV7ghw6WPd304MfMEb55 XB2ruowi4HoKoqCqyueBZqEuOE89Dbglf4+KMeQCVYh3BkhzOUpAhDo8Z22Rd/BUNwvjv1GUwzRtF A5G+e6Be0oU8g23OrBO4iv8Rncd1g+e8Oq6MkjMvtPw5T/AJRDEvs0Px/Mg2c8XtNLuyTcSE05J3J CJY/pRkRakssFOEape1M6m4M3YLY+1wz25D61CLxDt2eE66Ub9iDyKboPb2z4oJHkUMe3cqaDlheg tvipf8/g==; Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lkOHu-0004Iv-DI; Sat, 22 May 2021 09:51:27 +0000 X-UUID: 2d5dd32ab7644bf7841dd5a4efd4784c-20210522 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=aaYsqkqjYTO4Peo/NYX1DMDat+z2Uuc/qMNttr4MZeA=; b=A92OtWax3YtlXGlO7tVX6Q8xpWr3Ng4rLkSSc5Z03cxeqN9V4yZMpRvuRZkU0VSjYUe4Z3ZE+p3nJH0JSb7OGNWfruB00x3NEgqLaEx+6CXh2yTsld57ffud8mhje57Mhvdw+KMlEVtG015Dh2WWNTKZYYY5WzbXNFc3qMUef6w=; X-UUID: 2d5dd32ab7644bf7841dd5a4efd4784c-20210522 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 677813731; Sat, 22 May 2021 02:51:14 -0700 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 22 May 2021 02:51:12 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 22 May 2021 17:51:00 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 22 May 2021 17:50:59 +0800 Message-ID: <1621677059.2894.14.camel@mhfsdcap03> Subject: Re: [PATCH v4,3/6] media: mtk-vcodec: Support 4GB~8GB range iova space for venc From: Yong Wu To: Tzung-Bi Shih CC: Irui Wang , Alexandre Courbot , Hans Verkuil , "Tiffany Lin" , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , "Maoguang Meng" , Longfei Wang , Yunfei Dong , "Fritz Koenig" , Tzung-Bi Shih , , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , "moderated list:ARM/Mediatek SoC support" , , "moderated list:ARM/Mediatek SoC support" , Date: Sat, 22 May 2021 17:50:59 +0800 In-Reply-To: References: <20210521070139.20644-1-irui.wang@mediatek.com> <20210521070139.20644-4-irui.wang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: D209C5D26ECC073ABCE984EEC7E77BD5AD0A4CF1B0D8E0187A280BECBD0F64C82000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210522_025124_234204_0B6D8AF3 X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-05-21 at 16:06 +0800, Tzung-Bi Shih wrote: > On Fri, May 21, 2021 at 3:02 PM Irui Wang wrote: > > + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) > > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > > + > > From your previous dt-bindings patch[1], it has 4 banks. > > 0~4G; 4G~8G; 8G~12G; 12G~16G. > > But, the code treats it as a boolean. I.e. 0~4GB if non-existent; > otherwise, 4GB~8GB. Here DMA_BIT_MASK(34) means dma address support 34bits(16GB). The code is ok for me. Only the commit message should not say 4G-8G. it could be something like: Use the dma_set_mask_and_coherent helper to set venc DMA bit mask to support 34bits iova space(16GB) that the mt8192 iommu HW support. Whole the iova range separate to 0~4G/4G~8G/8G~12G/12G~16G, Regarding which iova range VENC actually locate, it depend on the dma-ranges property of the venc dtsi node. > > [1]: https://patchwork.linuxtv.org/project/linux-media/patch/20210521070139.20644-3-irui.wang@mediatek.com/ > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel