From: Irui Wang <irui.wang@mediatek.com>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Alexandre Courbot <acourbot@chromium.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Tiffany Lin <tiffany.lin@mediatek.com>,
"Andrew-CT Chen" <andrew-ct.chen@mediatek.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Tomasz Figa <tfiga@google.com>,
Hsin-Yi Wang <hsinyi@chromium.org>,
Maoguang Meng <maoguang.meng@mediatek.com>,
"Longfei Wang" <longfei.wang@mediatek.com>,
Yong Wu <yong.wu@mediatek.com>,
"Yunfei Dong" <yunfei.dong@mediatek.com>,
Fritz Koenig <frkoenig@chromium.org>,
Tzung-Bi Shih <tzungbi@chromium.org>,
<linux-media@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
<srv_heupstream@mediatek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v4,6/6] media: mtk-vcodec: Support MT8192 H264 4K encoding
Date: Mon, 24 May 2021 10:39:18 +0800 [thread overview]
Message-ID: <1621823958.25430.4.camel@mhfsdcap03> (raw)
In-Reply-To: <CA+Px+wU+6AtcFLxAHrEXOK=E+LhwM2iX0R0JOgBvv-xzGO=Bcw@mail.gmail.com>
On Fri, 2021-05-21 at 16:06 +0800, Tzung-Bi Shih wrote:
> On Fri, May 21, 2021 at 3:02 PM Irui Wang <irui.wang@mediatek.com> wrote:
> > fsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
> > - fsize->stepwise = mtk_venc_framesizes;
> > + fsize->stepwise =
> > + (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) ?
> > + mtk_venc_4k_framesizes : mtk_venc_hd_framesizes;
>
> Use a normal if .. else .. is more readable.
if (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE)
fsize->stepwise = mtk_venc_4k_framesizes;
else
fsize->stepwise = mtk_venc_hd_framesizes;
>
> > @@ -1210,6 +1231,9 @@ int mtk_vcodec_enc_ctrls_setup(struct mtk_vcodec_ctx *ctx)
> > {
> > const struct v4l2_ctrl_ops *ops = &mtk_vcodec_enc_ctrl_ops;
> > struct v4l2_ctrl_handler *handler = &ctx->ctrl_hdl;
> > + const u8 h264_max_level =
> > + (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE) ?
> > + V4L2_MPEG_VIDEO_H264_LEVEL_5_1 : V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
> Again, I would like it to be a normal if .. else ..
u8 h264_max_level;
if (ctx->dev->enc_capability & MTK_VENC_4K_CAPABILITY_ENABLE)
h264_max_level = V4L2_MPEG_VIDEO_H264_LEVEL_5_1;
else
h264_max_level = V4L2_MPEG_VIDEO_H264_LEVEL_4_2;
Patch V5 will be sent with these if there is no more comments.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-24 17:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 7:01 [PATCH v4,0/6] Support H264 4K on MT8192 Irui Wang
2021-05-21 7:01 ` [PATCH v4,1/6] media: mtk-vcodec: venc: remove redundant code Irui Wang
2021-05-21 8:05 ` Tzung-Bi Shih
2021-05-21 7:01 ` [PATCH v4, 2/6] dt-bindings: media: mtk-vcodec: Add dma-ranges property Irui Wang
2021-06-02 18:50 ` [PATCH v4,2/6] " Rob Herring
2021-05-21 7:01 ` [PATCH v4, 3/6] media: mtk-vcodec: Support 4GB~8GB range iova space for venc Irui Wang
2021-05-21 8:06 ` [PATCH v4,3/6] " Tzung-Bi Shih
2021-05-22 9:50 ` Yong Wu
2021-05-21 7:01 ` [PATCH v4, 4/6] dt-bindings: media: mtk-vcodec: Add binding for MT8192 VENC Irui Wang
2021-05-21 7:01 ` [PATCH v4,5/6] media: mtk-vcodec: Add MT8192 H264 venc driver Irui Wang
2021-05-21 8:06 ` Tzung-Bi Shih
2021-05-28 5:27 ` Dafna Hirschfeld
2021-06-03 3:55 ` Irui Wang
2021-05-21 7:01 ` [PATCH v4,6/6] media: mtk-vcodec: Support MT8192 H264 4K encoding Irui Wang
2021-05-21 8:06 ` [PATCH v4, 6/6] " Tzung-Bi Shih
2021-05-24 2:39 ` Irui Wang [this message]
2021-05-28 5:57 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1621823958.25430.4.camel@mhfsdcap03 \
--to=irui.wang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frkoenig@chromium.org \
--cc=hsinyi@chromium.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=longfei.wang@mediatek.com \
--cc=maoguang.meng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=tiffany.lin@mediatek.com \
--cc=tzungbi@chromium.org \
--cc=tzungbi@google.com \
--cc=yong.wu@mediatek.com \
--cc=yunfei.dong@mediatek.com \
--subject='Re: [PATCH v4,6/6] media: mtk-vcodec: Support MT8192 H264 4K encoding' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).