linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PCI: mobiveil: Remove unused readl and writel functions
@ 2021-05-10  2:30 Krzysztof Wilczyński
  2021-06-03 16:14 ` Lorenzo Pieralisi
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Wilczyński @ 2021-05-10  2:30 UTC (permalink / raw)
  To: Bjorn Helgaas
  Cc: Lorenzo Pieralisi, Hou Zhiqiang, Rob Herring, linux-pci,
	linux-arm-kernel

The PCIe host controller driver for Layerscape 4th generation SoC was
added in the commit d29ad70a813b ("PCI: mobiveil: Add PCIe Gen4 RC
driver for Layerscape SoCs").

At this time two static functions were introduced that appear to
currently have no users.  Since nothing is using neither of these
functions at the moment they can be safely removed.

This resolves the following build time warnings:

  drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c:45:19: warning: unused function 'ls_pcie_g4_lut_readl' [-Wunused-function]
  drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c:50:20: warning: unused function 'ls_pcie_g4_lut_writel' [-Wunused-function]

Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
 .../pci/controller/mobiveil/pcie-layerscape-gen4.c    | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c
index ee0156921ebc..306950272fd6 100644
--- a/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c
+++ b/drivers/pci/controller/mobiveil/pcie-layerscape-gen4.c
@@ -42,17 +42,6 @@ struct ls_pcie_g4 {
 	int irq;
 };
 
-static inline u32 ls_pcie_g4_lut_readl(struct ls_pcie_g4 *pcie, u32 off)
-{
-	return ioread32(pcie->pci.csr_axi_slave_base + PCIE_LUT_OFF + off);
-}
-
-static inline void ls_pcie_g4_lut_writel(struct ls_pcie_g4 *pcie,
-					 u32 off, u32 val)
-{
-	iowrite32(val, pcie->pci.csr_axi_slave_base + PCIE_LUT_OFF + off);
-}
-
 static inline u32 ls_pcie_g4_pf_readl(struct ls_pcie_g4 *pcie, u32 off)
 {
 	return ioread32(pcie->pci.csr_axi_slave_base + PCIE_PF_OFF + off);
-- 
2.31.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PCI: mobiveil: Remove unused readl and writel functions
  2021-05-10  2:30 [PATCH] PCI: mobiveil: Remove unused readl and writel functions Krzysztof Wilczyński
@ 2021-06-03 16:14 ` Lorenzo Pieralisi
  0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Pieralisi @ 2021-06-03 16:14 UTC (permalink / raw)
  To: Bjorn Helgaas, Krzysztof Wilczyński
  Cc: Lorenzo Pieralisi, Rob Herring, linux-arm-kernel, Hou Zhiqiang,
	linux-pci

On Mon, 10 May 2021 02:30:32 +0000, Krzysztof Wilczyński wrote:
> The PCIe host controller driver for Layerscape 4th generation SoC was
> added in the commit d29ad70a813b ("PCI: mobiveil: Add PCIe Gen4 RC
> driver for Layerscape SoCs").
> 
> At this time two static functions were introduced that appear to
> currently have no users.  Since nothing is using neither of these
> functions at the moment they can be safely removed.
> 
> [...]

Applied to pci/mobiveil, thanks!

[1/1] PCI: mobiveil: Remove unused readl and writel functions
      https://git.kernel.org/lpieralisi/pci/c/42d7a8dc19

Thanks,
Lorenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-03 16:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10  2:30 [PATCH] PCI: mobiveil: Remove unused readl and writel functions Krzysztof Wilczyński
2021-06-03 16:14 ` Lorenzo Pieralisi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).