From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5691C48BD1 for ; Fri, 11 Jun 2021 16:18:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B765F61181 for ; Fri, 11 Jun 2021 16:18:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B765F61181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PXOJVnXnYoDHZJP3tBeDhEdKImAgT8ZbMfCUm05nf+M=; b=09UWpcdSZNFnwn I5fnYo17ct7n2d0/umuk0PddlKjvsK+d8h9ndd/RAVmKg5HrowJ4c2MMpWFYeWL0FFy5lLTCi2GjM 8DLCmXP4xhwVpn2p+Tq492WJLbsl25f4XhaC4odAl6qIZ7AW4OmXmy9H2NyXU2hcFV88tqWFDevZZ P/pvoC2CD8cWeTPSQn1CjwjWszbBZBfqBCFZcH4Ogtl/BBJqx24U+EM8b4yDn4X8hSw4SefzpXNpy 5++blmm0m0K+ujnDKw/mrKqTfFQfboC54Xp3QcUJAP3YayZhVjqL/9kZsxPlpfOcda7HzDTcqu2Od NuN8Y5TG9/kxXSpD0CpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrjpw-005wsj-Ma; Fri, 11 Jun 2021 16:16:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrjpA-005wfE-GQ for linux-arm-kernel@lists.infradead.org; Fri, 11 Jun 2021 16:16:02 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 94582613D9; Fri, 11 Jun 2021 16:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623428160; bh=X8fq5Ssa8KruLdrdCiVfEs1JgSpE6Roo0bK+wmejB+k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=toHI7dqFyFs3RVKe8lF5VXSfnke6XT3P1GGiJdTo3FqWDIkpD/UMJwpTTHHUR++k8 TW6DmDB2XMJ4JqU9PbTHevr/DPIp/EoUPcmedvAkTGvZbw4FnQVOdzrs2NEYcocnYy lKsNALRdXg2ITl7mJcJK3fHjp4ywSZORfvfwmJFPyomJ3R7tCU9tdHsD5gQGkJ6d+6 J82qegUsU7v8pMbKZvDrhe2ADs9S795kAKWQbQ5eYOPo8I1xNN1j5OAM9sOxPdPzBI kRj5HSOqzcd1kfXsJGXUS7jwCLDaTgP9K23UVsfvdJwuPtUK2xSTE1/IYxgMVFGgKV V+ghr6emt7k9A== From: Will Deacon To: Sai Prakash Ranjan , Jordan Crouse , Xiyu Yang , Krishna Reddy , Rob Clark , Joerg Roedel , Robin Murphy , linux-arm-kernel@lists.infradead.org, Jon Hunter , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Xin Tan , yuanxzhang@fudan.edu.cn Subject: Re: [PATCH v2] iommu/arm-smmu: Fix arm_smmu_device refcount leak in address translation Date: Fri, 11 Jun 2021 17:15:43 +0100 Message-Id: <162340795809.3699041.237536515051087882.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <1623293391-17261-1-git-send-email-xiyuyang19@fudan.edu.cn> References: <1623293391-17261-1-git-send-email-xiyuyang19@fudan.edu.cn> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210611_091600_626913_13CB6668 X-CRM114-Status: UNSURE ( 7.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 10 Jun 2021 10:49:20 +0800, Xiyu Yang wrote: > The reference counting issue happens in several exception handling paths > of arm_smmu_iova_to_phys_hard(). When those error scenarios occur, the > function forgets to decrease the refcount of "smmu" increased by > arm_smmu_rpm_get(), causing a refcount leak. > > Fix this issue by jumping to "out" label when those error scenarios > occur. Applied to will (for-joerg/arm-smmu/updates), thanks! [1/1] iommu/arm-smmu: Fix arm_smmu_device refcount leak in address translation https://git.kernel.org/will/c/7c8f176d6a3f Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel