* [PATCH net-next] stmmac: dwmac-loongson: fix uninitialized variable in loongson_dwmac_probe()
@ 2021-06-22 11:51 Dan Carpenter
2021-06-22 17:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-06-22 11:51 UTC (permalink / raw)
To: Giuseppe Cavallaro
Cc: Alexandre Torgue, Jose Abreu, David S. Miller, Jakub Kicinski,
Maxime Coquelin, Qing Zhang, Jiaxun Yang, netdev, linux-stm32,
linux-arm-kernel, kernel-janitors
The "mdio" variable is never set to false. Also it should be a bool
type instead of int.
Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 8cd4e2e8ec40..e108b0d2bd28 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -49,7 +49,8 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
{
struct plat_stmmacenet_data *plat;
struct stmmac_resources res;
- int ret, i, mdio;
+ bool mdio = false;
+ int ret, i;
struct device_node *np;
np = dev_of_node(&pdev->dev);
--
2.30.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] stmmac: dwmac-loongson: fix uninitialized variable in loongson_dwmac_probe()
2021-06-22 11:51 [PATCH net-next] stmmac: dwmac-loongson: fix uninitialized variable in loongson_dwmac_probe() Dan Carpenter
@ 2021-06-22 17:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-22 17:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: peppe.cavallaro, alexandre.torgue, joabreu, davem, kuba,
mcoquelin.stm32, zhangqing, jiaxun.yang, netdev, linux-stm32,
linux-arm-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 22 Jun 2021 14:51:43 +0300 you wrote:
> The "mdio" variable is never set to false. Also it should be a bool
> type instead of int.
>
> Fixes: 30bba69d7db4 ("stmmac: pci: Add dwmac support for Loongson")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Here is the summary with links:
- [net-next] stmmac: dwmac-loongson: fix uninitialized variable in loongson_dwmac_probe()
https://git.kernel.org/netdev/net-next/c/b0e03950dd71
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-22 17:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-22 11:51 [PATCH net-next] stmmac: dwmac-loongson: fix uninitialized variable in loongson_dwmac_probe() Dan Carpenter
2021-06-22 17:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).