From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-arm-kernel@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Cristian Marussi <cristian.marussi@arm.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] firmware: arm_scmi: Fix possible scmi_linux_errmap buffer overflow
Date: Wed, 14 Jul 2021 17:36:45 +0100 [thread overview]
Message-ID: <162628055678.2615866.8496960821677425452.b4-ty@arm.com> (raw)
In-Reply-To: <20210707135028.1869642-1-sudeep.holla@arm.com>
On Wed, 7 Jul 2021 14:50:28 +0100, Sudeep Holla wrote:
> The scmi_linux_errmap buffer access index is supposed to depend on the
> array size to prevent element out of bounds access. It uses SCMI_ERR_MAX
> to check bounds but that can mismatch with the array size. It also
> changes the success into -EIO though scmi_linux_errmap is never used in
> case of success, it is expected to work for success case too.
>
> It is slightly confusing code as the negative of the error code
> is used as index to the buffer. Fix it by negating it at the start and
> make it more readable.
Applied to sudeep.holla/linux (for-next/scmi), thanks!
[1/1] firmware: arm_scmi: Fix possible scmi_linux_errmap buffer overflow
https://git.kernel.org/sudeep.holla/c/7a691f16cc
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-14 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 13:50 [PATCH] firmware: arm_scmi: Fix possible scmi_linux_errmap buffer overflow Sudeep Holla
2021-07-07 14:06 ` Cristian Marussi
2021-07-07 17:54 ` Sudeep Holla
2021-07-14 16:36 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=162628055678.2615866.8496960821677425452.b4-ty@arm.com \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).