From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 288DFC07E9A for ; Wed, 14 Jul 2021 16:49:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD481613C3 for ; Wed, 14 Jul 2021 16:49:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD481613C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pP4SgpBtpJF/Mf4snQbBAcPe8oHCfV68LxHKmLo1rTY=; b=0C8mzLBLbHaba/ nEmgoWJ+101ed2w//c8AX4WdDcVa7SfMFZUw6iQO/g6O0+YyeEb2mmgKkjScxm7swXQYkDfu1/mCv MTYe8nya3JR5l5cGzoFMrDuYcohQcy8zADGobdWGAUZFtv+raKIM1uYLccbU4nzni2kJmS7qC4o9x Xkr8WK6gdD91OcYKSfQCiXJv5K9xWUdGhNwPTxQfAtLQzl19eRk/7lfbBZ8eaSUn9R+SpvC5/mZ/L oXnH8wyiAI4mxYloME9TuM8GsA0GAyXW5/7c/RXGggWC0qfsdlA6oCyMSJ6GTrSpOYTRgxsgcs0Vb SSgzA91umOxfqZNw5otg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3i2h-00E9oe-FN; Wed, 14 Jul 2021 16:47:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3i2d-00E9nu-Pm for linux-arm-kernel@lists.infradead.org; Wed, 14 Jul 2021 16:47:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E8AD11042; Wed, 14 Jul 2021 09:47:22 -0700 (PDT) Received: from usa.arm.com (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3AF923F774; Wed, 14 Jul 2021 09:47:22 -0700 (PDT) From: Sudeep Holla To: Sudeep Holla , linux-arm-kernel@lists.infradead.org Cc: Dan Carpenter , kernel test robot Subject: Re: [PATCH] firmware: arm_ffa: Fix a possible ffa_linux_errmap buffer overflow Date: Wed, 14 Jul 2021 17:47:20 +0100 Message-Id: <162628122152.2616598.12573891711862117558.b4-ty@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210707134739.1869481-1-sudeep.holla@arm.com> References: <20210707134739.1869481-1-sudeep.holla@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210714_094723_926652_B1979527 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 7 Jul 2021 14:47:39 +0100, Sudeep Holla wrote: > The ffa_linux_errmap buffer access index is supposed to range from 0-8 > but it ranges from 1-9 instead. It reads one element out of bounds. It > also changes the success into -EINVAL though ffa_to_linux_errno is never > used in case of success, it is expected to work for success case too. > > It is slightly confusing code as the negative of the error code > is used as index to the buffer. Fix it by negating it at the start and > make it more readable. Applied to sudeep.holla/linux (for-next/ffa), thanks! [1/1] firmware: arm_ffa: Fix a possible ffa_linux_errmap buffer overflow https://git.kernel.org/sudeep.holla/c/dd925db6f0 -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel