linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [RFC] ARM: shmobile: Add early debugging support using SCIF(A)
Date: Tue, 07 Oct 2014 12:49:16 +0200	[thread overview]
Message-ID: <16427778.JB7cnWY0r4@wuerfel> (raw)
In-Reply-To: <1412276563-21473-1-git-send-email-geert+renesas@glider.be>

On Thursday 02 October 2014 21:02:43 Geert Uytterhoeven wrote:
> +       default 0xe6c40000 if DEBUG_SCIF && (ARCH_R8A73A4 || ARCH_SH7372)
> +       default 0xe6c50000 if DEBUG_SCIF && ARCH_R8A7740
> +       default 0xe6c80000 if DEBUG_SCIF && ARCH_SH73A0
> +       default 0xe6e58000 if DEBUG_SCIF && ARCH_R8A7794
> +       default 0xe6e60000 if DEBUG_SCIF && (ARCH_R8A7790 || ARCH_R8A7791 || ARCH_R8A7793)
> +       default 0xe8008000 if DEBUG_SCIF && ARCH_R7S72100

Just saw this patch. Note that most other entries do not depend on a particular
SoC but instead on one of the Kconfig entries, and I would like to eventually
change all of them to be the same way.

The main reason for this is that your way is a mix of two methods: if you
build a kernel for just one SoC you get the right entry here, but if you
build the kernel for multiple SoCs combined, you have to edit the address
by hand.

An alternative would be to not define a default here and document the
possible addresses in the help text for DEBUG_SCIF, so that users will
/always/ have to manually edit these, so at least it would be consistent.

	Arnd

  parent reply	other threads:[~2014-10-07 10:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 19:02 [PATCH] [RFC] ARM: shmobile: Add early debugging support using SCIF(A) Geert Uytterhoeven
2014-10-03  0:04 ` Khiem Nguyen
2014-10-03  7:21   ` Geert Uytterhoeven
2014-10-03 10:19     ` Khiem Nguyen
2014-10-03 11:28       ` Geert Uytterhoeven
2014-10-05 22:18 ` Laurent Pinchart
2014-10-06  6:03   ` Wolfram Sang
2014-10-06  6:14     ` Magnus Damm
2014-10-06  8:56     ` Geert Uytterhoeven
2014-10-06  9:01       ` Wolfram Sang
2014-10-06  9:08   ` Geert Uytterhoeven
2014-10-07 10:37   ` Ian Molton
2014-10-07 11:07     ` Geert Uytterhoeven
2014-10-07 12:39       ` Geert Uytterhoeven
2014-10-05 23:36 ` Magnus Damm
2014-10-06  9:18   ` Geert Uytterhoeven
2014-10-07 10:49 ` Arnd Bergmann [this message]
2014-10-07 11:46   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16427778.JB7cnWY0r4@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).