From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 435F4C433EF for ; Wed, 4 May 2022 19:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=k5G627OI9MTlFZEs5QrquWr9prLcnN5aGdVenDXCkGw=; b=geIBfIrkEDfDiJ VBzjPErgdG6G3QA3D6nsa/phx77p+aEj0Y/6WoKSOJbKT/VsiXEubb00p17lul66Od8W6k7ZWRbgl X9uPYgwn1xOk12L1MswOJ20eewJFBX1ngW6hkCzw2qln+eRmYuS26m1v4dMCt55sDvD6l7mNmoBU7 1v4dbHczB3gqaufzmi2vKMqNibcKu/GxIFsPnZlUp5yUoPiiLWzwnJrmw81o3KA4TjV7FuqlmrIgW atz/QF8cXBp2pNupqp3FnMssOqRphrmZVgYfdbX4qUoH84stZIqrGEbv0XPDhmjM96aaMi5CSmGKB 0B3RAJePAPz4UA2AfXtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmKVh-00CL1Y-6z; Wed, 04 May 2022 19:18:05 +0000 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nmKVe-00CL1E-8D for linux-arm-kernel@lists.infradead.org; Wed, 04 May 2022 19:18:03 +0000 Received: by mail-pj1-x102a.google.com with SMTP id p6so2091874pjm.1 for ; Wed, 04 May 2022 12:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RJ458gvu2KUZx9lG1pwBIKjP4BeRT8/YIZK4NnO4oyY=; b=Do0dXlMZ4W1vfBUdX+92o+0GKgu3uZLI4e2tkj5rlC3VvfGAyHGWK/Pu5A2p7fYCxb oiW4Q4iqZKHFmqTWa048UX7j3XctoQko0msUJJfFVhjAUQHsIW5Xro3txi6Ohw3ll2nI MxcVDocMB8aR2vBZ1Uqw8GU9MJhFbGq1JLSt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RJ458gvu2KUZx9lG1pwBIKjP4BeRT8/YIZK4NnO4oyY=; b=B7UWoG1VDJfG+BDSlJtzg5Er9EfHFks9k2HLZnPbf11wJBX1snJTNPPWbnHXzDWdHP tiI52PT4t3NyyskKQ/AVMBQTZOkP2W4zsrhuj8asD2wOLMP63HodxiibXrYTU6FHtg0t LIewvW74RufNUJGU87I2KXmQFhUGutuZhIRFs9x3OplI+Hm/VBOpljDy5WV8Z4HoTfOm TyxSODMr8VcFwWXk175FGdnlSLqgCZlZzcaCcvKAfo3JcuwcCsWRkNcCJArxIOMRoD4D h1LOGvDYyQvdlTvJUAGwJY0QrrnYoMK/Jp8R0uD7UtGV4nyreXQoI7CTdZJPnanjmEEO B4Qw== X-Gm-Message-State: AOAM533seFV6H8uGX70tpEx1t8NXzq4Yzg6gh+aSe+Zd/yDRJgwmlkaD Y9RQxiyhuF7i8VamhmcLyY9izA== X-Google-Smtp-Source: ABdhPJyd7mM+gd2ZuEYZdG+GHYfvr+RtBaQAY8PDsZhflxdnGLnhNLiCBzak8qO7cO0iccf+TcC7Sw== X-Received: by 2002:a17:902:e851:b0:15e:d129:fb20 with SMTP id t17-20020a170902e85100b0015ed129fb20mr1993458plg.140.1651691881297; Wed, 04 May 2022 12:18:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f9-20020a170902ce8900b0015e8d4eb1besm6984785plg.8.2022.05.04.12.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 12:18:00 -0700 (PDT) From: Kees Cook To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, alex.popov@linux.com Cc: Kees Cook , Andrew Morton , catalin.marinas@arm.com, will@kernel.org, luto@kernel.org Subject: Re: [PATCH v2 00/13] stackleak: fixes and rework Date: Wed, 4 May 2022 12:16:55 -0700 Message-Id: <165169181293.405194.8374667346806721563.b4-ty@chromium.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220427173128.2603085-1-mark.rutland@arm.com> References: <20220427173128.2603085-1-mark.rutland@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220504_121802_345694_2F9F96A5 X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 27 Apr 2022 18:31:15 +0100, Mark Rutland wrote: > This is the vs I promised. Since Alexander wanted to look at this in > more detail (and since this is subtle and needs review), I'm assuming > that Kees will pick this up some time next week after that's happened, > if all goes well. :) > > This series reworks the stackleak code and the associated LKDTM test. > The first patch fixes some latent issues on arm64, and the subsequent > patches improve the code to improve clarity and permit better code > generation. Patches 8-10 address some latent issues in the LKDTM test > and add more diagnostic output. > > [...] I fixed some small commit log typos, but otherwise this looks great. If anything new comes up we can adjust it. Applied to for-next/hardening, thanks! [01/13] arm64: stackleak: fix current_top_of_stack() https://git.kernel.org/kees/c/4c849d27b729 [02/13] stackleak: move skip_erasing() check earlier https://git.kernel.org/kees/c/e98a7c56d73c [03/13] stackleak: remove redundant check https://git.kernel.org/kees/c/e45d9f71deea [04/13] stackleak: rework stack low bound handling https://git.kernel.org/kees/c/cbe7edb47d3c [05/13] stackleak: clarify variable names https://git.kernel.org/kees/c/e9da2241ed85 [06/13] stackleak: rework stack high bound handling https://git.kernel.org/kees/c/cfef4372a4b7 [07/13] stackleak: rework poison scanning https://git.kernel.org/kees/c/ff5f6d37e5bc [08/13] lkdtm/stackleak: avoid spurious failure https://git.kernel.org/kees/c/23fd893fa0d7 [09/13] lkdtm/stackleak: rework boundary management https://git.kernel.org/kees/c/f4cfacd92972 [10/13] lkdtm/stackleak: prevent unexpected stack usage https://git.kernel.org/kees/c/c393c0b98d75 [11/13] lkdtm/stackleak: check stack boundaries https://git.kernel.org/kees/c/b6bf5a354eca [12/13] stackleak: add on/off stack variants https://git.kernel.org/kees/c/96c59349a56c [13/13] arm64: entry: use stackleak_erase_on_task_stack() https://git.kernel.org/kees/c/d46ac904fd35 -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel