Re: [PATCH v6 06/17] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip

From: Rob Herring <robh@kernel.org>
To: Brad Larson <brad@pensando.io>
Cc: catalin.marinas@arm.com, gerg@linux-m68k.org, gsomlo@gmail.com,
	adrian.hunter@intel.com, linux-mmc@vger.kernel.org,
	thomas.lendacky@amd.com, krzk@kernel.org, rdunlap@infradead.org,
	alcooperx@gmail.com, brijeshkumar.singh@amd.com,
	yamada.masahiro@socionext.com,
	linux-arm-kernel@lists.infradead.org, broonie@kernel.org,
	ulf.hansson@linaro.org, piotrs@cadence.com, p.yadav@ti.com,
	lee.jones@linaro.org, andy.shevchenko@gmail.com,
	suravee.suthikulpanit@amd.com, krzysztof.kozlowski+dt@linaro.org,
	blarson@amd.com, will@kernel.org, arnd@arndb.de,
	p.zabel@pengutronix.de, samuel@sholland.org,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	devicetree@vger.kernel.org, fancer.lancer@gmail.com
Subject: Re: [PATCH v6 06/17] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip
Date: Sun, 21 Aug 2022 15:21:26 -0500	[thread overview]
Message-ID: <1661113286.942295.1729142.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20220820195750.70861-7-brad@pensando.io>

On Sat, 20 Aug 2022 12:57:39 -0700, Brad Larson wrote:
> From: Brad Larson <blarson@amd.com>
> 
> Add support for the AMD Pensando Elba SoC System Resource chip
> using the SPI interface.  The Elba SR is a Multi-function Device
> supporting device register access using CS0, smbus interface for
> FRU and board peripherals using CS1, dual Lattice I2C masters for
> transceiver management using CS2, and CS3 for flash access.
> 
> Signed-off-by: Brad Larson <blarson@amd.com>
> ---
>  .../bindings/mfd/amd,pensando-elbasr.yaml     | 97 +++++++++++++++++++
>  1 file changed, 97 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
./Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml: Unable to find schema file matching $id: http://devicetree.org/schemas/reset/amd,pensando-elbasr-reset.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.example.dtb: system-controller@0: reset-controller@0: False schema does not allow {'compatible': ['amd,pensando-elbasr-reset'], 'reg': [[0]], '#reset-cells': [[1]]}
	From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml
Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.example.dtb:0:0: /example-0/spi/system-controller@0/reset-controller@0: failed to match any schema with compatible: ['amd,pensando-elbasr-reset']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel