linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
To: anil.s.keshavamurthy@intel.com, borntraeger@linux.ibm.com,
	catalin.marinas@arm.com, dave.hansen@linux.intel.com,
	gor@linux.ibm.com, guoren@kernel.org, hca@linux.ibm.com,
	hpa@zytor.com, linux-arm-kernel@lists.infradead.org,
	linux-csky@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,
	linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
	mark.rutland@arm.com, mhiramat@kernel.org, namit@vmware.com,
	palmer@dabbelt.com, paul.walmsley@sifive.com,
	peterz@infradead.org, x86@kernel.org,
	Yipeng Zou <zouyipeng@huawei.com>
Cc: chris.zjh@huawei.com, liaochang1@huawei.com
Subject: Re: [PATCH 0/2] make weak attributes in {k,u}probes
Date: Tue, 20 Sep 2022 22:32:46 +0530	[thread overview]
Message-ID: <1663692878.h3l8c563n8.naveen@linux.ibm.com> (raw)
In-Reply-To: <20220917015522.44583-1-zouyipeng@huawei.com>

Yipeng Zou wrote:
> We have some function implementation under some arch does nothing.
> We can mark it with weak attributes to improve.

That's not always an improvement. See [1] for an example, among many 
other patches to reduce use of __weak functions in the kernel.

As an alternative, please consider the approach used in [1].


- Naveen

[1] https://lore.kernel.org/all/20220519091237.676736-1-naveen.n.rao@linux.vnet.ibm.com/


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-09-20 17:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-17  1:55 [PATCH 0/2] make weak attributes in {k,u}probes Yipeng Zou
2022-09-17  1:55 ` [PATCH 1/2] kprobes: make arch_init_kprobes as weak Yipeng Zou
2022-09-17  1:55 ` [PATCH 2/2] uprobes: make arch_uprobe_exception_notify " Yipeng Zou
2022-09-17 10:58 ` [PATCH 0/2] make weak attributes in {k,u}probes Guo Ren
2022-09-20 17:02 ` Naveen N. Rao [this message]
2022-09-21  8:25   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1663692878.h3l8c563n8.naveen@linux.ibm.com \
    --to=naveen.n.rao@linux.ibm.com \
    --cc=anil.s.keshavamurthy@intel.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=catalin.marinas@arm.com \
    --cc=chris.zjh@huawei.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=gor@linux.ibm.com \
    --cc=guoren@kernel.org \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=liaochang1@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=namit@vmware.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    --cc=zouyipeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).