From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1873BC19F2B for ; Tue, 2 Aug 2022 09:55:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Aos1ehf2MSvAT5+S4uqiffkUcDdzKDSQdAmbL9d4uEU=; b=jCTY1fjUEDaa00 fXjkoDUDcgA4lyw1ag5WLqrgGwD4lNjsYSHfXSx8hi5zW6YSMfsLbyKsSA/jxVkn8xIZ8LwZZDd+m VoD6ky+qsuckCvqUflGHLx807DHjy28HVn3dbb5i+dG6soAhgj8r3OJAUGEE7hRR6/aXk2t4LG+7K XmFJDptPRQ4URvGDauPZfsbyLOU3WP4oLtigFhVOZx/z9W2hvIe0kpm5d5OQ6w2rPvNpiy0plF593 ej7Z5LOT9d7UcqTCx0nTjvf/UfpKGNQsMNfPqZH18FYTqAuy/dPtqe3TNhxs/ZD9g9vEPNj5hB5fz TYvT2raF/fjMixDkaF0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIobD-00CbJe-Dt; Tue, 02 Aug 2022 09:54:03 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oIob5-00Cb81-Tc; Tue, 02 Aug 2022 09:53:57 +0000 X-UUID: d4f09179576e498ea4c8dfe13c42aa84-20220802 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.8,REQID:8560e5a9-6ec2-48ba-8768-6bb4ebfe86d2,OB:0,LO B:0,IP:0,URL:5,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,RULE:Release_Ham,ACTI ON:release,TS:5 X-CID-META: VersionHash:0f94e32,CLOUDID:a0a611d0-a6cf-4fb6-be1b-c60094821ca2,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:1,File:nil ,QS:nil,BEC:nil,COL:0 X-UUID: d4f09179576e498ea4c8dfe13c42aa84-20220802 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1792703235; Tue, 02 Aug 2022 02:53:47 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Tue, 2 Aug 2022 17:43:11 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Tue, 2 Aug 2022 17:43:10 +0800 Message-ID: <1688f1aad1f7239e5b0eb3d45a854ca6b0e61e1a.camel@mediatek.com> Subject: Re: [PATCH v3] dt-bindings: PCI: mediatek-gen3: Add support for MT8188 and MT8195 From: Jianjun Wang To: Krzysztof Kozlowski , Bjorn Helgaas , Rob Herring , "Krzysztof Kozlowski" , Matthias Brugger CC: , , , , , Ryder Lee , , , , Date: Tue, 2 Aug 2022 17:43:10 +0800 In-Reply-To: References: <20220801113709.12101-1-jianjun.wang@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_025356_085027_2E9ADA29 X-CRM114-Status: GOOD ( 23.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thanks for your comment. On Tue, 2022-08-02 at 10:59 +0200, Krzysztof Kozlowski wrote: > On 01/08/2022 13:37, Jianjun Wang wrote: > > MT8188 and MT8195 are ARM platform SoCs with the same PCIe IP as > > MT8192. > > > > Also add new clock name "peri_mem" since the MT8188 and MT8195 use > > clock > > "peri_mem" instead of "top_133m". > > > > Signed-off-by: Jianjun Wang > > --- > > Changes in v3: > > Use enum property to add the new clock name. > > > > Changes in v2: > > Merge two patches into one. > > --- > > .../bindings/pci/mediatek-pcie-gen3.yaml | 14 > > ++++++++++++-- > > 1 file changed, 12 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie- > > gen3.yaml > > index 0499b94627ae..a0ca9c7f5dfa 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -48,7 +48,14 @@ allOf: > > > > properties: > > compatible: > > - const: mediatek,mt8192-pcie > > + oneOf: > > + - items: > > + - enum: > > + - mediatek,mt8188-pcie > > + - mediatek,mt8195-pcie > > + - const: mediatek,mt8192-pcie > > + - items: > > You have one item, so this is just const. Or enum if you expect it > to > grow soon. It makes sense, I'll remove this "items" and just keep the const item in the next version. Thanks. > > > + - const: mediatek,mt8192-pcie > > > > reg: > > maxItems: 1 > > @@ -84,7 +91,9 @@ properties: > > - const: tl_96m > > - const: tl_32k > > - const: peri_26m > > - - const: top_133m > > + - enum: > > + - top_133m # for MT8192 > > + - peri_mem # for MT8188/MT8195 > > This requires allOf:if:then restricting it further per variant. > > > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel