From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A819C5DF63 for ; Wed, 6 Nov 2019 15:06:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 373CA2178F for ; Wed, 6 Nov 2019 15:06:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WLm27EN6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 373CA2178F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:Subject:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qu9sHVFA1xJWFpvSDQOJif4XPjlOvu3FVFAsM2HV63k=; b=WLm27EN6EJI5OdceKVv9lYmt4 avA+0nwLnGrDT75PEKiKLyLyVTpOTRH5vycTXaeFEYSswM3PZjbz6XdbyXQEyEoyyu+coSeSo/oHb zxlFBxZYBsST4dHO9qQEicqcjVvjIy8JHVPhmMroERA0ESmgO1pDtxT0WV3p5NB8rXWKatADVwjxp MrIMCuhFaCIf+29VM1DO0jczCxPg0If7pIIbSE46cMpB+4b+B/rxQ1dG71oLjuhWEbFbLar5FOkf5 sm8jbLnGFMwzerQv0JJVCPxmWs1ji5t6/mGKxPaU+7QLuSFeldv3eppVPGqhna37L2fSM7W0C13A0 SMpAWHDcg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSMt7-0002mF-DS; Wed, 06 Nov 2019 15:06:25 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSMsc-0002Eu-MB for linux-arm-kernel@lists.infradead.org; Wed, 06 Nov 2019 15:05:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BD1D07CD; Wed, 6 Nov 2019 07:05:51 -0800 (PST) Received: from [10.1.32.101] (e122027.cambridge.arm.com [10.1.32.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EEA113F71A; Wed, 6 Nov 2019 07:05:48 -0800 (PST) From: Steven Price Subject: Re: [PATCH v15 00/23] Generic page walk and ptdump To: Qian Cai , Andrew Morton , linux-mm@kvack.org References: <20191101140942.51554-1-steven.price@arm.com> <1572896147.5937.116.camel@lca.pw> <7B040741-EC8A-4CC0-964B-4046AE2E617A@lca.pw> Message-ID: <16da6118-ac4d-a165-6202-0731a776ac72@arm.com> Date: Wed, 6 Nov 2019 15:05:29 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <7B040741-EC8A-4CC0-964B-4046AE2E617A@lca.pw> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191106_070554_798553_D579A773 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Dave Hansen , Arnd Bergmann , Ard Biesheuvel , Peter Zijlstra , Catalin Marinas , x86@kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Ingo Molnar , Borislav Petkov , Andy Lutomirski , "H. Peter Anvin" , James Morse , Thomas Gleixner , Will Deacon , linux-arm-kernel@lists.infradead.org, "Liang, Kan" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/11/2019 13:31, Qian Cai wrote: > > >> On Nov 4, 2019, at 2:35 PM, Qian Cai wrote: >> >> On Fri, 2019-11-01 at 14:09 +0000, Steven Price wrote: [...] >>> Changes since v14: >>> https://lore.kernel.org/lkml/20191028135910.33253-1-steven.price@arm.com/ >>> * Switch walk_page_range() into two functions, the existing >>> walk_page_range() now still requires VMAs (and treats areas without a >>> VMA as a 'hole'). The new walk_page_range_novma() ignores VMAs and >>> will report the actual page table layout. This fixes the previous >>> breakage of /proc//pagemap >>> * New patch at the end of the series which reduces the 'level' numbers >>> by 1 to simplify the code slightly >>> * Added tags >> >> Does this new version also take care of this boot crash seen with v14? Suppose >> it is now breaking CONFIG_EFI_PGT_DUMP=y? The full config is, >> >> https://raw.githubusercontent.com/cailca/linux-mm/master/x86.config >> > > V15 is indeed DOA here. Thanks for finding this, it looks like EFI causes issues here. The below fixes this for me (booting in QEMU). Andrew: do you want me to send out the entire series again for this fix, or can you squash this into mm-pagewalk-allow-walking-without-vma.patch? Thanks, Steve ---8<--- diff --git a/mm/pagewalk.c b/mm/pagewalk.c index c7529dc4f82b..70dcaa23598f 100644 --- a/mm/pagewalk.c +++ b/mm/pagewalk.c @@ -90,7 +90,7 @@ static int walk_pmd_range(pud_t *pud, unsigned long addr, unsigned long end, split_huge_pmd(walk->vma, pmd, addr); if (pmd_trans_unstable(pmd)) goto again; - } else if (pmd_leaf(*pmd)) { + } else if (pmd_leaf(*pmd) || !pmd_present(*pmd)) { continue; } @@ -141,7 +141,7 @@ static int walk_pud_range(p4d_t *p4d, unsigned long addr, unsigned long end, split_huge_pud(walk->vma, pud, addr); if (pud_none(*pud)) goto again; - } else if (pud_leaf(*pud)) { + } else if (pud_leaf(*pud) || !pud_present(*pud)) { continue; } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel