Re: [PATCH v4 09/19] dt-bindings: serial: samsung: Make samsung,uart-fifosize required property

From: Rob Herring <robh@kernel.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-serial@vger.kernel.org, olof@lixom.net,
	cw00.choi@samsung.com, andre.draszik@linaro.org,
	saravanak@google.com, jirislaby@kernel.org, arnd@arndb.de,
	krzysztof.kozlowski+dt@linaro.org, alim.akhtar@samsung.com,
	linux-gpio@vger.kernel.org, willmcvicker@google.com,
	tudor.ambarus@linaro.org, linux-samsung-soc@vger.kernel.org,
	mturquette@baylibre.com, soc@kernel.org, linux@roeck-us.net,
	linux-watchdog@vger.kernel.org, semen.protsenko@linaro.org,
	sboyd@kernel.org, robh+dt@kernel.org, conor+dt@kernel.org,
	wim@linux-watchdog.org, gregkh@linuxfoundation.org,
	will@kernel.org, linux-arm-kernel@lists.infradead.org,
	tomasz.figa@gmail.com, linus.walleij@linaro.org,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	s.nawrocki@samsung.com, kernel-team@android.com,
	catalin.marinas@arm.com
Subject: Re: [PATCH v4 09/19] dt-bindings: serial: samsung: Make samsung,uart-fifosize required property
Date: Mon, 20 Nov 2023 16:15:31 -0700	[thread overview]
Message-ID: <170052213161.3706337.15818635228108481923.robh@kernel.org> (raw)
In-Reply-To: <20231120212037.911774-10-peter.griffin@linaro.org>

On Mon, 20 Nov 2023 21:20:27 +0000, Peter Griffin wrote:
> Specifying samsung,uart-fifosize in both DT and driver static data is error
> prone and relies on driver probe order and dt aliases to be correct.
> 
> Additionally on many Exynos platforms these are (USI) universal serial
> interfaces which can be uart, spi or i2c, so it can change per board.
> 
> For google,gs101-uart and exynosautov9-uart make samsung,uart-fifosize a
> required property. For these platforms fifosize now *only* comes from DT.
> 
> It is hoped other Exynos platforms will also switch over time.
> 
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  .../bindings/serial/samsung_uart.yaml           | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/serial/samsung_uart.yaml:141:8: [warning] wrong indentation: expected 8 but found 7 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231120212037.911774-10-peter.griffin@linaro.org

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel