From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 526E1C282CE for ; Wed, 22 May 2019 12:35:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26B6B2173C for ; Wed, 22 May 2019 12:35:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MU44mJ0D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26B6B2173C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aDxJKzp08KxXgmop/23vmSVeqdsGOfzsfBLpAstodPo=; b=MU44mJ0Dz01ymd Z581PMxLHiq5wqnlhPdoM1zAHpMzBmATW5TQTOStOs6iSrsbT+56UCdw3H8HVqGZ7w2j0D+2wS+pZ RrMPNlaw9nJqHXRZimu61/zxT2X1VVnm86fdOcdZBNsTWfOM/mHYoEF6FMTHdw3W1DmDjtdKm7iRO rhl7wUWi4IRxcgbnMcsQpaFgYARdRz6UPFo/tvz4r529r/T9OcRxP9xhxxIBoP3x2KO6/VVbpMA6i 3Gknhl33oWN+EIc2WQTdxY1Xer/w1VN7MHfHAT30Xa5v8L929rGLKtpDaioOIRF/T8VtW0R8pyHoa lpDXOr8RWNq94QUonYJw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTQSb-0006ME-T1; Wed, 22 May 2019 12:35:09 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hTQSX-0005lQ-VR; Wed, 22 May 2019 12:35:07 +0000 Received: from we0524.dip.tu-dresden.de ([141.76.178.12] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hTQSR-0000lq-OK; Wed, 22 May 2019 14:34:59 +0200 From: Heiko Stuebner To: Daniel Lezcano Subject: Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error Date: Wed, 22 May 2019 14:34:58 +0200 Message-ID: <1805430.MCm2xJzUXA@phil> In-Reply-To: References: <1556618986-18923-1-git-send-email-zhangqing@rock-chips.com> <2174314.1vfUlvne1O@phil> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190522_053506_190181_3765D8DE X-CRM114-Status: GOOD ( 14.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , huangtao@rock-chips.com, Doug Anderson , Linux PM list , Enric Balletbo Serra , xxx@rock-chips.com, Elaine Zhang , linux-kernel , vicencb@gmail.com, xf@rock-chips.com, Eduardo Valentin , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , Rob Herring , Zhang Rui , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 22. Mai 2019, 14:30:16 CEST schrieb Daniel Lezcano: > On 22/05/2019 14:27, Heiko Stuebner wrote: > > [ ... ] > > >> As this change is now in mainline and is causing veyron to hang I'd > >> suggest reverting this change for now. Even fixing the root cause > >> (maybe the one I pointed above) after this patch we will have the > >> thermal driver to fail because "gpio" and "otpout" states are not > >> defined nor documented (a change on this will need some reviews and > >> acks and time I guess). > > > > I definitly agree here. Handling + checking the binding change > > as well as needed fallback code is definitly not material for -rc-kernels > > so we should just revert for now and let Elaine fix the issues for 5.3. > > > > Anyone volunteering for sending a revert-patch to Eduardo? :-) > > I can't right now :/ ok, I'll do the revert patch then, so that we get this sorted. Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel